Ubuntu
frozen-bubble package

patch to fix frozen bubble level editor open levelset dialog bug

Bug #181933 reported by David Joham
4
Affects Status Importance Assigned to Milestone
frozen-bubble (Debian)
Fix Released
Unknown
frozen-bubble (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Binary package hint: frozen-bubble

Hello all,

The frozen bubble level editor has a minor but annoying defect when the user attempts to open a levelset. The defect is that an artifact from the "choose levelset level to play" dialog (from the start 1 player game menu) shows up on the "open levelset" dialog as well.

It looks like when gc (maintainer of frozen-bubble) merged in some of my changes, something went haywire and some code ended up where it shouldn't have been. This patch removes the offending code and fixes the dialog.

I've submitted this patch to gc to fix as well, but I don't know what his time table is for getting it into an official version.

--- FBLE.pm 2008-01-04 20:56:11.000000000 -0800
+++ FBLE.pm.fixed 2008-01-04 20:55:49.000000000 -0800
@@ -1363,10 +1363,6 @@
      }
         }
         $list_browser_highlight_offset = $file_highlight_offset;
- if (is_ok_select_start_value($start_level) == 0) {
- $start_level = $file_browser_levelsets_num_levels[$list_browser_highlight_offset];
- show_selected_level();
- }
         display_levelset_screenshot();
     } else {
         $list_browser_highlight_offset = $file_highlight_offset;

Tags: patch
Revision history for this message
David Joham (djoham) wrote :

patch

Revision history for this message
Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount) wrote :
Revision history for this message
Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount) wrote :

Subscribin u-u-s

Changed in frozen-bubble:
status: New → Confirmed
Revision history for this message
Cesare Tirabassi (norsetto) wrote :

The debdiff looks good, but, have you checked that the patch does what it claims it does?

Changed in frozen-bubble:
assignee: nobody → mariobonino
status: Confirmed → In Progress
Revision history for this message
Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount) wrote :

Yes, it seems so.

Changed in frozen-bubble:
assignee: mariobonino → nobody
status: In Progress → Confirmed
Cesare Tirabassi (norsetto)
Changed in frozen-bubble:
assignee: nobody → norsetto
importance: Undecided → Low
status: Confirmed → In Progress
Revision history for this message
Cesare Tirabassi (norsetto) wrote :

Then please explain to me how to trigger this because I can't.
What is the problem and how it is fixed by this patch!?

Changed in frozen-bubble:
assignee: norsetto → mariobonino
Revision history for this message
David Joham (djoham) wrote :

To recreate:

1) open frozen bubble
2) go to the level editor
3) in the upper right hand "Level Set" section, click on "open"

A dialog will open which will have a "text box" that shouldn't be there.

The problem is that the method show_selected_level is called when it shouldn't be. The selected level is irrelevant for this dialog so those lines of code should be removed.

I'll include screenshots of the defect in this post and a screenshot of the patched version in the next

Revision history for this message
David Joham (djoham) wrote :

with the patch, the dialog looks like this - and as it should

Revision history for this message
Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount) wrote :

Right, this is what the patch changes even here. :)

Changed in frozen-bubble:
assignee: mariobonino → nobody
status: In Progress → Confirmed
Revision history for this message
Cesare Tirabassi (norsetto) wrote :

OK, thank you both for your work.
Mario, can you please submit this patch to debian?
Also, you used dpatch while the previous Ubuntu change didn't. You did the right thing but I would also add the previous change as a dpatch one so that we have some consistency. Can you do that?
Please make the changelog also a bit more clear, for instance:

   * debian/rules, debian/control, debian/patches/00list:
     - added dpatch support
   * debian/patches/fble_open_dialog.dpatch:
     - fixed level editor showing selected level (LP: #181933)
       (thanks to David Joham for the patch)

Changed in frozen-bubble:
assignee: nobody → mariobonino
status: Confirmed → In Progress
Revision history for this message
Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount) wrote : Re: [Bug 181933] Re: patch to fix frozen bubble level editor open levelset dialog bug

Thank you for your comment Cesare, I will soon do that.

Revision history for this message
Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount) wrote :
Revision history for this message
Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount) wrote :

Done, subscribing u-u-s.

Changed in frozen-bubble:
assignee: mariobonino → nobody
status: In Progress → Confirmed
Revision history for this message
Cesare Tirabassi (norsetto) wrote :

Thanks you. I just updated the date (was still 11 Jan) otherwise was very good!

Changed in frozen-bubble:
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package frozen-bubble - 2.1.0-2ubuntu2

---------------
frozen-bubble (2.1.0-2ubuntu2) hardy; urgency=low

  * debian/rules, debian/control,
    debian/patches/00list:
    - added dpatch support
  * debian/patches/fble_open_dialog.dpatch:
    - fixed level editor showing selected level (LP: #181933)
      (thanks to David Joham for the patch)
  * debian/patches/nick-truncated-to-8-chars.dpatch:
    - included previous change

 -- Mario Bonino <email address hidden> Sun, 27 Jan 2008 15:59:01 +0100

Changed in frozen-bubble:
status: Fix Committed → Fix Released
Bug Watch Updater (bug-watch-updater)
Changed in frozen-bubble:
status: Unknown → New
Artur Rona (ari-tczew)
tags: added: patch
Bug Watch Updater (bug-watch-updater)
Changed in frozen-bubble (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.