New Microsoft Azure Linux Agent

So currently, without any modifications, the new walinuxagent packages (based on 2.2.32) fail to build due to failing unit-tests. Apparently for all the previous walinuxagent versions in Ubuntu, no unit-tests have been running during build because of a bug in setup.py (fixed recently in PR #1244 [1]). Only now we actually see the tests running. I did a similar change to the current cosmic package and also saw many similar failures.

Were all the walinuxagent unit-tests expected to pass on Ubuntu? Some tests will obviously fail (like the cgroup ones) because of the builder environment, but there's also a lot of others that I wouldn't normally expect to fail - but they're failing on the new and old walinuxagent.

Possibly what we'll do is ignore the failures for this release (it's a possibility), unless the expectation was that those should have been passing already. For the next release we would really need to have those passing though. Maybe move out some of them (like the cgroup ones) as autopkgtests, since only then they could actually work.

What's the case here?

[1] https://github.com/Azure/WALinuxAgent/pull/1244

Example logs of a build failing due to unit-test failures:

https://launchpadlibrarian.net/395192988/buildlog_ubuntu-cosmic-amd64.walinuxagent_2.2.32-0ubuntu1~test2_BUILDING.txt.gz

Filled in a bug to explicitly track the unit-test failures:
https://bugs.launchpad.net/ubuntu/+source/walinuxagent/+bug/1800499

But for now, until we get some clarity, this is a blocker for getting the new wala out.

I looked at the test failures and they are caused by environmental differences from our automation. Apart from the cgroup tests that you already mentioned, a few test are issuing requests to an internal endpoint, and some mocks need improving. Also, it looks like for some reason some of the mock data is not being picked up correctly.

We run those tests on Ubuntu routinely so, if this is OK for you, we could go ahead as is for this release.

How can I replicate your builder environment? I can work on fixing the failing tests.

Thank you.

This bug was fixed in the package walinuxagent - 2.2.32-0ubuntu1

---------------
walinuxagent (2.2.32-0ubuntu1) disco; urgency=medium

  * New upstream release (LP: #1799498).
  * debian/patches/disable_import_test.patch: refreshed patch.
  * debian/control:
    - Add the python3-mock build-dependency.
  * debian/rules:
    - Run unit tests but don't fail the build if they fail. Previously, due to
      a bug in setup.py, those were never being run during build so the
      failures are not regressions.

 -- Łukasz 'sil2100' Zemczak <email address hidden> Mon, 29 Oct 2018 09:13:23 +0100

The SRU exception states that:
  the CPC team will write new automated tests to cover new testable functionality (if any) in the new package

Has this been done?

> The SRU exception states that:
> the CPC team will write new automated tests to cover new testable functionality (if any) in the > new package
>
> Has this been done?

@Steve,

There is no new functionality or features in this release of walinuxagent that require new automated tests. CPC is happy to sign-off on this requirement as complete.

Hello Roiy, or anyone else affected,

Accepted walinuxagent into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/walinuxagent/2.2.32-0ubuntu1~18.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Roiy, or anyone else affected,

Accepted walinuxagent into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/walinuxagent/2.2.32-0ubuntu1~18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Roiy, or anyone else affected,

Accepted walinuxagent into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/walinuxagent/2.2.32-0ubuntu1~16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Roiy, or anyone else affected,

Accepted walinuxagent into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/walinuxagent/2.2.32-0ubuntu1~14.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-trusty to verification-done-trusty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-trusty. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

I upgraded walinuxagent to version 2.2.32-0ubuntu1 (from -proposed) on 4 instances (trusty, xenial, bionic and cosmic). I rebooted the 4 instances and verified the serial console still works for each one. I didn't run additional tests. Maybe the Azure team has more in-depth automated tests they can run for each Ubuntu release?

I also noticed walinuxagent in Ubuntu 18.10 (cosmic) installed the python3-distro dependency when upgrading the walinuxagent package (which was expected).

Microsoft's testing has turned up https://bugs.launchpad.net/ubuntu/+source/walinuxagent/+bug/1806972 as an issue in the latest version of walinuxagent, which will need addressing before we can SRU it.

It turns out there was an issue with the way that Microsoft was testing these images, which has now been resolved. These packages have been signed off on.

This bug was fixed in the package walinuxagent - 2.2.32-0ubuntu1~18.10.1

---------------
walinuxagent (2.2.32-0ubuntu1~18.10.1) cosmic; urgency=medium

  * Backport of the disco version.
  * New upstream release (LP: #1799498).
  * debian/patches/disable_import_test.patch: refreshed patch.
  * debian/control:
    - Add the python3-mock build-dependency.
  * debian/rules:
    - Run unit tests but don't fail the build if they fail. Previously, due to
      a bug in setup.py, those were never being run during build so the
      failures are not regressions.

 -- Łukasz 'sil2100' Zemczak <email address hidden> Mon, 29 Oct 2018 09:13:23 +0100

The verification of the Stable Release Update for walinuxagent has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package walinuxagent - 2.2.32-0ubuntu1~18.04.1

---------------
walinuxagent (2.2.32-0ubuntu1~18.04.1) bionic; urgency=medium

  * Backport of the disco version.
  * New upstream release (LP: #1799498).
  * debian/patches/disable_import_test.patch: refreshed patch.
  * debian/control:
    - Add the python3-mock build-dependency.
  * debian/rules:
    - Run unit tests but don't fail the build if they fail. Previously, due to
      a bug in setup.py, those were never being run during build so the
      failures are not regressions.

 -- Łukasz 'sil2100' Zemczak <email address hidden> Mon, 29 Oct 2018 09:13:23 +0100

This bug was fixed in the package walinuxagent - 2.2.32-0ubuntu1~16.04.1

---------------
walinuxagent (2.2.32-0ubuntu1~16.04.1) xenial; urgency=medium

  * Backport of the disco version.
  * New upstream release (LP: #1799498).
  * debian/patches/disable_import_test.patch: refreshed patch.
  * debian/control:
    - Add the python3-mock build-dependency.
  * debian/rules:
    - Run unit tests but don't fail the build if they fail. Previously, due to
      a bug in setup.py, those were never being run during build so the
      failures are not regressions.

 -- Łukasz 'sil2100' Zemczak <email address hidden> Mon, 29 Oct 2018 09:13:23 +0100

This bug was fixed in the package walinuxagent - 2.2.32-0ubuntu1~14.04.1

---------------
walinuxagent (2.2.32-0ubuntu1~14.04.1) trusty; urgency=medium

  * Backport of the disco version.
  * New upstream release (LP: #1799498).
  * debian/patches/disable_import_test.patch: refreshed patch.
  * debian/control:
    - Add the python3-mock build-dependency.
  * debian/rules:
    - Run unit tests but don't fail the build if they fail. Previously, due to
      a bug in setup.py, those were never being run during build so the
      failures are not regressions.

 -- Łukasz 'sil2100' Zemczak <email address hidden> Mon, 29 Oct 2018 09:13:23 +0100