Ubuntu
gnome-software package

Unable to update software - Button Restart & Update, restarts no updates applied

Bug #1797543 reported by Tino Meinen
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-software (Ubuntu)
Fix Released
High
Robert Ancell
Cosmic
Fix Released
High
Robert Ancell

Bug Description

[Impact]
.deb package updates are shown in GNOME Software and the user is prompted to "Restart & Update". They are not updated during the restart.

[Test Case]
1. Have a system with updates available
2. Open GNOME Software
3. Go to Updates page

Expected result:
No updates are shown (they are shown in software-properties-gtk)

Observed result:
Updates are shown, and the user is prompted to "Restart & Update".

[Regression Potential]
The fix is to update the patch to work with architectural changes that occurred in gnome-software 3.30. The additional code stops an update function from being called and is unlikely to impact other changes. There could potentially be other changes that have been missed (this seems like a low risk).

[Original description]

Ubuntu 18.10 beta (up to date as of 12-10-2018)
Ubuntu software 3.30.2

DESCRIPTION OF BEHAVIOUR
When updates are available, Ubuntu-Software shows updates are available in the "Updates" tab.

One of the updates available shows "OS Updates"

The grey coloured heading right above the available updates, has "Requires Restart" on the left and a green button "Restart & Update".

When the green button is clicked, a popup window appears immediately showing "Restart, the system will restart automatically in 60 seconds" counting down. The restart can be cancelled or activated.

When activated (either automatically or manually) the computer restarts immediately and no software is being updated.

After logging in and starting up Ubuntu Software, the Updates tab checks and then shows the same updates being available as before.

---
The button on the Updates tab should rather offer to update all available software and only offer to restart the computer after the updates are completed.

See original description
Tino Meinen (a-t-meinen)
description: updated
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your bug report, could you provide the output of those commands
- dpkg -l | grep gnome-software
- which gnome-software
- echo $XDG_CURRENT_DESKTOP

could you also provide a screenshot showing the issue? The Ubuntu version of gnome-software is not supposed to list "OS updates" as you describe...

Changed in gnome-software (Ubuntu):
importance: Undecided → Low
status: New → Incomplete
Revision history for this message
Sebastien Bacher (seb128) wrote :

Ignore that, I can confirm with today's cosmic on a fresh install
- install daily
- open update-manager to refresh the apt index
- gnome-software displays an "updates are available" notification and the update tab has the OS updates and a restart&install updates button

That's problematic especially that it's likely that the "restart&update" button sends packagekit in offline upgrade mode which isn't working without issue on Ubuntu/Debian due to debconf

Changed in gnome-software (Ubuntu):
status: Incomplete → Confirmed
importance: Low → High
assignee: nobody → Robert Ancell (robert-ancell)
tags: added: rls-cc-incoming
Revision history for this message
Tino Meinen (a-t-meinen) wrote :
Revision history for this message
Tino Meinen (a-t-meinen) wrote :

Thank you Sebastian for looking into this and confirming the bug.

I've added a screenshot nonetheless for people who currently don't have updates in their queue so they can see what it looks like.

and for completeness, the output of the commands are:

- dpkg -l | grep gnome-software
ii gnome-software 3.30.2-0ubuntu2 amd64 Software Center for GNOME
ii gnome-software-common 3.30.2-0ubuntu2 all Software Center for GNOME (common files)
ii gnome-software-plugin-snap 3.30.2-0ubuntu2 amd64 Snap support for GNOME Software

- which gnome-software
/usr/bin/gnome-software

- echo $XDG_CURRENT_DESKTOP
ubuntu:GNOME

Revision history for this message
Robert Ancell (robert-ancell) wrote :

I'm guessing debian/patches/0006-packagekit-Disable-updates-LP-1775226.patch is no longer working? Investigating why that might be (I didn't work on that change before).

Revision history for this message
Robert Ancell (robert-ancell) wrote :

It seems skipping gs_plugin_add_updates in plugins/packagekit/gs-plugin-packagekit.c seems to fix this.

Robert Ancell (robert-ancell)
Changed in gnome-software (Ubuntu):
status: Confirmed → Fix Committed
description: updated
Robert Ancell (robert-ancell)
summary: - Gnome-software - unable to update software - Button Restart & Update,
- restarts no updates applied
+ Unable to update software - Button Restart & Update, restarts no
+ updates applied
Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Tino, or anyone else affected,

Accepted gnome-software into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-software/3.30.2-0ubuntu4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed verification-needed-cosmic
Revision history for this message
Tino Meinen (a-t-meinen) wrote :

Thank you Robert Ancell and Steve Langasek.

Your patch fixed the issue.

I've updated gnome-software, gnome-software-common and gnome-software-plugin-snap to version 3.30.2-0ubuntu4 (only those packages, I left other available updates in the queue to be able to test the updated version)

It now shows no updates available in the updates tab, and a tick mark with the text Software is up to date in the main window.
(screenshot attached)

Thank you again for acting so quickly on this issue, I'm very impressed!

tags: added: verification-done verification-done-cosmic
removed: verification-needed verification-needed-cosmic
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-software - 3.30.2-0ubuntu4

---------------
gnome-software (3.30.2-0ubuntu4) cosmic; urgency=medium

  * debian/patches/0006-packagekit-Disable-updates.patch:
    - Stop offline updates from showing again (LP: #1797543)

 -- Robert Ancell <email address hidden> Tue, 16 Oct 2018 16:01:07 +1300

Changed in gnome-software (Ubuntu Cosmic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.