Awn

[Patch] Use of tabs instead of a list in the Manager

Bug #179666 reported by Rémi Audebert on 2008-01-01

Affects		Status	Importance	Assigned to	Milestone
	Awn	Fix Released	Low	Awn Testing Team	Awn 0.2.4-milestone

Bug Description

Hi
Currently the manager use a list and an horrible hack to display the different configuration panels.
With this patch the manager use a notebook making window.glade more natural.

See original description

Tags:

Revision history for this message

Rémi Audebert (raude) wrote on 2008-01-01:

Complete patch (awnManager.in.py & window.glade) Edit (300.7 KiB, text/plain)

description:

updated

Revision history for this message

Mark Lee (malept) wrote on 2008-01-01:

Thanks for tagging the bug appropriately.

This is a rather large patch, so I'm hesitant to place it in my branch without seeing a screenshot of the "new" awn-manager. Do you mind attaching one to the bug?

Revision history for this message

Rémi Audebert (raude) wrote on 2008-01-02:

Manager with tabs Edit (59.0 KiB, image/png)

In reality this is not a *large* patch, because GTK handle the tab managing so I remove the related parts in awnManager.in.py.
Concerning window.glade, I moved the panels in the tabs therefore the patch look huge but its only code movement.

Revision history for this message

Rémi Audebert (raude) wrote on 2008-01-02:

*so I removeD
*its > it's

Sorry.

Revision history for this message

Julien Lavergne (gilir) wrote on 2008-01-08:

Thanks for the patch.
I added it to the awn-testing branch to test it before include it in trunk.

Changed in awn:
assignee:	nobody → awn-testing
importance:	Undecided → Low
status:	New → In Progress

Revision history for this message

Michal Hruby (mhr3) wrote on 2008-01-09:

Adding my vote for including to trunk.

Revision history for this message

Mark Lee (malept) wrote on 2008-01-09:

I appreciate how much better this will look when working on the interface in glade.

On an aesthetic note, I'd like to have the text below the icon in this mode, otherwise the tabs look rather strange. I can take a stab at it, when I get some time.

Revision history for this message

Ryan Rushton (ryancr) wrote on 2008-01-10:

Just a funny note, this is how I had the manager setup up back in July.

http://bayimg.com/laeIGAaBL

http://awn.planetblur.org/index.php?shard=forum&action=g_reply&ID=493#4776

But it was suggested that I not go that way.

http://awn.planetblur.org/index.php?shard=forum&action=g_reply&ID=493#4790
http://awn.planetblur.org/index.php?shard=forum&action=g_reply&ID=493#4792

To be honest I like the tabs, as long as the tab names stay a reasonable length.

Revision history for this message

Andrew Starr-Bochicchio (andrewsomething) wrote on 2008-01-12:

revno: 162
committer: Julien Lavergne <seagle@justice>
branch nick: awn-core-trunk
timestamp: Sun 2008-01-13 00:01:06 +0100
message:
2008-01-12 Julien Lavergne <email address hidden>

       * awn-manager/awnManager.in.py:
       * awn-manager/window.glade:
       * libawn/awn-effects.c:
       Merge revision 161 and 162 of awn-core-testing branch
       - Close bug #179666 : Use of tabs instead of a list in the awn-manager (Patch from Rémi Audebert)
       - Close bug #179783 : Prevent segfault when opening glow effect (Patch from Mark Lee)
modified:
ChangeLog
awn-manager/awnManager.in.py
awn-manager/window.glade
libawn/awn-effects.c

Changed in awn:
status:	In Progress → Fix Committed

Revision history for this message

Mark Lee (malept) wrote on 2008-02-17:

#10

Technically speaking, the patch is gone from the various branches. I committed a patch from Ryan that keeps the notebook-based layout for the various sections (so you don't see a continuous vbox in glade), but keep the IconView selector widget on the left, instead of the (IMO) ugly tabs. So the intent is still there :)