implement a machine type based control of host-phys-bits
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| qemu (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
| Bionic |
Fix Released
|
Undecided
|
Unassigned | ||
| seabios (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
Bug Description
[Impact]
* Qemu supports running guests >1TB but currently the virtualization
stack above has no good way to control that (e.g. libvirt/openstack).
* Long term we'd want to see bug 1769053 (this is where all started)
implemented in libvirt and exploited by at least the major upper
stacks. But until then we want/need to make a way available that lets
users run huge guests.
* Following the example of CentOS (but not switching the default for
better compatibility) we provide a machine type which has the host-
phys-bit setting of qemu default-on. Since upper layers of the virt
stack already can control machine types that allows most use cases to
work until the long term solution can take over down the road.
[Test Case]
* You can do this on swap, but it will be so slow that you will suffer.
So better get a machine with a lot of memory - if possible >1TB
* Spawn a guest with uvtool and ensure that you are running fine
* 'virsh edit' the guest and increase the memory consumption to >1TB
* When this guest is started it works at first but later on
initialization from the guest will touch unreachable adressing bits and
crash - this will appear as hard freeze to the guest and as KVM
emulation failure in the host log of guest execution.
* With the fix you can modify the default type (which should be pc-
i440fx-bionic) to use the -hpb suffix so it would be:
pc-
Use virsh edit to do so.
* Start the guest again, now the guest will work (be aware that
initializing so much memory can take some time)
* This can be tested from PPA build at https:/
[Regression Potential]
* We were tempted to change the default on the normal type which would
have had the easiest "ease of use" but then huge regression potential.
We decided against it so we have a new type that people need to select,
this means two things:
1. no change => no regression for users of existing types
2. users using the new type might find new issues we have never seen
(tests are good thou) but that is not a regression, but a
theoretical set of issues with the new function.
[Other Info]
* The SRUability in my opinion falls under BOTH paragraphs from the SRU
page
* For Long Term Support releases we regularly want to enable new
hardware. Such changes are appropriate provided that we can ensure not
to affect upgrades on existing hardware. For example, modaliases of
newly introduced drivers must not overlap with previously shipped
drivers. This also includes updating hardware description data such as
udev's keymaps, media-player-info, mobile broadband vendors, or PCI
vendor/product list updates.
=> This is ensuring that - as machines grow - Bionuc users
can put all their ram to good use in KVM guests.
* For Long Term Support releases we sometimes want to introduce new
features. They must not change the behaviour on existing installations
(e. g. entirely new packages are usually fine). If existing software
needs to be modified to make use of the new feature, it must be
demonstrated that these changes are unintrusive, have a minimal
regression potential, and have been tested properly. To avoid
regressions on upgrade, any such feature must then also be added to any
newer supported Ubuntu release. Once a new feature/package has been
introduced, subsequent changes to it are subject to the usual
requirements of SRUs to avoid regressions.
=> This is exactly what we achieved by adding new types instead of
modifying an existing ones.
---
Hi,
on the discussions and tests around bug 1769053 it was identified to long term it would be nice to expose host-pyhs-bits and phys-bits through libvirt.
That is what bug 1769053 and the related upstream BZ will continue to track.
But there are two shortcomings on this for now:
1. it takes way too long to get that done for people wanting to use this right now
2. even if it would be implemented in libvirt, the stacks above do not yet exploit the theoretical pyhs-bits related attributes.
To get Ubuntu Users with huge systems a rather quick access to this feature including usability in higher parts of the virtualization stack we want to somewhat follow what RedHat/CentOs do at [1]
There they just switch the default to "on" in the default machine type.
This has some potential drawbacks if you want to migrate across different generations of machines, therefore we don't want it to be the default in Ubuntu.
Instead we would prefer to add a type with a -large suffix could carry that.
Note: Bikeshedding on the name is appreciated until the change is done, then it is as it is.
I have tested code that does so and it makes maintaining Ubuntu machine types not much harder while at the same time providing our users mentioned benefits for huge guests.
Eventually this will lower the pain for those running this huge guests, and by that increase the time until someone does the exposure through libvirt and all the upper stack exploitation. But that is acceptable as price to get this fast and more easy at least to Cosmic and Bionic releases without breaking too much and the mentioned instant exploitation by components higher in the virt stack.
Related branches
- Robie Basak: Approve
- Ryan Harper: Pending requested
- Canonical Server packageset reviewers: Pending requested
- Canonical Server: Pending requested
-
Diff: 176 lines (+146/-0)4 files modifieddebian/changelog (+8/-0)
debian/patches/series (+1/-0)
debian/patches/ubuntu/machine-type-hpb.patch (+88/-0)
debian/qemu-system-x86.NEWS (+49/-0)
- Canonical Server: Pending requested
- Canonical Server packageset reviewers: Pending requested
- git-ubuntu developers: Pending requested
-
Diff: 114 lines (+92/-0)3 files modifieddebian/changelog (+7/-0)
debian/patches/series (+1/-0)
debian/patches/ubuntu/machine-type-hpb.patch (+84/-0)
| Christian Ehrhardt (paelzer) wrote | #1 |
| Changed in qemu (Ubuntu): | |
| status: | New → Triaged |
| Changed in seabios (Ubuntu): | |
| status: | New → Triaged |
| Christian Ehrhardt (paelzer) wrote | #2 |
| Christian Ehrhardt (paelzer) wrote | #3 |
| Christian Ehrhardt (paelzer) wrote | #4 |
| Christian Ehrhardt (paelzer) wrote | #5 |
| Ryan Harper (raharper) wrote Re: [Bug 1776189] Re: implement a machine type based control of host-phys-bits | #6 |
| Christian Ehrhardt (paelzer) wrote | #7 |
| Changed in seabios (Ubuntu): | |
| status: | Triaged → Invalid |
| Christian Ehrhardt (paelzer) wrote | #8 |
| Launchpad Janitor (janitor) wrote | #9 |
| Changed in qemu (Ubuntu): | |
| status: | Triaged → Fix Released |
| no longer affects: | seabios (Ubuntu Bionic) |
| description: | updated |
| Changed in qemu (Ubuntu Bionic): | |
| status: | New → Triaged |
| Christian Ehrhardt (paelzer) wrote | #10 |
| Robie Basak (racb) wrote | #11 |
| Changed in qemu (Ubuntu Bionic): | |
| status: | Triaged → Fix Committed |
| tags: | added: verification-needed verification-needed-bionic |
| Robie Basak (racb) wrote Please test proposed package | #12 |
| Christian Ehrhardt (paelzer) wrote | #13 |
| Christian Ehrhardt (paelzer) wrote | #14 |
| tags: |
added: verification-done verification-done-bionic removed: verification-needed verification-needed-bionic |
| Łukasz Zemczak (sil2100) wrote Update Released | #15 |
| Launchpad Janitor (janitor) wrote | #16 |
| Changed in qemu (Ubuntu Bionic): | |
| status: | Fix Committed → Fix Released |
| Christian Ehrhardt (paelzer) wrote | #17 |
I already did some tests with these changes from ppa [1].
This also includes changes to seabios which seem safe for users with less physical bits and required for those huge guests to work properly.
[1]: https:/