netplan try: terminal does not echo keypresses after ^C during wait
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
netplan.io (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
Bionic |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Impact]
All netplan users.
[Test case]
1) Run 'sudo netplan try' to "try" a new netplan config.
2) Hit Control-C during the timer, to escape to the terminal without applying the configuration.
Validate that text typed on the terminal after hitting Control-C is correctly echoed on screen.
[Regression Potential]
Some non-standard shells may behave differently with the console and expect a specific set of modes. Care has been taken to correctly record and restore the original terminal modes and flags, as well as testing on bash, dash, zsh, in a text VT, etc; but it is possible for non-standard terminals to misunderstand the mode changes and thus incorrectly handle Control-C or other mode changes required by 'netplan try' leading to failure to echo characters, mishandling carriage returns, clears, or invalid color schemes on terminal.
--
If I do netplan try, press ^C during the wait, and try to type, my characters are not echoed to the terminal.
(This is similar to what powersj found in https:/
I think you'll need to trap KeyboardInterrupt exceptions and reset afterwards? or use a try/finally construct to make sure things are reset?
Changed in netplan.io (Ubuntu): | |
status: | New → In Progress |
importance: | Undecided → High |
assignee: | nobody → Mathieu Trudel-Lapierre (cyphermox) |
description: | updated |
Changed in netplan.io (Ubuntu): | |
assignee: | Mathieu Trudel-Lapierre (cyphermox) → nobody |
Changed in netplan.io (Ubuntu Bionic): | |
status: | Fix Released → Fix Committed |
This bug was fixed in the package netplan.io - 0.38
---------------
netplan.io (0.38) cosmic; urgency=medium
* New upstream release: on.py: fix test_eth_and_bridge autopkg test harder.
- Write udev .rules files to /run/udev/rules.d to enforce interface
renaming. (LP: #1770082)
- Don't traceback for 'netplan ip leases' when iface is not managed or
doesn't DHCP (LP: #1768823)
- Fix duplicate "/" path separator in error messages (LP: #1771440)
- Fix incorrect terminal reset in 'netplan try' on Ctrl-C. (LP: #1768798)
- Updated doc entries: mtu, fix fwmark->mark, cleanup optional.
(LP: #1768783)
- Added documentation validation at build.
- Added configuration example for multi-ip interfaces.
* tests/integrati
* debian/control:
- Add iproute2 to Depends.
- Add python3-netifaces to Depends, Build-Depends.
-- Mathieu Trudel-Lapierre <email address hidden> Mon, 04 Jun 2018 14:45:26 -0400