zvol_id throws ioctl_get_msg failed:Inappropriate ioctl for device

Bug #1763067 reported by Clint Armstrong
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zfs-linux (Ubuntu)
Invalid
Medium
Unassigned
Xenial
Fix Released
Undecided
Colin Ian King
Artful
Fix Released
Undecided
Colin Ian King

Bug Description

== SRU Justification [XENIAL][ARTFUL] ==

Symlinks in /dev/zvol are not because /lib/udev/zvol_id exits with ioctl_get_msg failed:Inappropriate ioctl for device. The core reason is that the BLKZNAME with non-HWE userspace zfsutils is 1 char different is size than the HWE kernel drivers.

== Fix ==

Change the userland zvol_id tool to use the V0.6.x ZFS_MAXNAMELEN size and if that fails with ENOTTY retry with the V0.07.0 ZFS_MAXNAMELEN size as a fallback compatibility call.

== Regression Potential ==

Very small, this changes zvol_id and keeps the original functionality as well as adding V7 ZFS functionality as a fallback. At worse, zvol_id will not work, but that's the same as the current broken state.

== Testing ==

create a volume, e.g. zfs create -V 8M ${POOL}/testvol

run /lib/udev/zvol_id on /dev/zd0 on Xenial with a 4.15 Xenial HWE kernel. Without the fix one gets an ENOTTY errno failure. With the fix zvol_id returns the zvol id and symlinks in /dev/zvol work.

---

Symlinks in /dev/zvol are not created because /lib/udev/zvol_id crashes with ioctl_get_msg failed:Inappropriate ioctl for device.

Description: Ubuntu 16.04.4 LTS
Release: 16.04

Running linux-generic-hwe-16.04-edge
4.15.0-13-generic

zfsutils-linux 0.6.5.6-0ubuntu19

The version of zvol_id in zfsutils-linux_0.7.5-1ubuntu14_amd64 works without error.

Changed in zfs-linux (Ubuntu):
importance: Undecided → Medium
assignee: nobody → Colin Ian King (colin-king)
Changed in zfs-linux (Ubuntu):
status: New → In Progress
Revision history for this message
Colin Ian King (colin-king) wrote :

The reason for this failure is that the BLKZNAME ioctl is different, zfs 0.6.x has a 255 char name where as 0.7.0 has a 256 char name.

There are test packages ready for testing in a PPA, do you mind trying these out using:

sudo add-apt-repository ppa:colin-king/zfs-lp1763067
sudo apt-get update
sudo apt-get dist-upgrade

And let me know if this fixes the issue.

Revision history for this message
Clint Armstrong (clint-f) wrote :

That works.

Revision history for this message
Colin Ian King (colin-king) wrote :

Thanks for testing. I'll try and get that in after the current round of SRU's land.

description: updated
description: updated
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Clint, or anyone else affected,

Accepted zfs-linux into artful-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/zfs-linux/0.6.5.11-1ubuntu3.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-artful to verification-done-artful. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-artful. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in zfs-linux (Ubuntu Artful):
status: New → Fix Committed
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

I approved it for artful before I actually checked if it's in bionic. Seeing that we're in Final Freeze now, I guess it's not likely for us to get this accepted in bionic, but as soon as we open-up for SRUs - please be sure to get it uploaded to bionic/devel as well.

I'll conditionally approve xenial as well, but please remember we probably won't publish it into -updates before we also have it in bionic.

Changed in zfs-linux (Ubuntu Xenial):
status: New → Fix Committed
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Clint, or anyone else affected,

Accepted zfs-linux into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/zfs-linux/0.6.5.6-0ubuntu21 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Colin Ian King (colin-king) wrote :

Just to note, this is a compat fix for older versions of the user space tools to work with newer ZFS 0.7.x, so the fix is not required in Bionic.

Revision history for this message
Colin Ian King (colin-king) wrote :

Tested on Xenial with HWE kernel 4.15.0-15 (#16~16.04.1), works fine with this fix.

description: updated
tags: added: verification-done-xenial
Revision history for this message
Colin Ian King (colin-king) wrote :

Tested on Artful with 4.15.0-20, works fine now with this fix too.

description: updated
tags: added: verification-done-artful
Revision history for this message
Colin Ian King (colin-king) wrote :

Note: this does not need fixing for Bionic as the ZFS 0.7.x userspace tools work fine with the 4.15 bionic kernel.

Changed in zfs-linux (Ubuntu Xenial):
assignee: nobody → Colin Ian King (colin-king)
Changed in zfs-linux (Ubuntu Artful):
assignee: nobody → Colin Ian King (colin-king)
Changed in zfs-linux (Ubuntu):
assignee: Colin Ian King (colin-king) → nobody
Changed in zfs-linux (Ubuntu):
status: In Progress → Invalid
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package zfs-linux - 0.6.5.11-1ubuntu3.4

---------------
zfs-linux (0.6.5.11-1ubuntu3.4) artful; urgency=medium

  * Add ZFS 0.7.0 compat fix for zvol_id (LP: #1763067)
    The BLKZNAME ioctl msg size has changed in ZFS 0.7.0 so
    add forwards compat handling for this ioctl by retrying
    with this newer msg size if the first call fails

 -- Colin Ian King <email address hidden> Thu, 12 Apr 2018 11:14:23 +0100

Changed in zfs-linux (Ubuntu Artful):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for zfs-linux has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package zfs-linux - 0.6.5.6-0ubuntu21

---------------
zfs-linux (0.6.5.6-0ubuntu21) xenial; urgency=medium

  * Add ZFS 0.7.0 compat fix for zvol_id (LP: #1763067)
    The BLKZNAME ioctl msg size has changed in ZFS 0.7.0 so
    add forwards compat handling for this ioctl by retrying
    with this newer msg size if the first call fails

 -- Colin Ian King <email address hidden> Thu, 12 Apr 2018 11:14:23 +0100

Changed in zfs-linux (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.