[enhancement] If a disk doesn't support SMART, the test shouldn't pass
Bug #1760919 reported by
Dean Henrichsmeyer
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
Medium
|
Lee Trager | ||
Bug Description
If you run the smartctl-validate script on a node with disks that don't support SMART, the test will pass even though the output clearly says
INFO: Veriying SMART support for the following drive: /dev/sdb
INFO: Running command: sudo -n smartctl --all /dev/sdb
INFO: Unable to run test. The following drive does not support SMART: /dev/sdb
I know it's dangerous to try and interpret results but we should definitely sort that for tests that we ship with MAAS. It gives a false sense of security that things are fine when in fact they may not be. In my case I had a failed disk that "passed" the test so I assumed it was good when in fact it didn't even run.
Related branches
~ltrager/maas:script_result_skip
- Blake Rouse (community): Approve
- MAAS Lander: Approve
-
Diff: 295 lines (+74/-17)10 files modifiedsrc/maasserver/static/js/angular/directives/script_status.js (+5/-1)
src/maasserver/static/js/angular/directives/tests/test_script_status.js (+6/-0)
src/maasserver/static/partials/script-results-list.html (+4/-4)
src/metadataserver/builtin_scripts/smartctl.py (+7/-0)
src/metadataserver/builtin_scripts/tests/test_smartctl.py (+10/-1)
src/metadataserver/enum.py (+3/-1)
src/metadataserver/migrations/builtin/0018_script_result_skipped.py (+23/-0)
src/metadataserver/models/scriptresult.py (+7/-4)
src/metadataserver/models/scriptset.py (+2/-0)
src/metadataserver/models/tests/test_scriptresult.py (+7/-6)
| summary: |
- If a disk doesn't support SMART, the test shouldn't pass + [enhancement] If a disk doesn't support SMART, the test shouldn't pass |
| Changed in maas: | |
| milestone: | none → 2.4.x |
| importance: | Undecided → Medium |
| status: | New → Triaged |
| Changed in maas: | |
| assignee: | nobody → Lee Trager (ltrager) |
| Changed in maas: | |
| milestone: | 2.4.x → 2.4.0beta2 |
| Changed in maas: | |
| status: | Triaged → In Progress |
Revision history for this message
| Lee Trager (ltrager) wrote | #1 |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
The related branch adds a new skipped status for ScriptResults. All SMART tests now set their status to skipped if SMART is unsupported. This will not effect the status of the node but will be visible in the UI in the hardware tests tab.