MAAS

vdb partitioned with zfsroot, but not mounted: deploy failed

Bug #1760880 reported by Andreas Hasenack on 2018-04-03

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	MAAS	Invalid	Medium	Unassigned	MAAS 2.4.x
	curtin	Fix Released	High	Unassigned

Bug Description

curtin 18.1-1-g45564eef-0ubuntu1
maas 2.4.0~beta1-6799-g391e5f16d-0ubuntu1

I had vdb partioned with zfsroot, but not mounted (i.e., it's not under "file systems").

Tried a deploy with vda-part1 formatted with zfsroot and mounted at /, but that failed:
"""
curtin: Installation started. (18.1-1-g45564eef-0ubuntu1)

third party drivers not installed or necessary.

zfsroot found in two entries in storage config: [{'fstype': 'zfsroot', 'id': 'vda-part1_format', 'label': '', 'type': 'format', 'uuid': 'd85b2613-b1dc-482a-bc78-385f5ae4224e', 'volume': 'vda-part1'}, {'fstype': 'zfsroot', 'id': 'vdb_format', 'label': '', 'type': 'format', 'uuid': '9c66e308-86ed-4a73-a72d-26de2c55f2fe', 'volume': 'vdb'}]

curtin: Installation failed with exception: Unexpected error while running command.

Command: ['curtin', 'block-meta', 'custom']

Exit code: 3

Reason: -

Stdout: zfsroot found in two entries in storage config: [{'fstype': 'zfsroot', 'id': 'vda-part1_format', 'label': '', 'type': 'format', 'uuid': 'd85b2613-b1dc-482a-bc78-385f5ae4224e', 'volume': 'vda-part1'}, {'fstype': 'zfsroot', 'id': 'vdb_format', 'label': '', 'type': 'format', 'uuid': '9c66e308-86ed-4a73-a72d-26de2c55f2fe', 'volume': 'vdb'}]

Stderr: ''
"""

Looks like it still "saw" zfs on vdb and got confused.

See original description

Related branches

~raharper/curtin:fix/zfs-allow-no-disk-by-id

Merged into curtin:master at revision 05de78107f1674b4e2e29474d7f01133fbdaa8fd

Ryan Harper (community): Needs Fixing on 2018-04-19

Scott Moser (community): Approve on 2018-04-18

Server Team CI bot: Approve (continuous-integration) on 2018-04-17

Andreas Hasenack (ahasenack) on 2018-04-03

description:

updated

Revision history for this message

Andres Rodriguez (andreserl) wrote on 2018-04-03:

Hey Andreas,

Can you please attach the curtin config file sent to curtin?

maas <user> machines get-curtin-config <system_id>

Changed in maas:
status:	New → Incomplete

Revision history for this message

Andreas Hasenack (ahasenack) wrote on 2018-04-03:

get-curtin-config.txt Edit (4.7 KiB, text/plain)

Attached

Revision history for this message

Andreas Hasenack (ahasenack) wrote on 2018-04-03:

Screenshot from 2018-04-03 11-49-43.png Edit (41.2 KiB, image/png)

This is the state the storage screen was when I clicked "deploy".

Changed in maas:
status:	Incomplete → New

Revision history for this message

Andres Rodriguez (andreserl) wrote on 2018-04-03:

I think this could also be related to [1]. That said, it could be ok to have a partitioning be formatted but not mounted, but yet, this fails on zfsroot, which leads me to believe this may be an issue with curtin.

Since the agreed path with the server team was to use zfsroot as a filesystem, I'm opening a task in curtin.

[1]: https://bugs.launchpad.net/curtin/+bug/1760879

Changed in maas:
milestone:	none → 2.4.0beta2
status:	New → Incomplete

Revision history for this message

Ryan Harper (raharper) wrote on 2018-04-03:

zfsroot only accepts a single partition/device, that is we look at where '/' is mounted and use the underlying device (partition or disk) to construct the zpool/zfs commands as needed.

If you specify more than one zfsroot in a config, curtin will complain at deploy-time, much like MAAS doesn't let you mount '/' multiple times, we can have exactly *one* zfsroot.

Revision history for this message

Ryan Harper (raharper) wrote on 2018-04-03:

I think we can update the format command documentation around zfsroot to indicate that there can be only one zfsroot, like there can be only one '/' mount.

Changed in curtin:
importance:	Undecided → High
status:	New → Triaged

Ryan Harper (raharper) on 2018-04-04

Changed in curtin:
status:	Triaged → In Progress

Andres Rodriguez (andreserl) on 2018-04-04

Changed in maas:
status:	Incomplete → Triaged
importance:	Undecided → Medium

Andres Rodriguez (andreserl) on 2018-04-04

Changed in maas:
milestone:	2.4.0beta2 → 2.4.0beta3

Revision history for this message

Ryan Harper (raharper) wrote on 2018-04-19:

An upstream commit landed for this bug.

To view that commit see the following URL:
https://git.launchpad.net/curtin/commit/?id=05de7810

Changed in curtin:
status:	In Progress → Fix Committed

Andres Rodriguez (andreserl) on 2018-05-03

Changed in maas:
milestone:	2.4.0beta3 → 2.4.0beta4

Andres Rodriguez (andreserl) on 2018-05-17

Changed in maas:
milestone:	2.4.0beta4 → 2.4.x

Revision history for this message

Ryan Harper (raharper) wrote on 2018-06-01: Fixed in curtin version 18.1-17-gae48e86f-0ubuntu1.

This bug is believed to be fixed in curtin in version18.1-17-gae48e86f-0ubuntu1. If this is still a problem for you, please make a comment and set the state back to New

Thank you.