BGP MD5 support regression

Looks like this didn't quite work out; 0.99.9-2ubuntu1 won't build from source on Gutsy, using the CVS diff mis-patches bgpd.h struct bgp_master, giving build error:

gcc -DHAVE_CONFIG_H -DSYSCONFDIR=\"/etc/quagga/\" -I. -I.. -I.. -I.. -I../lib -Os -fno-omit-frame-pointer -g -std=gnu99 -Wall -Wsign-compare -Wpointer-arith -
Wbad-function-cast -Wwrite-strings -Wmissing-prototypes -Wmissing-declarations -Wchar-subscripts -Wcast-qual -MT bgpd.o -MD -MP -MF .deps/bgpd.Tpo -c -o bgpd.o bg
pd.c
bgpd.c: In function ‘peer_delete’:
bgpd.c:1216: error: ‘struct bgp_master’ has no member named ‘sock’

and many more simliar. Sargun from freenode#quagga informs me the latest patch here:

http://www.wittsend.com/mhw/md5sig/quagga_md5_bsd_linux_v9.diff

This should be fixed in intrepid once quagga is synced from debian - bug 228489.

Opening a task for hardy - may be worth an SRU.

Should be fixed in Intrepid.

I have updated the patch from the mailing list. Without this patch quagga will not work correctly.

TEST CASE:

1. Install quagga.
2. Start quagga to see if the listen socket has the md5 option set.

NOTE: This should be done who has experience with quagga to make sure that it is working properly. I have added the updated patch.

Thanks
chuck

Please ignore the last attachment and look at this one instead.

Thanks
chuck

Accepted into -proposed, please test and give feedback here

Ugh, that's a mega-patch. Please make sure to get it tested properly, also from people who use it in production.

I'm ready, willing and able to test this with 2 live BGP full tables +
MD5. I have limited time so if you can point me at a .deb or specific
instructions how to patch the src pkg, i'll give it a go straight away.

I have rebuilt the quagga src pkg already, I just need to know what to
change to use this patch.

Cheers,

Jeremy

On Sat, 2008-05-17 at 15:16 +0000, Martin Pitt wrote:
> Ugh, that's a mega-patch. Please make sure to get it tested properly,
> also from people who use it in production.
>
--
Jeremy Jackson
Coplanar Networks
(519)489-4903
http://www.coplanar.net
<email address hidden>

Jeremy, that would be great! To test the package, just enable hardy-proposed in /etc/apt/sources.list, apt-get update, and apt-get install quagga (or just dist-upgrade, to test all the other pending updates as well). If you are testing this with GNOME, you can also activate it in System -> Administration -> Software Sources -> Updates.

Jeremy, what are your experiences with the new version so far? Thanks!

I've finally found time to test it, looks good so far. I'll be testing on 5 machines in lab environment for a bit longer, then updating the live machines.

Thanks for testing! Copied to hardy-updates.