[2.4, devenv] make doc builds all JS
Bug #1756292 reported by
Andres Rodriguez
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
High
|
Mike Pontillo | ||
Bug Description
make docs builds all the JS dependencies and such.
Related branches
~mpontillo/maas:fix-make-doc--bug-1756292
- Lee Trager (community): Approve
- MAAS Lander: Approve
-
Diff: 46 lines (+8/-6)1 file modifiedMakefile (+8/-6)
| Changed in maas: | |
| milestone: | none → 2.4.0beta1 |
| importance: | Undecided → High |
| status: | New → Triaged |
| assignee: | nobody → Mike Pontillo (mpontillo) |
| Changed in maas: | |
| milestone: | 2.4.0beta1 → 2.4.0beta2 |
| Changed in maas: | |
| milestone: | 2.4.0beta2 → 2.4.0beta3 |
Revision history for this message
| Mike Pontillo (mpontillo) wrote | #1 |
| Changed in maas: | |
| milestone: | 2.4.0beta3 → 2.4.0beta4 |
| Changed in maas: | |
| status: | Triaged → Fix Committed |
| Changed in maas: | |
| milestone: | 2.4.0beta4 → 2.4.0rc1 |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I've been spending some time trying to hack the Makefile in order to fix this.
This seems to happen because `make doc` depends on `maas-region`, which requires the entire region server to be built in order to generate the API documentation.
The reason webpack is forced to be invoked is due to the dependency on the `bin/webpack` symlink. When the symlink is created, it's de facto state is to be *newer* than whatever its output files are. Even though bin/webpack is listed as a .SECONDARY target in the Makefile, this seems to be causing the JavaScript output files to be considered out-of-date.
I can stop the portion of this behavior that re-runs webpack by using the direct path to the (downloaded from yarn) webpack binary instead of the symlink. It's not clear if this will have any side-effects, but it seems safe.