Thunderbolt updates on Dell systems fail to apply if nothing connected

Bug #1741509 reported by Mario Limonciello
108
This bug affects 22 people
Affects Status Importance Assigned to Milestone
Fwupd
Fix Released
Unknown
fwupd (Ubuntu)
Fix Released
Undecided
Unassigned
Artful
Fix Released
Undecided
Unassigned
Bionic
Fix Released
Undecided
Unassigned

Bug Description

[Impact]
Thunderbolt updates posted to LVFS fail to install

[Test Case]
On an XPS 9360 (Only system currently published with TBT FW update).
0) Restart fwupd.service or restart machine.
1) fwupdmgr refresh
2) fwupdmgr update
3) Observe no errors

If TBT update already applied, please manually download from LVFS and follow these steps
1) fwupdmgr install <blah.cab> --allow-reinstall

[Regression potential]
Low, only affects Dell machines

[Other info]
fwupd 0.9.7 has support for doing thunderbolt firwmare updates.
Thunderbolt controllers will go to sleep if not in use (No TBT device connected).
fwupd 0.9.7 has a special way to wake up dell TBT controllers, that's where this problem is.
It doesn't happen if TBT device connected when update is run
fwupd 1.0.2 (in bionic) will not be affected. it wakes TBT controller using a different interface over WMI

Revision history for this message
Mario Limonciello (superm1) wrote :

Here is the fix for the issue: https://github.com/hughsie/fwupd/commit/11290ab0bafba273cfb2764875152ba9a4093035

it will be merged into 0.9.x branch after confirmation that it fixes the issue.

Changed in fwupd (Ubuntu Bionic):
status: New → Invalid
Revision history for this message
Mario Limonciello (superm1) wrote :

Here is a PPA with the fix for testing until the SRU process is started:
https://launchpad.net/~superm1/+archive/ubuntu/lp1741509

Revision history for this message
Jeffrey Bouter (jbouter) wrote :

I've tried the fix supplied, but that keeps resulting in the same error. This is with a USB-C dongle connected, and a mouse connected to the dongle.

jeffrey@w0lf ~ $ sudo fwupdmgr install eac3961ba9bd466f6e34d9276c27d524395d7c3c-NN1TN_NVM21.00.cab
Decompressing… [- ]
could not find thunderbolt device at /sys/devices/pci0000:00/0000:00:1c.0/0000:01:00.0/0000:02:00.0/0000:03:00.0/domain0/0-0

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in fwupd (Ubuntu Artful):
status: New → Confirmed
Revision history for this message
Mario Limonciello (superm1) wrote : Re: [Bug 1741509] Re: Thunderbolt updates on Dell systems fail to apply if nothing connected

Can you confirm you restarted fwupd after upgrading?

Fwupd verbose log would be useful too.

On Fri, Jan 5, 2018, 14:10 Launchpad Bug Tracker <email address hidden>
wrote:

> Status changed to 'Confirmed' because the bug affects multiple users.
>
> ** Changed in: fwupd (Ubuntu Artful)
> Status: New => Confirmed
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1741509
>
> Title:
> Thunderbolt updates on Dell systems fail to apply if nothing connected
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/fwupd/+bug/1741509/+subscriptions
>

Revision history for this message
Mario Limonciello (superm1) wrote :

It looks like the build isn't finished so unless you manually built you
don't have it installed

On Fri, Jan 5, 2018, 14:11 Mario Limonciello <email address hidden> wrote:

> Can you confirm you restarted fwupd after upgrading?
>
> Fwupd verbose log would be useful too.
>
> On Fri, Jan 5, 2018, 14:10 Launchpad Bug Tracker <
> <email address hidden>> wrote:
>
>> Status changed to 'Confirmed' because the bug affects multiple users.
>>
>> ** Changed in: fwupd (Ubuntu Artful)
>> Status: New => Confirmed
>>
>> --
>> You received this bug notification because you are subscribed to the bug
>> report.
>> https://bugs.launchpad.net/bugs/1741509
>>
>> Title:
>> Thunderbolt updates on Dell systems fail to apply if nothing connected
>>
>> To manage notifications about this bug go to:
>>
>> https://bugs.launchpad.net/ubuntu/+source/fwupd/+bug/1741509/+subscriptions
>>
>

Revision history for this message
Jeffrey Bouter (jbouter) wrote :

I indeed do not have the update installed. It was last updated 2 hours ago, and thought that was the fix. I'll wait for the update in the PPA to complete, and then re-run the process.

Revision history for this message
Mario Limonciello (superm1) wrote :

I've got a successful confirmation from someone on the Github issue. As such I've uploaded an SRU to xenial-proposed. It will be waiting for an archive admin to ack it.
Once it's landed in the xenial proposed archive it will need someone else to verify it too.

Changed in fwupd (Ubuntu Artful):
status: Confirmed → In Progress
Changed in fwupd:
status: Unknown → New
Revision history for this message
Mario Limonciello (superm1) wrote :

Since I've gotten successful confirmation I've deleted the PPA. So this will need archive admin to accept the upload into proposed.

When archive admin who will look at this, FYI please use my second upload, I accidentally dput wrong one the first time that didn't include patch (it will be obvious during review).

Changed in fwupd (Ubuntu Bionic):
status: Invalid → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Mario, or anyone else affected,

Accepted fwupd into artful-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwupd/0.9.7-2ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-artful to verification-done-artful. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-artful. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in fwupd (Ubuntu Bionic):
status: Fix Released → Fix Committed
Changed in fwupd (Ubuntu Artful):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-artful
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Switched bionic to Fix Committed as it's still in bionic-proposed (not migrating due to non-x86 builders being disabled). Approved the artful upload.

description: updated
Revision history for this message
Dariusz Gadomski (dgadomski) wrote :

I've just finished testing version 0.9.7-2ubuntu1.
With that version update finishes cleanly.

Thanks!

tags: added: verification-done verification-done-artful
removed: verification-needed verification-needed-artful
Revision history for this message
Plugaru Tudor (plugarutudor) wrote :

I can confirm, the update finishes cleanly.

Revision history for this message
Pavlo Shchelokovskyy (pshchelo) wrote :

+1, works for me (Ubuntu 17.10, Dell XPS 13 9360). Thanks for fixing!

Revision history for this message
Jeffrey Bouter (jbouter) wrote :

Worked fine for me too! (Ubuntu 17.10, Dell XPS 13 9360). Didn't even need to have a device connected to the port. Great work, thanks for fixing!

Changed in fwupd:
status: New → Fix Released
Revision history for this message
Paolo Sonego (paolo-sonego) wrote :

It works for me as well (Ubuntu 17.10, Dell XPS 13 9360).

Revision history for this message
Joss Smith (efi0ng) wrote :

It works for me (Ubuntu 17.10, Dell XPS 13 9360).

Applied fwupd update using aptitude. Rebooted. Nothing plugged into thunderbolt port. Applied Thunderbolt update via Software Center.

Revision history for this message
Loenders (loenders) wrote :

It works for me aswel (Ubuntu 17.10, Dell XPS 13 9360 - BIOS 2.5.0) .

Applied fwupd update using apt.
Nothing plugged into thunderbolt port.
Applied Thunderbolt update via Software Center.

pluggedin the DA-200, it is detected, but the VGA output does not detect the monitor anymore .
Ethernet, USB works, did not try the HDMI yet, will try it later today..

Might not be related to this ticket .

tried to load the PRE BIOS, but it was not allowed

Revision history for this message
Frederik Feichtmeier (frederik-feichtmeier) wrote :

This works for me aswell: Ubuntu 17.10 Dell XPS 9360

Added the proposing channel in software updates and updated my system via gnome/ubuntu software

This time the error message went away and the update of the thunderbolt port ran successfull without any thunderbolt devide plugged into the port! Thank you very much

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

The fwupd bionic version is still blocked on bionic-proposed due to a huge autopkgtest backlog. Seeing that the artful version got sufficient testing (and all its ADT tests have passed), I am promoting it to -updates conditionally before the bionic version. In the meantime, please make sure that the bionic part of the package also migrates successfully.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package fwupd - 0.9.7-2ubuntu1

---------------
fwupd (0.9.7-2ubuntu1) artful; urgency=medium

  * Add a delay when running TBT controller updates (LP: #1741509)

 -- Mario Limonciello <email address hidden> Fri, 05 Jan 2018 11:14:31 -0600

Changed in fwupd (Ubuntu Artful):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for fwupd has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Changed in fwupd (Ubuntu Bionic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.