import tag matching upload tag is nevertheless created in a separate commit
Bug #1734883 reported by
Robie Basak
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| git-ubuntu |
Fix Released
|
Undecided
|
Robie Basak | ||
Bug Description
Needs confirmation as to whether this is the current behaviour.
But in sssd commit 42a95c2755c7184
Related branches
~racb/git-ubuntu:fix-unapplied-commits-and-tags
- Bryce Harrington: Approve
- Server Team CI bot: Approve (continuous-integration)
-
Diff: 764 lines (+467/-182)6 files modifiedgitubuntu/git_repository.py (+44/-0)
gitubuntu/git_repository_test.py (+62/-0)
gitubuntu/importer.py (+218/-171)
gitubuntu/importer_tag_test.py (+0/-10)
gitubuntu/importer_test.py (+140/-0)
setup.py (+3/-1)
~nacc/git-ubuntu:lp1731554-importer-rework-v2
- Server Team CI bot: Needs Fixing (continuous-integration)
- git-ubuntu developers: Pending requested
-
Diff: 4178 lines (+2634/-771)9 files modifieddoc/SPECIFICATION.importer (+72/-0)
gitubuntu/dsc.py (+38/-0)
gitubuntu/git_repository.py (+23/-11)
gitubuntu/importer.py (+519/-586)
gitubuntu/importer_test.py (+1803/-43)
gitubuntu/importerutils.py (+50/-0)
gitubuntu/importlocal.py (+0/-2)
gitubuntu/importppa.py (+5/-16)
gitubuntu/source_information.py (+124/-113)
~nacc/git-ubuntu:importer-abstract-out-upload-tags
- Server Team CI bot: Needs Fixing (continuous-integration)
- Robie Basak: Pending requested
-
Diff: 414 lines (+304/-49)2 files modifiedgitubuntu/importer.py (+183/-49)
gitubuntu/test_importer.py (+121/-0)
~nacc/git-ubuntu:importer-fix-tests
- Server Team CI bot: Needs Fixing (continuous-integration)
- Andreas Hasenack: Pending requested
- Robie Basak: Pending requested
-
Diff: 1124 lines (+307/-339) (has conflicts)3 files modifiedgitubuntu/git_repository.py (+0/-6)
gitubuntu/importer.py (+181/-292)
gitubuntu/test_importer.py (+126/-41)
~nacc/git-ubuntu:import-tests
- Server Team CI bot: Needs Fixing (continuous-integration)
- Robie Basak: Pending requested
-
Diff: 3507 lines (+2371/-620)6 files modifiedgitubuntu/git_repository.py (+81/-20)
gitubuntu/importer.py (+609/-397)
gitubuntu/importlocal.py (+24/-185)
gitubuntu/repo_builder.py (+37/-13)
gitubuntu/repo_comparator.py (+5/-4)
gitubuntu/test_importer.py (+1615/-1)
~nacc/git-ubuntu:further-orphan-tag-fix-lp1753800
- Robie Basak: Pending requested
- git-ubuntu developers: Pending requested
-
Diff: 295 lines (+148/-28)6 files modifiedgitubuntu/git_repository.py (+24/-19)
gitubuntu/importer.py (+29/-5)
gitubuntu/importlocal.py (+0/-1)
gitubuntu/importppa.py (+0/-1)
gitubuntu/source_builder.py (+10/-1)
gitubuntu/test_importer.py (+85/-1)
| tags: | added: import |
Revision history for this message
| Nish Aravamudan (nacc) wrote | #1 |
| tags: | added: spec |
| Changed in usd-importer: | |
| status: | New → In Progress |
| assignee: | nobody → Robie Basak (racb) |
| Changed in usd-importer: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Robie Basak (racb) wrote Fix released in git-ubuntu | #2 |
| Changed in usd-importer: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I *think* git_repository.
If parents is a singleton list, and the tree of that list matches tree_hash, perhaps we don't commit it at all? And instead return the parent itself as the resulting committed hash?