Importer helper command behaviour can vary

Bug #1734137 reported by Robie Basak
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
git-ubuntu
Fix Released
High
Unassigned

Bug Description

GitUbuntuRepository:quilt_env currently doesn't make any arrangement to use "--quiltrc -" and nor do any of its callers. This means that the imported result (especially applied branches) may vary depending on what the user has in /etc/quiltrc or ~/.quiltrc.

We should ensure that all QUILT_* environment variables are exactly as we want them and "--quiltrc -" is used.

This also affects gbp via repository, user, and global config options. The former is especially annoying because, e.g., src:at sets a gbp.conf that enables pbuilder which then causes our gbp-buildpackage (which, admittedly, we will switch to export-orig) command to error out as it tries to use cowbuilder... In my testing so far, setting GBP_CONF_FILES=/dev/null is a suitable workaround. I have requested (via e-mail) upstream consider allowing an empty string value, as that's a slightly more clear semantic.

Related branches

Scott Moser (smoser)
Changed in usd-importer:
status: New → Confirmed
importance: Undecided → High
Robie Basak (racb)
tags: added: import
Revision history for this message
Nish Aravamudan (nacc) wrote :

@Robie, can you clarify if this is Fix Released or not? I see some commmit was landed for this bug, but it's still open and that commit message implies there is more to do?

Revision history for this message
Robie Basak (racb) wrote :

There's still more to fix I think. "--quiltrc -" needs to be used in all calls which isn't done yet. We should probably refactor all quilt calls to go through a single helper wrapper that does the right thing.

Revision history for this message
Nish Aravamudan (nacc) wrote : Re: [Bug 1734137] Re: Importer quilt behaviour can vary

On Tue, Jan 9, 2018 at 1:33 AM, Robie Basak <email address hidden> wrote:
> There's still more to fix I think. "--quiltrc -" needs to be used in all
> calls which isn't done yet. We should probably refactor all quilt calls
> to go through a single helper wrapper that does the right thing.

Ok, thanks for clarifying.

Nish Aravamudan (nacc)
summary: - Importer quilt behaviour can vary
+ Importer helper command behaviour can vary
description: updated
Changed in usd-importer:
assignee: nobody → Nish Aravamudan (nacc)
milestone: none → lp-beta
Nish Aravamudan (nacc)
Changed in usd-importer:
status: Confirmed → In Progress
Nish Aravamudan (nacc)
Changed in usd-importer:
status: In Progress → Fix Released
assignee: Nish Aravamudan (nacc) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.