add support for thunderx2 cores

Bug #1727540 reported by dann frazier
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gcc-5 (Ubuntu)
Fix Released
Undecided
dann frazier
Xenial
Fix Released
Undecided
dann frazier
Zesty
Won't Fix
Undecided
Unassigned
Artful
Fix Released
Undecided
dann frazier
Bionic
Fix Released
Undecided
dann frazier

Bug Description

[Impact]
gcc-5 doesn't know about thunderx2 cores, so optimization flags for this target will fail. While it is possible to generate the same code by referencing the previous name of the core (vulcan), that is non-obvious to the end user.

[Test Case]
gcc-5 hello.c -o hello -mcpu=thunderx2t99
hello.c:1:0: error: unknown value ‘thunderx2t99’ for -mcpu
 #include <stdio.h>
 ^

Also test that -mcpu=vulcan still works, to check for regressions.

[Regression Risk]
The patchset includes a rename of the "vulcan" core to "thunderx2t99". It retains backwards compatibility with the "vulcan" name to avoid regressing users that may already be using that name.

dann frazier (dannf)
description: updated
Revision history for this message
dann frazier (dannf) wrote :
Changed in gcc-5 (Ubuntu Bionic):
status: New → In Progress
Changed in gcc-5 (Ubuntu Artful):
status: New → In Progress
Changed in gcc-5 (Ubuntu Bionic):
assignee: nobody → dann frazier (dannf)
Changed in gcc-5 (Ubuntu Artful):
assignee: nobody → dann frazier (dannf)
Revision history for this message
dann frazier (dannf) wrote :
tags: added: patch
Revision history for this message
dann frazier (dannf) wrote :
dann frazier (dannf)
Changed in gcc-5 (Ubuntu Xenial):
status: New → In Progress
assignee: nobody → dann frazier (dannf)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gcc-5 - 5.5.0-3ubuntu1

---------------
gcc-5 (5.5.0-3ubuntu1) bionic; urgency=medium

  * Merge with Debian; remaining changes:
    - Build from upstream sources.

gcc-5 (5.5.0-3) unstable; urgency=medium

  * Add thunderx2 support for Linaro builds (Dann Frazier). LP: #1727540.

 -- Matthias Klose <email address hidden> Wed, 01 Nov 2017 13:58:41 +0100

Changed in gcc-5 (Ubuntu Bionic):
status: In Progress → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote :

I think the test case should also include "-mcpu=vulcan" with the new version to ensure that the backwards compatibility does in fact still work.

Changed in gcc-5 (Ubuntu Zesty):
status: New → Won't Fix
Changed in gcc-5 (Ubuntu Artful):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-artful
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello dann, or anyone else affected,

Accepted gcc-5 into artful-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gcc-5/5.5.0-1ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-artful to verification-done-artful. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-artful. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in gcc-5 (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed-xenial
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello dann, or anyone else affected,

Accepted gcc-5 into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gcc-5/5.4.0-6ubuntu1~16.04.6 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

dann frazier (dannf)
description: updated
Revision history for this message
dann frazier (dannf) wrote :

artful verification:

ubuntu@alekhin:~$ cat > hello.c
#include <stdio.h>

int main() {
  printf("Hello world\n");
}
ubuntu@alekhin:~$ gcc-5 hello.c -o hello -mcpu=thunderx2t99
ubuntu@alekhin:~$ ./hello
Hello world
ubuntu@alekhin:~$ gcc-5 hello.c -o hello -mcpu=vulcan
ubuntu@alekhin:~$ ./hello
Hello world
ubuntu@alekhin:~$ gcc-5 -v
Using built-in specs.
COLLECT_GCC=gcc-5
COLLECT_LTO_WRAPPER=/usr/lib/gcc/aarch64-linux-gnu/5/lto-wrapper
Target: aarch64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu/Linaro 5.5.0-1ubuntu2' --with-bugurl=file:///usr/share/doc/gcc-5/README.Bugs --enable-languages=c,ada,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-5 --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-libquadmath --enable-plugin --enable-default-pie --with-system-zlib --disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-5-arm64/jre --enable-java-home --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-5-arm64 --with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-5-arm64 --with-arch-directory=aarch64 --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --enable-multiarch --enable-fix-cortex-a53-843419 --disable-werror --enable-checking=release --build=aarch64-linux-gnu --host=aarch64-linux-gnu --target=aarch64-linux-gnu
Thread model: posix
gcc version 5.4.1 20171010 (Ubuntu/Linaro 5.5.0-1ubuntu2)

tags: added: verification-done-artful
removed: verification-needed-artful
Revision history for this message
dann frazier (dannf) wrote :

xenial verification:

ubuntu@lundmark:~$ gcc-5 hello.c -o hello -mcpu=thunderx2t99
ubuntu@lundmark:~$ ./hello
Hi.
ubuntu@lundmark:~$ gcc-5 hello.c -o hello -mcpu=vulcan
ubuntu@lundmark:~$ ./hello
Hi.
ubuntu@lundmark:~$ gcc-5 -v
Using built-in specs.
COLLECT_GCC=gcc-5
COLLECT_LTO_WRAPPER=/usr/lib/gcc/aarch64-linux-gnu/5/lto-wrapper
Target: aarch64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.6' --with-bugurl=file:///usr/share/doc/gcc-5/README.Bugs --enable-languages=c,ada,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-5 --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-libquadmath --enable-plugin --with-system-zlib --disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-5-arm64/jre --enable-java-home --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-5-arm64 --with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-5-arm64 --with-arch-directory=aarch64 --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --enable-multiarch --enable-fix-cortex-a53-843419 --disable-werror --enable-checking=release --build=aarch64-linux-gnu --host=aarch64-linux-gnu --target=aarch64-linux-gnu
Thread model: posix
gcc version 5.4.0 20160609 (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.

tags: added: verification-done verification-done-xenial
removed: verification-needed verification-needed-xenial
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gcc-5 - 5.5.0-1ubuntu2

---------------
gcc-5 (5.5.0-1ubuntu2) artful; urgency=medium

  * Add thunderx2 support. LP: #1727540.

 -- dann frazier <email address hidden> Fri, 12 Jan 2018 17:00:22 -0700

Changed in gcc-5 (Ubuntu Artful):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for gcc-5 has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gcc-5 - 5.4.0-6ubuntu1~16.04.6

---------------
gcc-5 (5.4.0-6ubuntu1~16.04.6) xenial; urgency=medium

  * Add thunderx2 support. LP: #1727540.

 -- dann frazier <email address hidden> Tue, 16 Jan 2018 10:27:06 -0700

Changed in gcc-5 (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.