Firmware update seemingly not working

Thank you for your bug report. So the issue there is that it fails to restart the machine when acking the dialog that is supposed to do that, right?
What desktop environment are you using? Could you add your syslog after getting the problem?

There seems to be two issues:

1. When clicking "update" on the firmware update, you do not get a notification to restart the machine. I do get a notification if I click the "Update All" button in the top-right corner.

2. After clicking "Update" but before the restart, the update re-appears in the list of updates. This gives me the impression that the update failed. I see two possible solutions: a) don't show the update after the update process has started. b) change the "update" button to a "restart to update" button that prompts to restart the machine on click.

Syslog output: https://paste.ubuntu.com/25793427/

I'm using default Ubuntu 17.10; DE is Gnome. This happens both in Xorg and in wayland session.

the log has that warning
"Calling org.gnome.SessionManager.Reboot failed: GDBus.Error:org.gtk.GDBus.UnmappedGError.Quark._g_2dio_2derror_2dquark.Code19: Operation was cancelled"

I've filed that issue upstream.

I suspect it to actually be gnome-session is the problem, but let's see what they say.

That upstream issue has migrated to https://gitlab.gnome.org/GNOME/gnome-software/issues/253. It seems Launchpad can't track it anymore.

This is the actual upstream issue. The reboot failed log seems to be a red herring.

https://gitlab.gnome.org/GNOME/gnome-software/issues/341

This issue has been fixed upstream. It requires fixes in both gnome-software and fwupd.

gnome-software fix (on the Gnome Software 3-28 branch):
https://gitlab.gnome.org/GNOME/gnome-software/commit/057eea7cc03d647544b5819ff37951f7bfffb77e

fwupd fix (on the 1_0_X branch):
https://github.com/hughsie/fwupd/commit/80f6e995f68ad7559c4a386a58e9ee43750bf6aa

fwupd
------
This has been fixed upstream in the 1.1.3 release, so marking the development release task complete.
The 1.0.9 SRU bug for bionic is here: https://bugs.launchpad.net/ubuntu/+source/fwupd/+bug/1791999

gnome-software
------------
There is an SRU in progress for 3.28.1-0ubuntu4.18.04.4 that I don't want to de-rail by uploading a new patch for this bug. Once that one is in https://gitlab.gnome.org/GNOME/gnome-software/commit/057eea7cc03d647544b5819ff37951f7bfffb77e should be added to this SRU bug.

Change queued up for gnome-software 3.28.1-0ubuntu4.18.04.5 SRU

Hello Merlijn, or anyone else affected,

Accepted fwupd into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwupd/1.0.9-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Merlijn, or anyone else affected,

Accepted fwupd into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwupd/1.0.9-0ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

I've tested the fwupd half of this SRU (couldn't test the gnome-software as it's not yet in place). The fwupd half works properly.

Hello Merlijn, or anyone else affected,

Accepted gnome-software into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-software/3.28.1-0ubuntu4.18.04.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

On Bionic, I'm running:

$ apt-cache policy fwupd
fwupd:
  Installed: 1.0.9-0ubuntu2
  Candidate: 1.0.9-0ubuntu2
  Version table:
 *** 1.0.9-0ubuntu2 500
        500 http://archive.ubuntu.com/ubuntu bionic-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     1.0.6-2 500
        500 http://archive.ubuntu.com/ubuntu bionic/main amd64 Packages

$ apt-cache policy gnome-software
gnome-software:
  Installed: 3.28.1-0ubuntu4.18.04.5
  Candidate: 3.28.1-0ubuntu4.18.04.5
  Version table:
 *** 3.28.1-0ubuntu4.18.04.5 500
        500 http://archive.ubuntu.com/ubuntu bionic-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     3.28.1-0ubuntu4.18.04.4 500
        500 http://archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages
     3.28.1-0ubuntu4 500
        500 http://archive.ubuntu.com/ubuntu bionic/main amd64 Packages

I have a firmware update pending (handy!).

Go to the firmware update tab, click Update on the fwupdate.

After a second or two it tells me that it's done and the update disappears from the list.
Clicking "refresh", the update stays hidden.

Quitting and reloading g-s, the update stays hidden, as expected.

All passed.

Will - can you confirm this is still fixed in 3.28.1-0ubuntu4.18.04.7 ?

Hello Merlijn, or anyone else affected,

Accepted gnome-software into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-software/3.28.1-0ubuntu4.18.04.8 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

@ Robert - until there is another fw update I don't think I can. Do you know of a way to mock/fake it?

I faked it previously by manually downgrading my bios (downloading the previous version from the bios vendor, putting it on a FAT32 USB stick and using the upgrade option in the bios setup), after which the software center shows the update again.

There should also be a way to downgrade using the fwupdate commandline tool.

I just downgraded an XPS 9370 and then upgraded it again using gnome-software 3.28.1-0ubuntu4.18.04.8 and it works like I expected.

This bug was fixed in the package fwupd - 1.0.9-0ubuntu2

---------------
fwupd (1.0.9-0ubuntu2) bionic; urgency=medium

  * Restrict libsmbios-dev to x86 architectures (LP: #1791999, #1768627, #1719797)

 -- Mario Limonciello <email address hidden> Tue, 23 Oct 2018 11:35:36 -0500

The verification of the Stable Release Update for fwupd has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package gnome-software - 3.28.1-0ubuntu4.18.04.8

---------------
gnome-software (3.28.1-0ubuntu4.18.04.8) bionic; urgency=medium

  * Re-released to generate correct .changes file

gnome-software (3.28.1-0ubuntu4.18.04.7) bionic; urgency=medium

  * debian/rules:
  * debian/patches/0001-packagekit-Add-configure-option-to-use-autoremove-fe.patch:
    - Build with PackageKit autoremove support (LP: #1552792)
  * debian/control:
  * debian/patches/0023-snap-Don-t-treat-auth-cancellation-as-an-error.patch:
    - Stop cancelling snapd authorization triggers error notification
      (LP: #1785240)

gnome-software (3.28.1-0ubuntu4.18.04.6) bionic; urgency=medium

  * debian/patches/0023-Revert-Revert-flatpak-Use-list-of-related-apps-for-i.patch:
  * debian/patches/0024-flatpak-Check-if-a-related-app-is-installed-even-whe.patch:
  * debian/patches/0025-flatpak-Include-related-refs-to-the-app-s-runtime-on.patch:
    - Disable the Flatpak changes - SRU testing showed they broke downgrades

gnome-software (3.28.1-0ubuntu4.18.04.5) bionic; urgency=medium

  * debian/patches/0023-Revert-Revert-flatpak-Use-list-of-related-apps-for-i.patch:
  * debian/patches/0024-flatpak-Check-if-a-related-app-is-installed-even-whe.patch:
  * debian/patches/0025-flatpak-Include-related-refs-to-the-app-s-runtime-on.patch:
    - Pull related flatpak refs (LP: #1754864)
  * debian/patches/0003-Sort-snaps-before-other-apps.patch:
    - Fix snap search result ordering (LP: #1798228)
  * debian/patches/0001-Set-reboot-notifications-as-urgent-to-avoid-them-tim.patch:
    - Stop reboot notification from timing out (LP: #1719797)
  * debian/patches/0001-lib-Allow-opening-CAB-files-that-resolve-more-than-o.patch:
    - Support composite CAB files (LP: #1798470)

 -- Robert Ancell <email address hidden> Wed, 21 Nov 2018 12:29:27 +1300