Ubuntu
gnome-control-center package

UIFe, white backgound for list

Bug #1719668 reported by Sebastien Bacher on 2017-09-26

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	gnome-control-center (Ubuntu)	Fix Released	Low	Unassigned

Bug Description

Upstream stated that it's the way it should be so it's somewhat a bug fix in our theme, it also improves readability

The theme should be updated but we don't want to land changes that could impact other softwares that late in the cycle so we propose doing it as a g-c-c patch for artful and update the theme next cycle

Tags:

Revision history for this message

Sebastien Bacher (seb128) wrote on 2017-09-26:

screenshot before change Edit (76.2 KiB, image/png)

Changed in gnome-control-center (Ubuntu):
importance:	Undecided → Low

Revision history for this message

Sebastien Bacher (seb128) wrote on 2017-09-26:

screenshot after change Edit (76.3 KiB, image/png)

Revision history for this message

Sebastien Bacher (seb128) wrote on 2017-09-26:

the code change Edit (2.1 KiB, text/plain)

Revision history for this message

Didier Roche-Tolomelli (didrocks) wrote on 2017-09-26:

After a quick review, the code looks good to me.

Revision history for this message

Gunnar Hjalmarsson (gunnarhj) wrote on 2017-09-26:

No problem from a docs POV. Unfortunately we hadn't the time to include Ubuntu specific screenshots this cycle.

Ubuntu Foundations Team Bug Bot (crichton) on 2017-09-26

tags:

added: patch

Sebastien Bacher (seb128) on 2017-09-26

Changed in gnome-control-center (Ubuntu):
status:	New → In Progress

Sebastien Bacher (seb128) on 2017-09-26

Changed in gnome-control-center (Ubuntu):
status:	In Progress → Fix Committed

Revision history for this message

Iain Lane (laney) wrote on 2017-09-27:

Screenshot from 2017-09-27 14-29-55.png Edit (180.4 KiB, image/png)

A problem is that the row:nth-child(odd) rule in gtk-widgets.css isn't applying here because of the ".view". I hacked the theme to make it do so, see this screenshot.

row:nth-child(odd) {
/* zebra stripping, see LP#945430 */
background-color: shade (@base_color, 0.965);
}

It looks more consistent to me, what do you think?

Revision history for this message

Launchpad Janitor (janitor) wrote on 2017-09-27:

This bug was fixed in the package gnome-control-center - 1:3.26.0-0ubuntu3

---------------
gnome-control-center (1:3.26.0-0ubuntu3) artful; urgency=medium

  * debian/patches/ubuntu-white-lists.patch: set a white bg for the lists
    when using the ubuntu theme, that's a workaround for artful to
    not modify the theme which could impact other softwares (lp: #1719668)

-- Sebastien Bacher <email address hidden> Tue, 26 Sep 2017 16:37:03 -0400