OpenLP

Configure OpenLP windows extends beyond the bottom of the screen

Bug #1668669 reported by Simon Goodfellow
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenLP
Fix Committed
Undecided
Raoul Snyman
OpenLP 2.9.1
2.4
Fix Released
Undecided
Raoul Snyman
OpenLP 2.4.6

Bug Description

OpenLP 2.4.5 on Windows 10 Home

When I run OpenLP on a 1280x720 screen and open Configure OpenLP it extends off the bottom of the screen so that the OK and Cancel buttons are hidden.
If I resize the screen to accommodate the Configure OpenLP window and the then resize back to 1280x720 the Configure OpenLP window fits the screen for the rest of this execution of OpenLP.

Related branches

lp:~raoul-snyman/openlp/bug-1668669-2.4
Tim Bentley: Approve
Diff: 31 lines (+12/-1)
2 files modified
openlp/core/ui/settingsdialog.py (+1/-1)
tests/functional/openlp_core_ui/test_settingsform.py (+11/-0)
Superseded for merging into lp:openlp
OpenLP Core: Pending requested
Diff: 226847 lines (+168501/-11837) (has conflicts)
138 files modified
.bzrignore (+4/-0)
openlp/.version (+4/-0)
openlp/core/__init__.py (+9/-4)
openlp/core/common/__init__.py (+6/-0)
openlp/core/common/historycombobox.py.OTHER (+84/-0)
openlp/core/lib/colorbutton.py.OTHER (+82/-0)
openlp/core/lib/dockwidget.py.OTHER (+56/-0)
openlp/core/lib/listwidgetwithdnd.py.OTHER (+107/-0)
openlp/core/lib/projector/constants.py (+64/-0)
openlp/core/lib/projector/pjlink1.py (+67/-1)
openlp/core/lib/spelltextedit.py.OTHER (+204/-0)
openlp/core/lib/toolbar.py.OTHER (+90/-0)
openlp/core/lib/treewidgetwithdnd.py.OTHER (+144/-0)
openlp/core/resources.py (+87665/-11233)
openlp/core/ui/aboutdialog.py (+14/-0)
openlp/core/ui/exceptionform.py (+7/-0)
openlp/core/ui/generaltab.py (+0/-1)
openlp/core/ui/listpreviewwidget.py.OTHER (+176/-0)
openlp/core/ui/mainwindow.py (+20/-9)
openlp/core/ui/media/systemplayer.py (+35/-2)
openlp/core/ui/mediadockmanager.py.OTHER (+71/-0)
openlp/core/ui/projector/manager.py (+65/-2)
openlp/core/ui/projector/sourceselectform.py (+63/-4)
openlp/core/ui/settingsdialog.py (+5/-0)
openlp/core/ui/wizard.py.OTHER (+305/-0)
openlp/core/utils/__init__.py.OTHER (+543/-0)
openlp/core/utils/actions.py.OTHER (+388/-0)
openlp/core/utils/db.py.OTHER (+71/-0)
openlp/core/utils/languagemanager.py.OTHER (+146/-0)
openlp/plugins/bibles/forms/bibleupgradeform.py.OTHER (+561/-0)
openlp/plugins/bibles/lib/importers/http.py (+10/-0)
openlp/plugins/bibles/lib/importers/zefania.py (+11/-0)
openlp/plugins/bibles/lib/mediaitem.py (+8/-0)
openlp/plugins/presentations/lib/pdfcontroller.py (+31/-0)
openlp/plugins/remotes/html/index.html (+18/-0)
openlp/plugins/remotes/html/jquery-migrate.js (+752/-0)
openlp/plugins/remotes/html/jquery-migrate.min.js (+2/-0)
openlp/plugins/remotes/html/jquery.js.OTHER (+11008/-0)
openlp/plugins/remotes/html/jquery.min.js.OTHER (+5/-0)
openlp/plugins/remotes/html/jquery.mobile.css (+2332/-0)
openlp/plugins/remotes/html/jquery.mobile.js.OTHER (+9162/-0)
openlp/plugins/remotes/html/jquery.mobile.min.css.OTHER (+2/-0)
openlp/plugins/remotes/html/jquery.mobile.min.js.OTHER (+2/-0)
openlp/plugins/remotes/html/main.css.OTHER (+32/-0)
openlp/plugins/remotes/html/main.js.OTHER (+45/-0)
openlp/plugins/remotes/html/openlp.css.OTHER (+31/-0)
openlp/plugins/remotes/html/openlp.js.OTHER (+386/-0)
openlp/plugins/remotes/html/stage.css.OTHER (+64/-0)
openlp/plugins/remotes/html/stage.js.OTHER (+170/-0)
openlp/plugins/remotes/lib/remotetab.py (+12/-0)
openlp/plugins/songs/forms/editsongform.py (+16/-1)
openlp/plugins/songs/lib/__init__.py (+8/-0)
openlp/plugins/songs/lib/db.py (+2/-2)
openlp/plugins/songs/lib/importers/easyworship.py (+32/-0)
openlp/plugins/songs/lib/importers/mediashout.py (+7/-0)
openlp/plugins/songs/lib/importers/openlp.py (+5/-0)
openlp/plugins/songs/lib/importers/songbeamer.py (+13/-0)
openlp/plugins/songs/lib/importers/videopsalm.py (+6/-0)
openlp/plugins/songs/lib/mediaitem.py (+26/-0)
openlp/plugins/songs/lib/songselect.py (+57/-5)
openlp/plugins/songusage/forms/songusagedetailform.py (+11/-2)
openlp/plugins/songusage/songusageplugin.py (+3/-3)
resources/i18n/af.ts (+2175/-40)
resources/i18n/bg.ts (+2060/-39)
resources/i18n/cs.ts (+1386/-9)
resources/i18n/da.ts (+1396/-9)
resources/i18n/de.ts (+1381/-11)
resources/i18n/el.ts (+2201/-47)
resources/i18n/en.ts (+1385/-9)
resources/i18n/en_GB.ts (+1384/-9)
resources/i18n/en_ZA.ts (+1374/-9)
resources/i18n/es.ts (+1415/-9)
resources/i18n/et.ts (+1402/-9)
resources/i18n/fi.ts (+1407/-12)
resources/i18n/fr.ts (+1387/-9)
resources/i18n/hu.ts (+1963/-15)
resources/i18n/id.ts (+1377/-9)
resources/i18n/ja.ts (+1701/-12)
resources/i18n/ko.ts (+2409/-28)
resources/i18n/lt.ts (+2504/-40)
resources/i18n/nb.ts (+1378/-11)
resources/i18n/nl.ts (+1377/-9)
resources/i18n/pl.ts (+1726/-12)
resources/i18n/pt_BR.ts (+1685/-16)
resources/i18n/ru.ts (+1379/-8)
resources/i18n/sk.ts (+1408/-9)
resources/i18n/sv.ts (+1772/-17)
resources/i18n/ta_LK.ts (+2194/-39)
resources/i18n/th_TH.ts (+2122/-39)
resources/i18n/zh_CN.ts (+2204/-39)
resources/i18n/zh_TW.ts (+1700/-12)
scripts/translation_utils.py (+4/-0)
tests/functional/openlp_core_common/test_projector_utilities.py (+4/-0)
tests/functional/openlp_core_common/test_registryproperties.py (+31/-1)
tests/functional/openlp_core_lib/test_color_button.py.OTHER (+199/-0)
tests/functional/openlp_core_lib/test_htmlbuilder.py (+25/-0)
tests/functional/openlp_core_lib/test_projector_pjlink1.py (+345/-0)
tests/functional/openlp_core_ui/test_aboutform.py (+44/-0)
tests/functional/openlp_core_ui/test_firsttimeform.py (+20/-0)
tests/functional/openlp_core_ui/test_generaltab.py (+54/-0)
tests/functional/openlp_core_ui/test_listpreviewwidget.py.OTHER (+52/-0)
tests/functional/openlp_core_ui/test_mainwindow.py (+13/-0)
tests/functional/openlp_core_ui/test_projector_sourceselectform.py (+83/-0)
tests/functional/openlp_core_ui/test_servicemanager.py (+140/-11)
tests/functional/openlp_core_ui/test_settingsform.py (+11/-0)
tests/functional/openlp_core_ui/test_shortcutlistdialog.py (+60/-0)
tests/functional/openlp_core_ui/test_themetab.py (+84/-0)
tests/functional/openlp_core_ui_media/test_systemplayer.py (+499/-0)
tests/functional/openlp_core_utils/__init__.py.OTHER (+21/-0)
tests/functional/openlp_core_utils/test_actions.py.OTHER (+245/-0)
tests/functional/openlp_core_utils/test_db.py.OTHER (+104/-0)
tests/functional/openlp_core_utils/test_first_time.py.OTHER (+57/-0)
tests/functional/openlp_core_utils/test_init.py.OTHER (+129/-0)
tests/functional/openlp_core_utils/test_utils.py.OTHER (+491/-0)
tests/functional/openlp_plugins/bibles/test_manager.py (+69/-0)
tests/functional/openlp_plugins/presentations/test_pdfcontroller.py (+74/-0)
tests/functional/openlp_plugins/remotes/test_router.py (+23/-0)
tests/functional/openlp_plugins/songs/test_editsongform.py (+34/-0)
tests/functional/openlp_plugins/songs/test_lib.py (+27/-0)
tests/functional/openlp_plugins/songs/test_openlpimporter.py (+75/-0)
tests/functional/openlp_plugins/songs/test_songselect.py (+160/-10)
tests/functional/openlp_plugins/songusage/test_songusage.py (+28/-1)
tests/interfaces/openlp_core_common/test_historycombobox.py.OTHER (+65/-0)
tests/interfaces/openlp_core_lib/test_pluginmanager.py (+10/-0)
tests/interfaces/openlp_core_ui/test_listpreviewwidget.py.OTHER (+106/-0)
tests/interfaces/openlp_core_ui/test_projectorsourceform.py (+5/-8)
tests/interfaces/openlp_core_utils/__init__.py.OTHER (+21/-0)
tests/interfaces/openlp_core_utils/test_utils.py.OTHER (+81/-0)
tests/interfaces/openlp_plugins/custom/forms/test_customform.py (+19/-0)
tests/interfaces/openlp_plugins/songusage/test_songusagedetailform.py (+99/-0)
tests/resources/easyslidessongs/Export_2017-01-12_BB.json (+44/-0)
tests/resources/easyslidessongs/Export_2017-01-12_BB.xml (+50/-0)
tests/resources/opensongsongs/Amazing Grace with bad CCLI (+56/-0)
tests/resources/opensongsongs/Amazing Grace without CCLI.json (+42/-0)
tests/resources/songshowplussongs/cleanse-me.json (+38/-0)
tests/resources/videopsalmsongs/as-safe-a-stronghold2.json (+35/-0)
tests/resources/videopsalmsongs/videopsalm-as-safe-a-stronghold2.json (+47/-0)
tests/utils/test_bzr_tags.py (+1/-1)
lp:~raoul-snyman/openlp/bug-1668669
Tim Bentley: Approve
Diff: 34 lines (+15/-1)
2 files modified
openlp/core/ui/settingsdialog.py (+1/-1)
tests/functional/openlp_core_ui/test_settingsform.py (+14/-0)
Revision history for this message
Simon Goodfellow (simondgoodfellow) wrote :
Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Is the configuration window that tall on all your computers? On mine it doesn't look as tall as yours, and my font appears to be bigger than yours.

Revision history for this message
Simon Goodfellow (simondgoodfellow) wrote : Re: [Bug 1668669] Re: Configure OpenLP windows extends beyond the bottom of the screen

I tried Windows 10 Home on 2 computers and Pro on a third. In two of those
it was a newly installed Windows 10 and as a consequence an out of the box
OpenLP with a copied data folder. I got the same size configuration window
and same behaviour.

I noticed the window was extra long.

Let me know if I can collect more info.

I understand it needs to be repeatable.

Simon

On 1 Mar 2017 1:11 p.m., "Raoul Snyman" <email address hidden> wrote:

> Is the configuration window that tall on all your computers? On mine it
> doesn't look as tall as yours, and my font appears to be bigger than
> yours.
>
> ** Attachment added: "Screenshot_20170301_095525.png"
> https://bugs.launchpad.net/openlp/+bug/1668669/+
> attachment/4829092/+files/Screenshot_20170301_095525.png
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1668669
>
> Title:
> Configure OpenLP windows extends beyond the bottom of the screen
>
> Status in OpenLP:
> New
>
> Bug description:
> OpenLP 2.4.5 on Windows 10 Home
>
> When I run OpenLP on a 1280x720 screen and open Configure OpenLP it
> extends off the bottom of the screen so that the OK and Cancel buttons are
> hidden.
> If I resize the screen to accommodate the Configure OpenLP window and
> the then resize back to 1280x720 the Configure OpenLP window fits the
> screen for the rest of this execution of OpenLP.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openlp/+bug/1668669/+subscriptions
>
>

Revision history for this message
Simon Goodfellow (simondgoodfellow) wrote :

Hi Raoul

Thanks for checking this out.

I think the extra tall is an optical illusion. The minimum height seems to
be set to fit on a 1024x768 screen. If I choose a screen height less then
768 pixels then the Configure OpenLP window stays the same height but
extends off the bottom of the screen. It doesn't need to be this tall to
fit the potential content. When I resize theres is a minimum height it will
got to which is plenty for the content.

I am on a resolution of 1280x720 because it is 720p for a TV. We are
probably a non-typical user as we use a mini PC behind the TV in the church
running at the resolution for the TV and access it remotely using
teamviewer for service setup. We operate the service using android remote /
web interface and occasionally resorting to a keyboard.

Looking at the code - openlp/core/ui/settingsdialog.py The window is set to
800x700

settings_dialog.resize(800, 700)

I checked and it is 800 wide but around 690 tall excluding the header. It
is the header that puts the bottom of it under the task bar on a 720p
screen.

Thanks again for checking this out.

Simon

On Wed, Mar 1, 2017 at 1:22 PM, Simon Goodfellow <email address hidden> wrote:

> I tried Windows 10 Home on 2 computers and Pro on a third. In two of those
> it was a newly installed Windows 10 and as a consequence an out of the box
> OpenLP with a copied data folder. I got the same size configuration window
> and same behaviour.
>
> I noticed the window was extra long.
>
> Let me know if I can collect more info.
>
> I understand it needs to be repeatable.
>
> Simon
>
> On 1 Mar 2017 1:11 p.m., "Raoul Snyman" <email address hidden> wrote:
>
>> Is the configuration window that tall on all your computers? On mine it
>> doesn't look as tall as yours, and my font appears to be bigger than
>> yours.
>>
>> ** Attachment added: "Screenshot_20170301_095525.png"
>> https://bugs.launchpad.net/openlp/+bug/1668669/+attachment/
>> 4829092/+files/Screenshot_20170301_095525.png
>>
>> --
>> You received this bug notification because you are subscribed to the bug
>> report.
>> https://bugs.launchpad.net/bugs/1668669
>>
>> Title:
>> Configure OpenLP windows extends beyond the bottom of the screen
>>
>> Status in OpenLP:
>> New
>>
>> Bug description:
>> OpenLP 2.4.5 on Windows 10 Home
>>
>> When I run OpenLP on a 1280x720 screen and open Configure OpenLP it
>> extends off the bottom of the screen so that the OK and Cancel buttons are
>> hidden.
>> If I resize the screen to accommodate the Configure OpenLP window and
>> the then resize back to 1280x720 the Configure OpenLP window fits the
>> screen for the rest of this execution of OpenLP.
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/openlp/+bug/1668669/+subscriptions
>>
>>

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Hey Simon,

Yes, I found that too. I've reduced the size as much as I can (internal height of the window is 625px, I can't control the decorations). Hopefully this will help.

On Linux/KDE I can just hold down Alt and click and drag anywhere on the window to pull it up so that I can get to the buttons at the bottom, but I'm guessing Windows can't do that?

Revision history for this message
Simon Goodfellow (simondgoodfellow) wrote :

Hi Raoul

Thanks, I am sure that will do the trick.

On Windows it won't let a window extend above the screen so moving it
doesn't help. picking the top border and resizing the window then dragging
it up does, as does using Esc for cancel and Enter for OK. I doesn't bother
me at all, but some of my crew of fairly untechnical people get easily
upset thinking the buttons are missing completely.

Thanks again

Simon

On Wed, Mar 1, 2017 at 7:36 PM, Raoul Snyman <email address hidden> wrote:

> Hey Simon,
>
> Yes, I found that too. I've reduced the size as much as I can (internal
> height of the window is 625px, I can't control the decorations).
> Hopefully this will help.
>
> On Linux/KDE I can just hold down Alt and click and drag anywhere on the
> window to pull it up so that I can get to the buttons at the bottom, but
> I'm guessing Windows can't do that?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1668669
>
> Title:
> Configure OpenLP windows extends beyond the bottom of the screen
>
> Status in OpenLP:
> New
>
> Bug description:
> OpenLP 2.4.5 on Windows 10 Home
>
> When I run OpenLP on a 1280x720 screen and open Configure OpenLP it
> extends off the bottom of the screen so that the OK and Cancel buttons are
> hidden.
> If I resize the screen to accommodate the Configure OpenLP window and
> the then resize back to 1280x720 the Configure OpenLP window fits the
> screen for the rest of this execution of OpenLP.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openlp/+bug/1668669/+subscriptions
>
>

Revision history for this message
Simon Goodfellow (simondgoodfellow) wrote :

Hi Raoul

Thought I should close the loop and test revision 2724 from source on our
system. It solves the problem for us.

[image: Inline image 1]

Thanks

Every blessing in Christ

Simon

On Wed, Mar 1, 2017 at 9:54 PM, Simon Goodfellow <email address hidden> wrote:

> Hi Raoul
>
> Thanks, I am sure that will do the trick.
>
> On Windows it won't let a window extend above the screen so moving it
> doesn't help. picking the top border and resizing the window then dragging
> it up does, as does using Esc for cancel and Enter for OK. I doesn't bother
> me at all, but some of my crew of fairly untechnical people get easily
> upset thinking the buttons are missing completely.
>
> Thanks again
>
> Simon
>
> On Wed, Mar 1, 2017 at 7:36 PM, Raoul Snyman <email address hidden> wrote:
>
>> Hey Simon,
>>
>> Yes, I found that too. I've reduced the size as much as I can (internal
>> height of the window is 625px, I can't control the decorations).
>> Hopefully this will help.
>>
>> On Linux/KDE I can just hold down Alt and click and drag anywhere on the
>> window to pull it up so that I can get to the buttons at the bottom, but
>> I'm guessing Windows can't do that?
>>
>> --
>> You received this bug notification because you are subscribed to the bug
>> report.
>> https://bugs.launchpad.net/bugs/1668669
>>
>> Title:
>> Configure OpenLP windows extends beyond the bottom of the screen
>>
>> Status in OpenLP:
>> New
>>
>> Bug description:
>> OpenLP 2.4.5 on Windows 10 Home
>>
>> When I run OpenLP on a 1280x720 screen and open Configure OpenLP it
>> extends off the bottom of the screen so that the OK and Cancel buttons are
>> hidden.
>> If I resize the screen to accommodate the Configure OpenLP window and
>> the then resize back to 1280x720 the Configure OpenLP window fits the
>> screen for the rest of this execution of OpenLP.
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/openlp/+bug/1668669/+subscriptions
>>
>>
>

Tim Bentley (trb143)
Changed in openlp:
status: New → Fix Committed
assignee: nobody → Raoul Snyman (raoul-snyman)
milestone: none → 2.4.6
Tim Bentley (trb143)
Changed in openlp:
milestone: 2.4.6 → 2.5.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.