Libertine

It's possible to have 2 instances of the container managers running at the same time

Bug #1657490 reported by Christopher Townsend
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Libertine
Status tracked in Devel
Devel
Fix Released
Medium
Christopher Townsend
Libertine 1.6
Trunk
Fix Released
Medium
Christopher Townsend
Libertine 1.6
libertine (Ubuntu)
Fix Released
Medium
Christopher Townsend

Bug Description

It's possible to have 2 instances of a container manager running at the same time. For example, launching a Libertine app in U8 will start libertine-lx{cd}-manager and then running libertine-container-manager operations in an ssh session will start another instance of libertine-lx{cd}-manager.

After some investigation, this is due to a systemd user dbus session now existing when in an ssh session, which is different than the Upstart session dbus used in the U8 session. So the service will start for each.

We need a way to figure out if U8 is running and use it's session dbus and if it's not running, don't use the libertine-lx{cd}-manager at all.

Related branches

lp:~townsend/libertine/use-session-dbus
Larry Price: Approve
Libertine CI Bot: Approve (continuous-integration)
Diff: 101 lines (+25/-26)
3 files modified
python/libertine/LxcContainer.py (+6/-7)
python/libertine/LxdContainer.py (+4/-5)
python/libertine/utils.py (+15/-14)
lp:~townsend/libertine/1.6-release
Stephen M. Webb (community): Approve
Diff: 4853 lines (+1240/-1763)
74 files modified
CMakeLists.txt (+2/-2)
cmake/FindGObjectIntrospection.cmake (+0/-61)
cmake/ListOperations.cmake (+0/-18)
cmake/UseGObjectIntrospection.cmake (+0/-102)
common/LibertineConfig.cpp (+10/-1)
data/CMakeLists.txt (+1/-3)
data/com.canonical.libertine.LxcManager.service (+0/-3)
data/com.canonical.libertine.LxdManager.service (+0/-3)
data/com.canonical.libertine.Service.service (+1/-1)
data/libertine-xmir.conf (+1/-1)
data/snap-runner.wrapper (+2/-1)
debian/changelog (+40/-0)
debian/control (+22/-18)
debian/gir1.2-libertine.install (+0/-2)
debian/libertine-tools.install (+0/-2)
debian/libertined.install (+3/-0)
debian/python3-libertine-lxc.install (+0/-2)
debian/python3-libertine-lxd.install (+0/-2)
debian/python3-libertine.install (+0/-3)
debian/rules (+1/-4)
liblibertine/CMakeLists.txt (+3/-30)
liblibertine/libertine.cpp (+20/-131)
liblibertine/libertine.h (+4/-4)
liblibertine/libertined.cpp (+199/-0)
liblibertine/libertined.h (+25/-0)
python/libertine/AppDiscovery.py (+0/-220)
python/libertine/ChrootContainer.py (+6/-13)
python/libertine/ContainersConfig.py (+21/-2)
python/libertine/HostInfo.py (+8/-1)
python/libertine/Libertine.py (+62/-52)
python/libertine/LxcContainer.py (+137/-65)
python/libertine/LxdContainer.py (+131/-131)
python/libertine/launcher/config.py (+1/-4)
python/libertine/lifecycle/ContainerLifecycleService.py (+0/-108)
python/libertine/lifecycle/ContainerLifecycleServiceRunner.py (+0/-46)
python/libertine/lifecycle/LifecycleResult.py (+0/-37)
python/libertine/lifecycle/__init__.py (+0/-23)
python/libertine/service/apt.py (+2/-6)
python/libertine/service/container.py (+23/-8)
python/libertine/service/manager.py (+40/-4)
python/libertine/service/progress.py (+3/-3)
python/libertine/service/task_dispatcher.py (+7/-8)
python/libertine/service/tasks/__init__.py (+3/-3)
python/libertine/service/tasks/base_task.py (+2/-4)
python/libertine/service/tasks/container_info_task.py (+21/-5)
python/libertine/service/tasks/list_app_ids_task.py (+35/-0)
python/libertine/service/tasks/list_apps_task.py (+0/-30)
python/libertine/service/tasks/list_task.py (+6/-4)
python/libertine/utils.py (+29/-59)
setup/gui/libertine-manager-app.desktop (+12/-0)
snapcraft.yaml (+40/-6)
tests/integration/CMakeLists.txt (+1/-1)
tests/integration/test_libertine_service.py (+40/-22)
tests/unit/service/tasks/CMakeLists.txt (+1/-1)
tests/unit/service/tasks/test_container_info_task.py (+14/-2)
tests/unit/service/tasks/test_list_app_ids_task.py (+59/-0)
tests/unit/service/tasks/test_list_apps_task.py (+0/-59)
tests/unit/service/tasks/test_list_task.py (+8/-6)
tests/unit/service/test_apt.py (+37/-45)
tests/unit/service/test_container.py (+33/-47)
tests/unit/service/test_task_dispatcher.py (+17/-17)
tests/unit/test_app_discovery.py (+0/-52)
tests/unit/test_libertine_container.py (+2/-1)
tests/unit/test_libertine_gir.py (+0/-65)
tools/CMakeLists.txt (+3/-3)
tools/completions/libertine-container-manager (+9/-5)
tools/libertine-container-manager (+65/-11)
tools/libertine-container-manager.1 (+25/-3)
tools/libertine-lxc-manager (+0/-109)
tools/libertine-lxc-manager.1 (+0/-9)
tools/libertine-lxd-manager (+0/-57)
tools/libertine-lxd-manager.1 (+0/-9)
tools/libertine-lxd-setup (+1/-1)
tools/libertine-xmir (+2/-2)
lp:~ci-train-bot/libertine/libertine-ubuntu-zesty-2452 (Merged)
Christopher Townsend (townsend)
Changed in libertine (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Libertine CI Bot (libertine-ci-bot) wrote :

Fix committed into lp:libertine at revision 378, scheduled for release in libertine, milestone Unknown

Changed in libertine:
status: In Progress → Fix Committed
Christopher Townsend (townsend)
Changed in libertine (Ubuntu):
status: Triaged → In Progress
assignee: nobody → Christopher Townsend (townsend)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libertine - 1.6+17.04.20170209-0ubuntu1

---------------
libertine (1.6+17.04.20170209-0ubuntu1) zesty; urgency=medium

  [ Larry Price ]
  * Get libertine-container-manager and libertine-launch working in a confined
    environment.
  * Create a special desktop file to satisfy the snappy store.
  * Update snap definition to include aliases, renamed commands, and internal
    desktop file.
  * Ensure absolute path lxd bind-mounts have a valid name by using the full
    path as a backup.
  * Refactor liblibertine as a client wrapper for libertined and bump version
    to 1.5.2.
  * Protect against containers that aren't started when running commands.
  * Migrate the list-apps subcommand to list application ids. (LP: #1657877)
  * Run the libertined integration test with its own dbus sesison to prevent
    collisions with running service.

  [ Chris Townsend ]
  * Discover if a session is running and if so, use it's dbus session to start
    the container manager. (LP: #1657490)
  * Replace all pylxd execute()'s with calls to 'lxc exec' as pylxd has
    performance issues in execute().
  * Add ability to freeze and unfreeze LXC/LXD containers. This is disabled by
    default for now. (LP: #1654355)
  * Add ability to enable and disable the freezing of LXC/LXD containers when
    not in use. (LP: #1654355)
  * Deprecate the lx[cd] managers and use libertined for managing the containers
    and move the actual starting and stopping of containers to the respective
    backends. (LP: #1660685)
  * Add a restart subcommand to libertine-container-manager. Also try to restart
    the container when adding/removing bind-mounts, if appropriate.
    (LP: #1654355)
  * Enable Xmir '-rootless' mode by default and remove using Matchbox for the
    window manager. (LP: #1662555)
  * Change when the libertine-xmir Upstart gets started to account for Unity 8
    now directly starting apps.
  * Bump release version to 1.6.

 -- Christopher Townsend <email address hidden> Thu, 09 Feb 2017 16:14:23 +0000

Changed in libertine (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.