Ubuntu
gthumb package

silently fails to save bmp picture

Bug #165174 reported by Tormod Volden
6
Affects Status Importance Assigned to Milestone
gThumb
Fix Released
Medium
gthumb (Ubuntu)
Fix Released
Medium
Ubuntu Desktop Bugs
Gutsy
Fix Released
Medium
Unassigned

Bug Description

Binary package hint: gthumb
Version: 3:2.10.6-0ubuntu1 (Gutsy)

1. Open a bmp file in gthumb.
2. Manipulate it with for instance Crop (and Apply).
3. Save

The file is not saved, and
** (gthumb:7451): WARNING **: Invalid image type
is written to stdout. No GUI warning.

4. Save as, and change name to .png

Now, apparently saving as .png works fine.

- OR -

1. Open a png file in gthumb
2. Save as, and change name to .bmp

The file is not saved, and
** (gthumb:7451): WARNING **: Invalid image type
is written to stdout. No GUI warning.

See original description

Related branches

lp:ubuntu/lucid/gthumb
Tormod Volden (tormodvolden)
description: updated
Revision history for this message
Pedro Villavicencio (pedro) wrote :

Thanks for your report.

Changed in gthumb:
assignee: nobody → desktop-bugs
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Pedro Villavicencio (pedro) wrote :

I've sent this upstream at: http://bugzilla.gnome.org/show_bug.cgi?id=499795 ; thanks!.

Revision history for this message
Tormod Volden (tormodvolden) wrote :

Thanks. For the "Importance": it's a dataloss candidate, since changes are not saved even if you think they are, because of the missing visible feedback.

Pedro Villavicencio (pedro)
Changed in gthumb:
importance: Low → Medium
Revision history for this message
Pedro Villavicencio (pedro) wrote :

Comment from upstream:

"Fix applied, http://svn.gnome.org/viewvc/gthumb?view=revision&revision=2084.

gThumb can in fact save bmp files.

Fix should appear in 2.10.8.

- Mike"

Changed in gthumb:
status: Triaged → Fix Committed
Revision history for this message
Tormod Volden (tormodvolden) wrote :

What about getting this fixed in Hardy now anyway, so that it can be evaluated for a Gutsy SRU?

 gthumb (3:2.10.6-0ubuntu2) hardy; urgency=low
 .
   * 21_dont_skip_file_type.dpatch (LP: #165174)
   * add Build-depends on libltdl3-dev (LP: #151696)

Bug Watch Updater (bug-watch-updater)
Changed in gthumb:
status: Unknown → Fix Released
Revision history for this message
Tormod Volden (tormodvolden) wrote :

gthumb (3:2.10.6-0ubuntu2) hardy; urgency=low

  * 21_dont_skip_file_type.dpatch (LP: #165174)
  * add Build-depends on libltdl3-dev (LP: #151696)

 -- Tormod Volden <email address hidden> Mon, 03 Dec 2007 13:55:27 +0100

Changed in gthumb:
status: Fix Committed → Fix Released
Revision history for this message
Tormod Volden (tormodvolden) wrote :

SRU: minimal patch for Gutsy is attached

Nominating for SRU, fulfills: (1) have an obviously safe patch and (2) affect an application rather than critical infrastructure packages

The fix is from upstream and has been verified in Hardy.

The missing build dependency on libltdl3-dev seems to be needed for building on Gutsy as well. I don't know how the old version could be build, it can not have been a clean pbuilder AFAICS.

Revision history for this message
Martin Pitt (pitti) wrote :

Approved with the 'silent data loss' justification, although .bmp is not very common these days.

The changelog should be improved to point out the impact to users, i. e. describe which problem the patch fixes. Many users read the chanelog in update-notifier.

Changed in gthumb:
importance: Undecided → Medium
Revision history for this message
Martin Pitt (pitti) wrote :

Taking for sponsoring, thanks Tormod!

Changed in gthumb:
assignee: nobody → pitti
status: New → In Progress
Revision history for this message
Tormod Volden (tormodvolden) wrote :

> although .bmp is not very common these days.
It is for instance the standard screenshot format in another popular OS...

Attached new combi-patch to bug #173082.

Revision history for this message
Martin Pitt (pitti) wrote :

Sponsored and accepted into gutsy-proposed, please test. Thank you!

Changed in gthumb:
assignee: pitti → tormodvolden
status: In Progress → Fix Committed
Revision history for this message
Pedro Villavicencio (pedro) wrote :

Verification done:

- With gthumb 2.10.6-0ubuntu1 on gutsy after modified a bmp image and try to save it, gthumb is unable to perform the operation and the "** (gthumb:7451): WARNING **: Invalid image type" error is show on the CLI.
- With gthumb 2.10.6-0ubuntu1.1 on gutsy , after following the test case, gthumb is able to save the image, also I've reopened the image to see if the changes were applied and yes the modified image was saved, bug is fixed, thanks.

Tormod Volden (tormodvolden)
Changed in gthumb:
assignee: tormodvolden → nobody
status: Fix Committed → Fix Released
Bug Watch Updater (bug-watch-updater)
Changed in gthumb:
importance: Unknown → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.