Icons missing when appearance setting is "high contrast"

Bug #1644662 reported by Bram Stolk
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
gnome-themes-standard (Ubuntu)
Fix Released
High
Dariusz Gadomski
Xenial
Fix Released
High
Dariusz Gadomski
Artful
Fix Released
High
Dariusz Gadomski

Bug Description

[Impact]

 * Switching to HighContrast theme in System Settings/Appearance results in missing icons for some of the panels in System Settings.
 * Only Xenial is affected of the currently supported releases.
 * Current development release is not affected.

[Test Case]

 * Open System Settings, select Appearance.
 * Choose the "High Contrast" theme.
 * Go back by selecting "All Settings".

Expected result: there are icons to all items in the Settings window.
Actual result: some items are missing icons.

[Regression Potential]

 * There might be different icons used in some places depending on the fact that for Xenial HighContrast used Adwaita themes. Possibly icons may be missing in different places.

[Other Info]
 * For some reason Trusty was using HighContrast icons and the change was made somewhere in between Trusty - Xenial.
 * Original bug description:

To reproduce this:

Open System Settings.

Click Appearance

Theme: High Contrast.

Click All Settings tab:

Many icons are missing.

ProblemType: Bug
DistroRelease: Ubuntu 16.04
Package: unity-control-center 15.04.0+16.04.20160705-0ubuntu1
ProcVersionSignature: Ubuntu 4.4.0-47.68-generic 4.4.24
Uname: Linux 4.4.0-47-generic x86_64
NonfreeKernelModules: nvidia_uvm nvidia_drm nvidia_modeset nvidia
ApportVersion: 2.20.1-0ubuntu2.1
Architecture: amd64
CurrentDesktop: Unity
Date: Thu Nov 24 14:45:30 2016
ExecutablePath: /usr/bin/unity-control-center
InstallationDate: Installed on 2015-06-06 (537 days ago)
InstallationMedia: Ubuntu 15.04 "Vivid Vervet" - Release amd64 (20150422)
ProcEnviron:
 PATH=(custom, user)
 SHELL=/bin/bash
 LANG=en_CA.UTF-8
 LANGUAGE=en_CA:en
 XDG_RUNTIME_DIR=<set>
SourcePackage: unity-control-center
UpgradeStatus: Upgraded to xenial on 2016-08-28 (88 days ago)

Related branches

Revision history for this message
Bram Stolk (b-stolk) wrote :
Revision history for this message
David Coronel (davecore) wrote :

It looks like after switching to the HighContrast theme in Appearance, 'Adwaita' is being set as the icon theme in dconf. We think it's not Adwaita that should be used, but rather the HighContrast icon theme.

You can use the unity-tweak-tool to change the icon theme to highcontrast and notice that the situation is much better. After a reboot (and after enabling the highcontrast icon theme with unity-tweak-tool) I get almost all the icons in high contrast.

I think if we could just use the high contrast icon theme when clicking the high contrast theme in appearance, it'd be much better already.

Revision history for this message
David Coronel (davecore) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in unity-control-center (Ubuntu):
status: New → Confirmed
Revision history for this message
Dariusz Gadomski (dgadomski) wrote :

The /usr/share/themes/HighContrast/index.theme sets Adwaita as the default icon theme for the HighContrast theme.

Unfortunately some of the needed icons are missing. I wonder why the HighContrast icon theme is not used here by default?

Another observation: as visible in David's screenshot there are some icons missing also in the HighContrast icon theme. However, these missing icons are replaced by their Adwaita counterparts resulting in a much better experience: no missing icons in the settings app (even despite the inconsistent theme).

I believe choosing HighContrast for the icon theme is a better choice than what we currently have.

Revision history for this message
Dariusz Gadomski (dgadomski) wrote :

SRU proposal for Xenial.

description: updated
tags: added: sts sts-sponsor
tags: added: sts-sponsor-needed
tags: removed: sts-sponsor-needed
Changed in unity-control-center (Ubuntu):
status: Confirmed → Invalid
Changed in unity-control-center (Ubuntu Xenial):
status: New → Confirmed
Dan Streetman (ddstreet)
tags: added: sts-sponsor-ddstreet
description: updated
Revision history for this message
Sebastien Bacher (seb128) wrote :

the change or equivalent doesn't seem to be in newest Ubuntu serie but it should by SRU rules, also seems like that's an upstream problem and should be reported there?

Revision history for this message
Dariusz Gadomski (dgadomski) wrote :

The fix has been merged upstream, preparing new debdiffs reflecting that.

Revision history for this message
Dariusz Gadomski (dgadomski) wrote :

Patch for bionic.

Revision history for this message
Dariusz Gadomski (dgadomski) wrote :

SRU proposal for artful.

Revision history for this message
Dariusz Gadomski (dgadomski) wrote :

SRU proposal for xenial.

Changed in unity-control-center (Ubuntu Xenial):
status: Confirmed → Invalid
no longer affects: unity-control-center (Ubuntu)
no longer affects: unity-control-center (Ubuntu Xenial)
no longer affects: unity-control-center (Ubuntu Artful)
no longer affects: unity-control-center (Ubuntu Bionic)
Jeremy Bícha (jbicha)
no longer affects: gnome-themes-standard (Ubuntu Bionic)
Changed in gnome-themes-standard (Ubuntu):
status: New → Fix Committed
importance: Undecided → High
Changed in gnome-themes-standard (Ubuntu Xenial):
importance: Undecided → High
Changed in gnome-themes-standard (Ubuntu Artful):
importance: Undecided → High
Changed in gnome-themes-standard (Ubuntu Xenial):
status: New → Triaged
Changed in gnome-themes-standard (Ubuntu Artful):
status: New → Triaged
Eric Desrochers (slashd)
Changed in gnome-themes-standard (Ubuntu Artful):
assignee: nobody → Dariusz Gadomski (dgadomski)
Changed in gnome-themes-standard (Ubuntu Xenial):
assignee: nobody → Dariusz Gadomski (dgadomski)
Changed in gnome-themes-standard (Ubuntu Artful):
status: Triaged → Confirmed
Changed in gnome-themes-standard (Ubuntu Xenial):
status: Triaged → Confirmed
Changed in gnome-themes-standard (Ubuntu):
assignee: nobody → Dariusz Gadomski (dgadomski)
Changed in gnome-themes-standard (Ubuntu Artful):
status: Confirmed → In Progress
Changed in gnome-themes-standard (Ubuntu Xenial):
status: Confirmed → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-themes-standard - 3.22.3-3ubuntu2

---------------
gnome-themes-standard (3.22.3-3ubuntu2) bionic; urgency=medium

  * Use HighContrast icons for the HighContrast theme. (LP: #1644662)

 -- Dariusz Gadomski <email address hidden> Thu, 08 Feb 2018 07:49:11 +0100

Changed in gnome-themes-standard (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Bram, or anyone else affected,

Accepted gnome-themes-standard into artful-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-themes-standard/3.22.3-1ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-artful to verification-done-artful. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-artful. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in gnome-themes-standard (Ubuntu Artful):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-artful
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Bram, or anyone else affected,

Accepted gnome-themes-standard into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-themes-standard/3.18.0-2ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in gnome-themes-standard (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed-xenial
Revision history for this message
Dariusz Gadomski (dgadomski) wrote :

I have just verified this in my env earlier used to reproduce the issue.
Results:
artful - 3.22.3-1ubuntu2 - verified
xenial - 3.18.0-2ubuntu2 - verified

tags: added: verification-done verification-done-artful verification-done-xenial
removed: verification-needed verification-needed-artful verification-needed-xenial
Revision history for this message
David Coronel (davecore) wrote :

I also confirm I tested the new gnome-themes-standard and gnome-accessibility-themes packages from -proposed in artful and xenial and it fixes the issue with the missing icons.

xenial:
gnome-themes-standard | 3.18.0-2ubuntu2
gnome-accessibility-themes | 3.18.0-2ubuntu2

artful:
gnome-themes-standard | 3.22.3-1ubuntu2
gnome-accessibility-themes | 3.22.3-1ubuntu2

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-themes-standard - 3.22.3-1ubuntu2

---------------
gnome-themes-standard (3.22.3-1ubuntu2) artful; urgency=medium

  * Use HighContrast icons for the HighContrast theme. (LP: #1644662)

 -- Dariusz Gadomski <email address hidden> Thu, 08 Feb 2018 07:52:35 +0100

Changed in gnome-themes-standard (Ubuntu Artful):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for gnome-themes-standard has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-themes-standard - 3.18.0-2ubuntu2

---------------
gnome-themes-standard (3.18.0-2ubuntu2) xenial; urgency=medium

  * Use HighContrast icons for the HighContrast theme. (LP: #1644662)

 -- Dariusz Gadomski <email address hidden> Thu, 08 Feb 2018 07:55:43 +0100

Changed in gnome-themes-standard (Ubuntu Xenial):
status: Fix Committed → Fix Released
Dan Streetman (ddstreet)
tags: removed: sts-sponsor sts-sponsor-ddstreet
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.