kde menu entry for 'Serpentine Audio CD Creator' has no icon

Same here.
I checked the latest source (0.9) and there are no icons shipped with.
gnome-dev-cdrom-audio is the generic "CD-icon" i think. So the KDE-menu-entry can use the "cdaudio_unmount" from the "Devices"-Section.

I'll work on it

Patch ready for pickup by sponsor

How can I integrate that into the upstream package? Apparently the patch is for the deb file. Am I wrong?

@Ralph: I was working on this bug, but as you worked on it I'm re-assign it. The next time, *please ask* if the "Assign to" field isn't empty. You must be respectful with other's job and time.

Thanks.

@Miguel: sorry for this. Apparently I had forgotten to assign it to me while I worked on it.

@Tiago: You can add the icon to the upstream package (it is the uue file, you can just uudecode it) and make sure that icon will be installed into the directory /usr/share/icons/hicolor/22x22/apps/

Thanks

Sébastien: can you take a look into this one.
Jonathan: sorry for subscribing.

Did you try to build this update? Looks like there is a typo in the rules.

Yes I built and installed it without any trouble before submitting the debdiff. And I also checked that it solved the bug.

Added intltool to build-depends. Did you mean that with the typo?

why did you add intltool to the build-depends? no, the build issue was not due to that. the rules target you are using are wrong too

1) intltool: Without it there is a error during the build because it calls an executable that is in that package.

2) What rules target is wrong? Something I added/changed? Or something that was wrong before.

I am really trying hard my best to do good work, but when one is constantly told that one does something wrong, but not what, it is quite frustrating. I cannot mindread and therefore I can neither do the right thing, nor learn something in the process if there are just statements that something is wrong, but not what. I think we both can use our time in a better way.

Thanks.

The version with the changes didn't build, I had the details when I commented but it took you 6 weeks to reply and I didn't note those. The other day I was quite busy and just commented quickly, detailling now the issues with your changes

The first debdiff you attached doesn't build,

"uudecode -o debian/usr/share/icons/hicolor/22x22/apps/gnome-dev-cdrom-audio.png debian/icons.gnome-dev-cdrom-audio.png.uue
uudecode: debian/icons.gnome-dev-cdrom-audio.png.uue: Unknown system error"

The icon source filename use a dot wrongly, which is the typo I was speaking about, not sure how it built for you

The new debdiff has some issues too, what version of Ubuntu do you use? The hardy cdbs Depends on intltool and serpentine Build-Depends on cdbs, so intltool should be installed without requiring your change.

Why did you add a "debian/icons/gnome-dev-cdrom-audio.png" rules target rather than just using the binary-install one?

The first change with the clean target added and without the typo would be correct

Sebastian,

thanks for your comments. They help me very much :)

I am not sure, how the typo slipped through. Long time ago... I can only think that I forgot to create a new debdiff after I fixed, build and tested it. Sorry for the inconvenience.

I used hardy to build it, in particular pbuilder. I did not notice the intltool problem until a couple of days ago, that's why I did not fix it before. I have done another update for pbuilder and this time it does not have the error, so I took it out again.

I am not sure I follow your question about the rules target. I need the create the binary png since I only have the uu-encoded one in the debdiff in order not to have any binary in it. I created a target rule since I thought it was cleaner to do that. I could certainly put the line just before the dh_install line if you think this is better.

Thanks for your help, I appreciate your advice a lot.

the rules is a simple makefile, there is no need to create a new target to copy the icon you can use the install one

Sebastian,

thanks for the explanation. I have attached the debdiff that I have changed according to your suggestions.

The changes of this debdiff are contained in the debdiff in bug #199277. Therefore I mark this report as a duplicate of #199277.

On second thought, I don't mark it as duplicate, since it will be close due to upload of the other debdiff anyway. Please use the debdiff of bug #199277 instead of this one.

I'm subscribing the universe sponsors since the package is there now, the icon change seem somebody that should go upstream and not be distribution specific though

This bug was fixed in the package serpentine - 0.9-5ubuntu2

---------------
serpentine (0.9-5ubuntu2) hardy; urgency=low

  * Fixed missing icon for non-Gnome menus (LP: #159712)
   - Add build-dep on sharutils, add
     debian/icons/gnome-dev-cdrom-audio.png.uue, add rule in
     debian/rules

 -- Ralph Janke <email address hidden> Thu, 28 Feb 2008 19:35:30 +0000

The change is not correct, if serpentine installs an icon it should use a name specific to the application and not overwrite something which is in the naming specification

gnome-dev-cdrom-audio is a desktop specific name, its not in the icon naming spec.