Libertine

Error popups stack when trying to add bogus PPA's multiple times

Bug #1594957 reported by Christopher Townsend
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Libertine
Status tracked in Devel
Devel
Fix Released
Medium
Larry Price
Libertine 1.3
Trunk
Fix Released
Medium
Larry Price
Libertine 1.3
libertine (Ubuntu)
Fix Released
Medium
Larry Price

Bug Description

When using the UI, trying to add bogus PPA's multiple times, the error PPA's are stacked meaning you have to dismiss the previous errors when the latest error pops up.

To reproduce:
1. Try adding a bogus PPA to a container.
2. Dismiss the popup.
3. Try adding another bogus PPA.
4. Now you have to dismiss 2 popups.
5. So on and so forth.

Tags: gui

Related branches

lp:~larryprice/libertine/double-dialog
Christopher Townsend: Approve
Libertine CI Bot: Approve (continuous-integration)
Diff: 32 lines (+3/-6)
1 file modified
libertine/qml/ExtraArchivesView.qml (+3/-6)
lp:~townsend/libertine/release-1.2.2
Larry Price: Approve
Diff: 2202 lines (+838/-865)
17 files modified
debian/changelog (+30/-0)
debian/python3-libertine.install (+2/-0)
debian/rules (+3/-0)
libertine/qml/ExtraArchivesView.qml (+3/-6)
libertine/qml/GenericErrorDialog.qml (+17/-3)
libertine/qml/HomeView.qml (+51/-43)
po/CMakeLists.txt (+0/-3)
python/libertine/ChrootContainer.py (+26/-72)
python/libertine/ContainersConfig.py (+309/-0)
python/libertine/HostInfo.py (+71/-0)
python/libertine/Libertine.py (+17/-44)
python/libertine/LxcContainer.py (+19/-16)
python/libertine/utils.py (+1/-29)
tests/unit/CMakeLists.txt (+11/-7)
tools/libertine-container-manager (+269/-634)
tools/libertine-launch (+8/-8)
tools/libertine-session-bridge (+1/-0)
lp:~ci-train-bot/libertine/libertine-ubuntu-yakkety-landing-012 (Merged)
Christopher Townsend (townsend)
tags: added: gui
Changed in libertine (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Libertine CI Bot (libertine-ci-bot) wrote :

Fix committed into lp:libertine at revision 258, scheduled for release in libertine, milestone Unknown

Changed in libertine:
status: In Progress → Fix Committed
Christopher Townsend (townsend)
Changed in libertine (Ubuntu):
status: Triaged → In Progress
assignee: nobody → Larry Price (larryprice)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libertine - 1.2.2+16.10.20160707-0ubuntu1

---------------
libertine (1.2.2+16.10.20160707-0ubuntu1) yakkety; urgency=medium

  [ Brandon Schaefer ]
  * If we fail to find the host path remove the session path since it would
    have been created with the socket.

  [ Chris Townsend ]
  * Only set the LXC log file when the container is about to start.
    (LP: #1596020)
  * Add a new ContainersConfig Python class for managing all things
    ContainersConfig.json.
  * Refactor host information into a new HostInfo class.
  * Check if the LXC container is defined before trying to start it.

  [ Larry Price ]
  * Remove dependency on DISPLAY variable and use random string to generate
    session socket path.
  * Prevent showing multiple error dialogs when adding archive fails.
    (LP: #1594957)
  * Only generate translations when manually running `make translations`.
  * Ensure /usr/games is in PATH before launching applications. (LP: #1598227)
  * Make error details selectable and add clipboard button. (LP: #1598786)
  * Use dialog instead of ActionSelectionPopover to address focusing issues
    when installing packages.
  * Verify host kernel has lxc support. (LP: #1599193)
  * Set DEBIAN_FRONTEND directly in environment for chroot containers.
    (LP: #1599246)

 -- Christopher Townsend <email address hidden> Thu, 07 Jul 2016 20:17:22 +0000

Changed in libertine (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.