Ubuntu
dh-python package

incorrect parsing of != dependency versions

Bug #1581065 reported by James Page
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
dh-python (Ubuntu)
Fix Released
High
Unassigned
Wily
Fix Released
High
Unassigned
Xenial
Fix Released
High
Unassigned
Yakkety
Fix Released
High
Unassigned

Bug Description

[Impact]
dh-python incorrectly used != version operators in some cases, resulting in failed package builds; this impacts a number of stable updates for Xenial which blacklist a specific cryptography version.

[Test Case]
Build stable release of glance/keystone/nova for xenial/mitaka (parse problem in original bug report)

[Regression Potential]
Testing OK in yakkety; change is minimal and ensures != operator is ignored when detected.

[Original Bug Report]
Some updates to requirements for openstack projects (glance and keystone specifically) is causing dh-python to incorrectly generate a != version dependency; this is the requires.txt entry:

 cryptography!=1.3.0,>=1.0

which causes (utimately):

dpkg-gencontrol: warning: can't parse dependency python-cryptography (!= 1.3.0)

from the generated dependency line:

"python-castellan, python-crypto (>= 2.6), python-cryptography (!= 1.3.0), python-debtcollector, python-eventlet, python-futurist, python-glance-store, python-httplib2, python-iso8601, python-jsonschema, python-keystoneauth1, python-keystoneclient, python-keystonemiddleware, python-migrate, python-monotonic, python-openssl, python-oslo.concurrency, python-oslo.config, python-oslo.context, python-oslo.db, python-oslo.i18n, python-oslo.log, python-oslo.messaging, python-oslo.middleware, python-oslo.policy, python-oslo.serialization, python-oslo.service, python-oslo.utils, python-osprofiler, python-paste, python-pastedeploy, python-pbr, python-prettytable, python-retrying, python-semantic-version, python-six (>= 1.9.0), python-sqlalchemy (>= 1.0~), python-sqlalchemy (<< 1.1), python-stevedore, python-taskflow, python-webob, python-wsme, python:any (<< 2.8), python:any (>= 2.6~), python:any (>= 2.7.5-5~), python:any (>= 2.7~),"

ProblemType: Bug
DistroRelease: Ubuntu 16.10
Package: dh-python 2.20151103ubuntu1
ProcVersionSignature: Ubuntu 4.4.0-22.39-generic 4.4.8
Uname: Linux 4.4.0-22-generic x86_64
NonfreeKernelModules: zfs zunicode zcommon znvpair zavl
ApportVersion: 2.20.1-0ubuntu3
Architecture: amd64
CurrentDesktop: Unity
Date: Thu May 12 15:15:36 2016
Dependencies:

EcryptfsInUse: Yes
InstallationDate: Installed on 2016-01-17 (115 days ago)
InstallationMedia: Ubuntu 16.04 LTS "Xenial Xerus" - Alpha amd64 (20160117)
PackageArchitecture: all
SourcePackage: dh-python
UpgradeStatus: No upgrade log present (probably fresh install)

See original description
Revision history for this message
James Page (james-page) wrote :
Revision history for this message
James Page (james-page) wrote :
Revision history for this message
James Page (james-page) wrote :

This is odd because its not the only dependency in this type for format.

Revision history for this message
James Page (james-page) wrote :

This fix works:

https://launchpadlibrarian.net/259176990/dh-python_2.20151103ubuntu1_2.20151103ubuntu2~ubuntu16.10.1~ppa201605121523.diff.gz

but not entirely sure why this gets picked up in the first place.

James Page (james-page)
Changed in dh-python (Ubuntu Xenial):
importance: Undecided → High
Changed in dh-python (Ubuntu Yakkety):
importance: Undecided → High
Changed in dh-python (Ubuntu Xenial):
status: New → Triaged
Changed in dh-python (Ubuntu Yakkety):
status: New → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dh-python - 2.20151103ubuntu2

---------------
dh-python (2.20151103ubuntu2) yakkety; urgency=medium

  * dhpython/pydist.py: Ensure that != dependency versions are ignored
    (LP: #1581065).

 -- James Page <email address hidden> Thu, 12 May 2016 17:04:43 +0100

Changed in dh-python (Ubuntu Yakkety):
status: Triaged → Fix Released
James Page (james-page)
description: updated
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Hello James, or anyone else affected,

Accepted dh-python into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/dh-python/2.20151103ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in dh-python (Ubuntu Xenial):
status: Triaged → Fix Committed
tags: added: verification-needed
Revision history for this message
James Page (james-page) wrote :

Our newton testing PPA is running with proposed enabled and builds are coming through just fine:

https://launchpad.net/~openstack-ubuntu-testing/+archive/ubuntu/newton/+packages

Note that we did have a wedge in the PPA to workaround this problem; I checked the build logs for the last heat builds and confirmed they are using the version from xenial-proposed.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dh-python - 2.20151103ubuntu1.1

---------------
dh-python (2.20151103ubuntu1.1) xenial; urgency=medium

  * dhpython/pydist.py: Ensure that != dependency versions are ignored
    (LP: #1581065).

 -- James Page <email address hidden> Thu, 12 May 2016 17:04:43 +0100

Changed in dh-python (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for dh-python has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Corey Bryant (corey.bryant)
Changed in dh-python (Ubuntu Wily):
importance: Undecided → High
Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello James, or anyone else affected,

Accepted dh-python into wily-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/dh-python/2.20150826ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in dh-python (Ubuntu Wily):
status: New → Fix Committed
tags: removed: verification-done
tags: added: verification-needed
Corey Bryant (corey.bryant)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Corey Bryant (corey.bryant) wrote :

Hello Steve,

I've marked this as verification-done after successfully testing dh-python 2.20150826ubuntu1.1
.

Thanks!

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dh-python - 2.20150826ubuntu1.1

---------------
dh-python (2.20150826ubuntu1.1) wily; urgency=medium

  * dhpython/pydist.py: Ensure that != dependency versions are ignored
    (LP: #1581065).

 -- Corey Bryant <email address hidden> Mon, 20 Jun 2016 11:01:05 -0400

Changed in dh-python (Ubuntu Wily):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.