Need API to allow shell to choose custom OOM killer scores
Bug #1579799 reported by
Gerry Boland
This bug affects 9 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
Wishlist
|
Unassigned | ||
| ubuntu-app-launch (Ubuntu) |
Fix Released
|
Wishlist
|
Ted Gould | ||
Bug Description
The desire is to tune Xapps to be killed last in life cycle preferences, since they are unable to restore their state.
Also shell needs to be able to set custom OOM scores for the application spawning a trusted prompt helper, as well as that trust helper.
Instead of UAL trying to deduce what the shell is doing and decide OOM scores, it would be better to allow the shell to decide the weighting applied.
Related branches
lp:~ted/ubuntu-app-launch/lp1579799-oom-adjust
- dobey (community): Abstain
- unity-api-1-bot: Needs Fixing (continuous-integration)
- Charles Kerr (community): Approve
- PS Jenkins bot: Pending (continuous-integration) requested
-
Diff: 3445 lines (+1737/-729)29 files modifiedCMakeLists.txt (+11/-3)
debian/control (+5/-5)
debian/libubuntu-app-launch3.install (+1/-1)
debian/libubuntu-app-launch3.shlibs (+1/-1)
helpers-shared.c (+1/-1)
helpers.c (+17/-8)
libubuntu-app-launch/CMakeLists.txt (+5/-1)
libubuntu-app-launch/app-info.h (+7/-1)
libubuntu-app-launch/application-impl-base.cpp (+463/-111)
libubuntu-app-launch/application-impl-base.h (+52/-5)
libubuntu-app-launch/application-impl-click.cpp (+30/-0)
libubuntu-app-launch/application-impl-click.h (+4/-0)
libubuntu-app-launch/application-impl-legacy.cpp (+37/-1)
libubuntu-app-launch/application-impl-legacy.h (+7/-0)
libubuntu-app-launch/application-impl-libertine.cpp (+28/-0)
libubuntu-app-launch/application-impl-libertine.h (+5/-0)
libubuntu-app-launch/application.cpp (+39/-0)
libubuntu-app-launch/application.h (+13/-0)
libubuntu-app-launch/libubuntu-app-launch.map (+1/-0)
libubuntu-app-launch/oom.h (+54/-0)
libubuntu-app-launch/registry-impl.cpp (+318/-0)
libubuntu-app-launch/registry-impl.h (+21/-2)
libubuntu-app-launch/registry.cpp (+61/-21)
libubuntu-app-launch/second-exec-core.c (+3/-10)
libubuntu-app-launch/second-exec-core.h (+2/-2)
libubuntu-app-launch/ubuntu-app-launch.cpp (+129/-462)
tests/CMakeLists.txt (+1/-0)
tests/libual-cpp-test.cc (+357/-74)
tests/libual-test.cc (+64/-20)
Revision history for this message
| Ted Gould (ted) wrote | #1 |
| Changed in ubuntu-app-launch (Ubuntu): | |
| importance: | Undecided → Wishlist |
| status: | New → Incomplete |
| assignee: | nobody → Ted Gould (ted) |
Revision history for this message
| Ted Gould (ted) wrote | #2 |
| Changed in ubuntu-app-launch (Ubuntu): | |
| status: | Incomplete → Confirmed |
| Changed in ubuntu-app-launch (Ubuntu): | |
| status: | Confirmed → In Progress |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #3 |
| Changed in ubuntu-app-launch (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | New → Fix Committed |
| importance: | Undecided → Wishlist |
| milestone: | none → 13 |
Revision history for this message
| Gerry Boland (gerboland) wrote | #4 |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Today UAL has basically three states for applications, on, off and paused. There are then OOM scores associated with those states. And it seems that this is requesting more states. But I'm not sure I understand. For instance, for X11 apps they're never paused, so their OOM score stays the same as the focused app, do we need a state where the focused app is killed before an X11 application? I also don't believe that applications that have a trusted overlay are paused, so I'm not sure how the scoring would work there either.
So what are the states that you see applications being in, and what would their scores be relative to one another?