Ubuntu
ubuntu-release-upgrader package

sleep inhibitor uses deprecated interface

Bug #1566141 reported by Tim Lunn
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
ubuntu-release-upgrader (Ubuntu)
Fix Released
High
Brian Murray
update-manager (Ubuntu)
Fix Released
High
Brian Murray

Bug Description

The code that generates the sleep/suspend use org.freedesktop.PowerManagement which is deprecated and the only remaining implementation appears to be in KDE. So it won't be working on other DE's.

This should be using logind now.

ProblemType: Bug
DistroRelease: Ubuntu 16.04
Package: ubuntu-release-upgrader-core 1:16.04.8
ProcVersionSignature: Ubuntu 4.4.0-16.32-generic 4.4.6
Uname: Linux 4.4.0-16-generic x86_64
NonfreeKernelModules: nvidia_uvm nvidia_drm nvidia_modeset nvidia
ApportVersion: 2.20.1-0ubuntu1
Architecture: amd64
CrashDB: ubuntu
CurrentDesktop: GNOME
Date: Tue Apr 5 14:46:44 2016
InstallationDate: Installed on 2012-09-23 (1290 days ago)
InstallationMedia: Ubuntu GNOME Remix 12.10 "Quantal Quetzal" - Alpha amd64(20120922)
PackageArchitecture: all
SourcePackage: ubuntu-release-upgrader
Symptom: ubuntu-release-upgrader
UpgradeStatus: No upgrade log present (probably fresh install)
VarLogDistupgradeTermlog:

Related branches

lp:~darkxst/ubuntu-release-upgrader/logind
Ubuntu Core Development Team: Pending requested
Diff: 107 lines (+14/-12)
4 files modified
DistUpgrade/DistUpgradeController.py (+5/-1)
DistUpgrade/DistUpgradeFetcher.py (+1/-5)
DistUpgrade/DistUpgradeFetcherKDE.py (+0/-5)
debian/changelog (+8/-1)
lp:~darkxst/update-manager/logind
Ubuntu Core Development Team: Pending requested
Diff: 107 lines (+28/-27)
3 files modified
UpdateManager/Core/utils.py (+20/-20)
UpdateManager/backend/__init__.py (+2/-7)
debian/changelog (+6/-0)
lp:update-manager
lp:ubuntu-release-upgrader
Revision history for this message
Tim Lunn (darkxst) wrote :
Sebastien Bacher (seb128)
Changed in ubuntu-release-upgrader (Ubuntu):
assignee: nobody → Canonical Foundations Team (canonical-foundations)
importance: Undecided → High
Revision history for this message
Tim Lunn (darkxst) wrote :

I patched this, then realised the code actually comes from update-manager. I will finish up the patches in the next few days

Ubuntu Foundations Team Bug Bot (crichton)
tags: added: patch
Mathew Hodson (mhodson)
Changed in update-manager (Ubuntu):
importance: Undecided → High
Brian Murray (brian-murray)
Changed in update-manager (Ubuntu):
status: New → In Progress
assignee: nobody → Brian Murray (brian-murray)
Steve Langasek (vorlon)
Changed in ubuntu-release-upgrader (Ubuntu):
assignee: Canonical Foundations Team (canonical-foundations) → Brian Murray (brian-murray)
Brian Murray (brian-murray)
Changed in ubuntu-release-upgrader (Ubuntu):
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package update-manager - 1:16.04.2

---------------
update-manager (1:16.04.2) xenial; urgency=medium

  [ Tim Lunn ]
  * UpdateManage/Core/utils.py: Update to use logind inhibitors (LP: #1566141)

 -- Brian Murray <email address hidden> Thu, 07 Apr 2016 11:06:40 -0700

Changed in update-manager (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-release-upgrader - 1:16.04.10

---------------
ubuntu-release-upgrader (1:16.04.10) xenial; urgency=medium

  [ Tim Lunn ]
  * DistUpgrade/DistUpgradeController.py: set a logind sleep inhibitor
  * DistUpgrade/DistUpgradeFetcher{KDE}.py: remove calls to inhibit_sleep
    logind inhibitor will be released when os.exec is called as we lose
    reference on the fd (LP: #1566141)

  [ Brian Murray ]
  * DistUpgrade/DistUpgradeViewKDE.py: Really fix call to showConffile.
    (LP: #1509655)

 -- Brian Murray <email address hidden> Thu, 07 Apr 2016 15:26:25 -0700

Changed in ubuntu-release-upgrader (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.