Ubuntu
qtbase-opensource-src package

Multiple calls to finished/error signals of QNAM object

Bug #1564142 reported by dobey
46
This bug affects 8 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
John McAleely
Canonical System Image 11 "OTA11"
qtbase-opensource-src (Ubuntu)
Fix Released
High
Lorn Potter
qtbase-opensource-src (Ubuntu RTM)
Fix Released
Undecided
Unassigned

Bug Description

Recently I've noticed that some odd issues where the QNetworkAccessManager API is being used to communicate with REST APIs in some of our code. I've tracked this down as far as it seems that the finished/error signals seem to get called multiple times, sometimes.

This has resulted in bug #1552546 in ubuntuone-credentials. When logging in, if you enter the wrong password, it should show you an error message stating that either the email or password was incorrect. However, a generic network error message is being shown instead. When examining the logs, it seems that the correct error is sent, and then an invalid call to the finished signal was made, and a second error sent, resulting in the generic network error displayed to the user. This same issue happens when the 2FA code is required as well, and a network error message is displayed, rather than the 2FA required message.

Tags: patch
Lorn Potter (lorn-potter)
Changed in qtbase-opensource-src (Ubuntu):
assignee: nobody → Lorn Potter (lorn-potter)
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in qtbase-opensource-src (Ubuntu):
status: New → Confirmed
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
assignee: nobody → John McAleely (john.mcaleely)
importance: Undecided → High
milestone: none → backlog
status: New → Confirmed
Revision history for this message
dobey (dobey) wrote :

Can we perhaps get this moved up in priority, as it is causing a rather annoying issue in the U1 account plug-in on the phone?

Revision history for this message
Lorn Potter (lorn-potter) wrote :

I made a simple test app that uses QNetworkRequest, and I am not seeing duplicated finished signals being called when there are no errors.

If I use a non existent url, I am seeing duplicated QNetworkAccessManager::finished signals being called, but no duplicated signals from QNetworkReply.

Revision history for this message
Lorn Potter (lorn-potter) wrote :

ok. it seems the last qnam patch does this. Need to remember why I added that one offending line.
Will test against the bug at #1552546

Revision history for this message
Lorn Potter (lorn-potter) wrote :

Patch for fixing this.
Partially reverts qnam-ubuntu-fix6.patch

Lorn Potter (lorn-potter)
Changed in qtbase-opensource-src (Ubuntu):
importance: Undecided → High
John McAleely (john.mcaleely)
Changed in canonical-devices-system-image:
milestone: backlog → 11
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "fix-duplicate-qnam-finished.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

The patch is building now both for vivid and slightly rebased for xenial at https://requests.ci-train.ubuntu.com/#/ticket/1231 (silo 46).

The armhf builds will be ready in roughly 4 hours from now.

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

(please test from there and report back. I will finish the silo gles packages after that.)

Revision history for this message
dobey (dobey) wrote :

The silo resolved the issue for me that was occurring in ubuntuone-credentials as a result of this bug.

dobey (dobey)
Changed in qtbase-opensource-src (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Selene ToyKeeper (toykeeper) wrote :

Thanks, this appears to fix the incorrect U1 login errors.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

This bug was fixed in the package qtbase-opensource-src 5.4.1+dfsg-2ubuntu11~vivid9 in https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/stable-phone-overlay

---------------

qtbase-opensource-src (5.4.1+dfsg-2ubuntu11~vivid9) vivid; urgency=medium

  * debian/patches/fix-duplicate-qnam-finished.patch:
    - Fix multiple calls to signals of QNAM object (LP: #1564142)

 -- Timo Jyrinki <email address hidden> Thu, 07 Apr 2016 08:59:42 +0000

Changed in qtbase-opensource-src (Ubuntu RTM):
status: New → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package qtbase-opensource-src - 5.5.1+dfsg-16ubuntu7

---------------
qtbase-opensource-src (5.5.1+dfsg-16ubuntu7) xenial; urgency=medium

  [ Dmitry Shachnev ]
  * Backport upstream change from 5.6 branch to implement better detection
    of indicator-application based trays. Refs LP: #1546328.
  * Update symbols files for symbols added in the latest patches.

  [ Timo Jyrinki ]
  * debian/patches/fix-duplicate-qnam-finished.patch:
    - Fix multiple calls to signals of QNAM object (LP: #1564142)

 -- Dmitry Shachnev <email address hidden> Tue, 12 Apr 2016 19:17:34 +0300

Changed in qtbase-opensource-src (Ubuntu):
status: In Progress → Fix Released
Timo Jyrinki (timo-jyrinki)
Changed in canonical-devices-system-image:
status: Confirmed → Fix Committed
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.