resquashfs test fails if snap has symlinks

Fix submitted to the upstream squashfs project:

 https://sourceforge.net/p/squashfs/mailman/message/36140758/

Marking the click-reviewers-tools task as invalid since the bug fix is in squashfs-tools and there's no changes needed for click-reviewers-tools.

I'm attaching a squashfs image containing a symlink named "link" and a regular file named "file". The symlink has a timestamp of "25 Aug 91 20:57:08 GMT".

This bug was fixed in the package squashfs-tools - 1:4.3-4ubuntu2

---------------
squashfs-tools (1:4.3-4ubuntu2) bionic; urgency=medium

  * debian/patches/0005-add-fstime.patch: Fix -Wint-conversion warning by
    initializing the time_t variable with (time_t)-1 instead of NULL
  * debian/patches/0008-unsquashfs-preserve-symlink-times.patch: Preserve
    atime and mtime of symlink inodes in unsquashfs rather than using the
    current time (LP: #1555305)

 -- Tyler Hicks <email address hidden> Mon, 11 Dec 2017 20:56:21 +0000

Hello Jamie, or anyone else affected,

Accepted squashfs-tools into artful-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/squashfs-tools/1:4.3-4ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-artful to verification-done-artful. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-artful. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hello Jamie, or anyone else affected,

Accepted squashfs-tools into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/squashfs-tools/1:4.3-3ubuntu2.17.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-zesty to verification-done-zesty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-zesty. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hello Jamie, or anyone else affected,

Accepted squashfs-tools into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/squashfs-tools/1:4.3-3ubuntu2.16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hello Jamie, or anyone else affected,

Accepted squashfs-tools into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/squashfs-tools/1:4.2+20130409-2ubuntu0.14.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-trusty to verification-done-trusty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-trusty. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

I've successfully performed the test described in the [Test Case] section on artful, zesty, xenial, and trusty in both amd64 and i386 VMs. I see that there are some autopkgtest failures/errors so I'll investigate those before marking these as verification-done.

* Failing Xenial snapd tests
- autopkgtest:ubuntu-16.04-amd64:tests/main/completion fails with and without the squashfs-tools in xenial-proposed
- autopkgtest:ubuntu-16.04-amd64:tests/main/searching is attempting to find the "cassandra" snap in the database section but I can confirm that it isn't listed in the database section of the store
- s390x: No tests are ever ran due to the tests requiring "machine-level isolation" but that not being available on s390x. However, snapd s390x test runs have been hitting an error for about the last month.

* Failing Xenial snapcraft tests
- test_catkin_part_builds_after_python_part() is failing on all snapcraft test runs

From what I can tell, the snapd and snapcraft test failures on Xenial are not due to the squashfs-tools changes.

The failing Trusty snapd tests are marked as "Always failed" and are unrelated to the squashfs-tools changes:

  fatal: unable to access 'https://github.com/kardianos/govendor/': Failed to connect to github.com port 443: Connection timed out

* Failing Zesty and Artful snapd tests
- autopkgtest:ubuntu-16.04-amd64:tests/main/completion fails with and without the squashfs-tools in xenial-proposed
- autopkgtest:ubuntu-16.04-amd64:tests/main/searching is attempting to find the "cassandra" snap in the database section but I can confirm that it isn't listed in the database section of the store
- s390x: No tests are ever ran due to the tests requiring "machine-level isolation" but that not being available on s390x. However, snapd s390x test runs have been hitting an error for about the last month.

* Failing Zesty and Artful snapcraft tests
- These have all been failing recently

* Failed Zesty and Artful lxd tests on s390x
- These tests have only ever passed with "SKIP Test requires machine-level isolation but testbed does not provide that" but they've recently started running and failing every run

From what I can tell, the snapd, snapcraft, and lxd test failures on Zesty and Artful are not due to the squashfs-tools changes.

This bug was fixed in the package squashfs-tools - 1:4.3-4ubuntu1.1

---------------
squashfs-tools (1:4.3-4ubuntu1.1) artful; urgency=medium

  * debian/patches/0008-unsquashfs-preserve-symlink-times.patch: Preserve
    atime and mtime of symlink inodes in unsquashfs rather than using the
    current time (LP: #1555305)

 -- Tyler Hicks <email address hidden> Mon, 11 Dec 2017 20:51:14 +0000

The verification of the Stable Release Update for squashfs-tools has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package squashfs-tools - 1:4.3-3ubuntu2.17.04.1

---------------
squashfs-tools (1:4.3-3ubuntu2.17.04.1) zesty; urgency=medium

  * debian/patches/0007-unsquashfs-preserve-symlink-times.patch: Preserve
    atime and mtime of symlink inodes in unsquashfs rather than using the
    current time (LP: #1555305)

 -- Tyler Hicks <email address hidden> Mon, 11 Dec 2017 21:02:54 +0000

This bug was fixed in the package squashfs-tools - 1:4.3-3ubuntu2.16.04.1

---------------
squashfs-tools (1:4.3-3ubuntu2.16.04.1) xenial; urgency=medium

  * debian/patches/0007-unsquashfs-preserve-symlink-times.patch: Preserve
    atime and mtime of symlink inodes in unsquashfs rather than using the
    current time (LP: #1555305)

 -- Tyler Hicks <email address hidden> Mon, 11 Dec 2017 21:02:07 +0000

This bug was fixed in the package squashfs-tools - 1:4.2+20130409-2ubuntu0.14.04.2

---------------
squashfs-tools (1:4.2+20130409-2ubuntu0.14.04.2) trusty; urgency=medium

  * debian/patches/0003-unsquashfs-preserve-symlink-times.patch: Preserve
    atime and mtime of symlink inodes in unsquashfs rather than using the
    current time (LP: #1555305)

 -- Tyler Hicks <email address hidden> Mon, 11 Dec 2017 21:06:30 +0000