OpenLP

Songs with linked audio cause traceback

Bug #1533280 reported by Azaziah
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenLP
Fix Released
Medium
Tomas Groth
OpenLP 2.3.3

Bug Description

Trunk revision n. 2605 / Win 64 bit python

If song has linked audio, it triggers the following
traceback instead of going live:

Traceback (most recent call last):
  File "E:\bzr\openlp\trunk\openlp\core\lib\mediamanageritem.py", line 459, in on_double_clicked
    self.on_live_click()
  File "E:\bzr\openlp\trunk\openlp\core\lib\mediamanageritem.py", line 500, in on_live_click
    self.go_live()
  File "E:\bzr\openlp\trunk\openlp\core\lib\mediamanageritem.py", line 527, in go_live
    self.live_controller.add_service_item(service_item)
  File "E:\bzr\openlp\trunk\openlp\core\ui\slidecontroller.py", line 779, in add_service_item
    self._process_item(item, slide_no)
  File "E:\bzr\openlp\trunk\openlp\core\ui\slidecontroller.py", line 849, in _process_item
    self.display.audio_player.add_to_playlist(self.service_item.background_audio)
  File "E:\bzr\openlp\trunk\openlp\core\ui\maindisplay.py", line 646, in add_to_playlist
    self.playlist.addMedia(QtCore.QUrl(file_name))
TypeError: arguments did not match any overloaded call:
  QMediaPlaylist.addMedia(QMediaContent): argument 1 has unexpected type 'QUrl'
  QMediaPlaylist.addMedia(list-of-QMediaContent): argument 1 has unexpected type 'QUrl'

See original description

Related branches

lp:~tomasgroth/openlp/23bugfixes
Tomas Groth: Approve
Tim Bentley: Approve
Diff: 291 lines (+96/-24)
9 files modified
openlp/core/common/uistrings.py (+2/-2)
openlp/core/lib/renderer.py (+3/-3)
openlp/core/ui/maindisplay.py (+9/-7)
openlp/core/ui/slidecontroller.py (+5/-2)
openlp/plugins/songs/forms/editsongform.py (+2/-0)
openlp/plugins/songs/lib/importers/opensong.py (+1/-0)
tests/functional/openlp_core_lib/test_renderer.py (+16/-10)
tests/functional/openlp_plugins/songs/test_opensongimport.py (+2/-0)
tests/resources/opensongsongs/Amazing Grace2 (+56/-0)
lp:openlp
Azaziah (suutari-olli)
description: updated
Revision history for this message
Wolodja Moros (wolodja-moros) wrote :

affects also Linux Debian Jessie 64 Bit

Traceback (most recent call last):
  File "/usr/share/openlp/openlp/core/ui/servicemanager.py", line 1466, in on_make_live
    self.make_live()
  File "/usr/share/openlp/openlp/core/ui/servicemanager.py", line 1482, in make_live
    self.live_controller.add_service_manager_item(self.service_items[item]['service_item'], child)
  File "/usr/share/openlp/openlp/core/ui/slidecontroller.py", line 808, in add_service_manager_item
    self._process_item(item, slide_num)
  File "/usr/share/openlp/openlp/core/ui/slidecontroller.py", line 849, in _process_item
    self.display.audio_player.add_to_playlist(self.service_item.background_audio)
  File "/usr/share/openlp/openlp/core/ui/maindisplay.py", line 646, in add_to_playlist
    self.playlist.addMedia(QtCore.QUrl(file_name))
TypeError: arguments did not match any overloaded call:
  QMediaPlaylist.addMedia(QMediaContent): argument 1 has unexpected type 'QUrl'
  QMediaPlaylist.addMedia(list-of-QMediaContent): argument 1 has unexpected type 'QUrl'

Tomas Groth (tomasgroth)
Changed in openlp:
assignee: nobody → Tomas Groth (tomasgroth)
importance: Undecided → Medium
status: New → In Progress
Tim Bentley (trb143)
Changed in openlp:
milestone: none → 2.4.0
status: In Progress → Fix Committed
Tim Bentley (trb143)
Changed in openlp:
milestone: 2.4.0 → 2.3.3
Tim Bentley (trb143)
Changed in openlp:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.