QML function trigger() with no argument doesn't override ActionItem.trigger
Bug #1524234 reported by
Cris Dywan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
Critical
|
Zoltan Balogh | ||
ubuntu-ui-toolkit (Ubuntu RTM) |
Fix Released
|
Critical
|
Zsombor Egri |
Bug Description
In QML it's only natural to declare
function trigger() { }
on an ActionItem (derived item) and expect it to override the trigger slot.
This doesn't work - sometimes it works if the function is declared with an argument, other times not at all.
Related branches
lp:~zsombi/ubuntu-ui-toolkit/properTriggerCall
- Cris Dywan: Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 440 lines (+184/-32)13 files modifiedsrc/Ubuntu/Components/plugin/ucabstractbutton.cpp (+7/-3)
src/Ubuntu/Components/plugin/ucaction.cpp (+1/-1)
src/Ubuntu/Components/plugin/ucaction.h (+22/-0)
src/Ubuntu/Components/plugin/ucactionitem.cpp (+8/-14)
src/Ubuntu/Components/plugin/ucactionitem.h (+1/-0)
src/Ubuntu/Components/plugin/ucactionitem_p.h (+1/-3)
src/Ubuntu/Components/plugin/ucbottomedgehint.cpp (+2/-1)
src/Ubuntu/Components/plugin/uclistitem.cpp (+1/-1)
tests/unit/tst_components/tst_action.qml (+32/-5)
tests/unit_x11/tst_bottomedge/OverriddenHintTrigger.qml (+45/-0)
tests/unit_x11/tst_bottomedge/tst_bottomedge.cpp (+16/-0)
tests/unit_x11/tst_bottomedge/tst_bottomedge.pro (+2/-1)
tests/unit_x11/tst_components/tst_abstractbutton13.qml (+46/-3)
lp:~zsombi/ubuntu-ui-toolkit/iseeprivates
- Cris Dywan: Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 1523 lines (+580/-310)16 files modifiedsrc/Ubuntu/Components/plugin/plugin.pri (+3/-0)
src/Ubuntu/Components/plugin/ucabstractbutton.cpp (+76/-38)
src/Ubuntu/Components/plugin/ucabstractbutton.h (+9/-11)
src/Ubuntu/Components/plugin/ucabstractbutton_p.h (+50/-0)
src/Ubuntu/Components/plugin/ucaction.h (+1/-0)
src/Ubuntu/Components/plugin/ucactionitem.cpp (+162/-125)
src/Ubuntu/Components/plugin/ucactionitem.h (+8/-23)
src/Ubuntu/Components/plugin/ucactionitem_p.h (+63/-0)
src/Ubuntu/Components/plugin/ucbottomedge.cpp (+13/-13)
src/Ubuntu/Components/plugin/ucbottomedge.h (+0/-1)
src/Ubuntu/Components/plugin/ucbottomedge_p.h (+2/-0)
src/Ubuntu/Components/plugin/ucbottomedgehint.cpp (+130/-82)
src/Ubuntu/Components/plugin/ucbottomedgehint.h (+9/-14)
src/Ubuntu/Components/plugin/ucbottomedgehint_p.h (+46/-0)
src/Ubuntu/Components/plugin/ucstyleditembase.cpp (+7/-2)
src/Ubuntu/Components/plugin/ucstyleditembase_p.h (+1/-1)
lp:~zsombi/ubuntu-ui-toolkit/switchAndCheckboxFix
- Cris Dywan (community): Approve
- Zoltan Balogh: Pending requested
-
Diff: 168 lines (+98/-13)4 files modifiedsrc/Ubuntu/Components/plugin/ucabstractbutton.cpp (+16/-12)
src/Ubuntu/Components/plugin/ucabstractbutton.h (+1/-1)
src/Ubuntu/Components/plugin/ucabstractbutton_p.h (+1/-0)
tests/unit_x11/tst_components/tst_toggles.qml (+80/-0)
Changed in canonical-devices-system-image: | |
milestone: | none → ww02-2016 |
assignee: | nobody → Zoltan Balogh (bzoltan) |
importance: | Undecided → Critical |
Changed in canonical-devices-system-image: | |
status: | New → In Progress |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | In Progress → Fix Committed |
affects: | ubuntu-ui-toolkit (Ubuntu) → ubuntu-ui-toolkit (Ubuntu RTM) |
Changed in canonical-devices-system-image: | |
status: | In Progress → Fix Committed |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This si valid also on Action itself.