Ubuntu
bloboats package

Missing menu icon

Bug #151939 reported by Heikki Mäntysaari
4
Affects Status Importance Assigned to Milestone
bloboats (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Binary package hint: bloboats

Bloboats doesn't have a menu icon because there is no "Icon=bloboats"-line in bloboats.desktop.

Related branches

lp:ubuntu/karmic/bloboats
Revision history for this message
Heikki Mäntysaari (heikki-mantysaari) wrote :

Debdiff to fix this bug.

Changed in bloboats:
assignee: nobody → heikkim
Heikki Mäntysaari (heikki-mantysaari)
Changed in bloboats:
assignee: heikkim → nobody
status: New → Confirmed
Revision history for this message
Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount) wrote :

Thank you for your work.

The changelog entry is not ok I think, there should be an empty line between the first one and the second one.

bloboats (1.0.1.dsfg-1ubuntu2) gutsy; urgency=low
---> here
  * Add menu icon in bloboats.desktop

Please consider also to add (LP: #151939) next to * Add menu icon in bloboats.desktop .

Revision history for this message
Heikki Mäntysaari (heikki-mantysaari) wrote :

Thanks for you help.

This debdiff should be ok.

Changed in bloboats:
status: Confirmed → In Progress
Revision history for this message
Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount) wrote :

There is another strange thing. The patch does not apply cleanly because it compares files that are not in the correct directory. Look at these lines of the patch

diff -Nru /tmp/KgheN5I4BG/bloboats-1.0.1.dsfg/debian/bloboats.desktop /tmp/qlIuxq1H6o/bloboats-1.0.1.dsfg/debian/bloboats.desktop
--- /tmp/KgheN5I4BG/bloboats-1.0.1.dsfg/debian/bloboats.desktop 2007-10-14 15:08:52.000000000 +0300
+++ /tmp/qlIuxq1H6o/bloboats-1.0.1.dsfg/debian/bloboats.desktop 2007-10-14 15:08:52.000000000 +0300

I think they should be like this

diff -Nru bloboats-1.0.1.dsfg/debian/bloboats.desktop bloboats-1.0.1.dsfg/debian/bloboats.desktop
--- /bloboats-1.0.1.dsfg/debian/bloboats.desktop 2007-10-14 15:08:52.000000000 +0300
+++ /bloboats-1.0.1.dsfg/debian/bloboats.desktop 2007-10-14 15:08:52.000000000 +0300

Does the debdiff command return some output ?

Anyway, thanks again for your work :)

Revision history for this message
Heikki Mäntysaari (heikki-mantysaari) wrote :

I installed interdiff-package and now the debdiff seems to be better.

Revision history for this message
Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount) wrote :

Now the patch applies cleanly, the package builds correctly and it fixes the bug report. Try to subscripe u-u-s, maybe they upload this in a while.

Revision history for this message
Heikki Mäntysaari (heikki-mantysaari) wrote :

Done, thanks again for your help.

Revision history for this message
Andrea Veri (av) wrote :

1) release is still set to gutsy, need to be hardy
2) the syntax you used for closing the bug with the LP feature is wrong, should be (LP: #bugid)

Anyway I've fixed them for you, tested the package and uploaded the package. Thanks for your contribution to Ubuntu.

Revision history for this message
Heikki Mäntysaari (heikki-mantysaari) wrote :

bloboats (1.0.1.dsfg-1ubuntu2) hardy; urgency=low

  * Added menu icon in bloboats.desktop (LP: #151939)

 -- Heikki Maentysaari <email address hidden> Fri, 12 Oct 2007 09:27:23 -0300

Changed in bloboats:
status: Confirmed → Fix Released
Andrea Veri (av)
Changed in bloboats:
importance: Undecided → Wishlist
status: In Progress → Confirmed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.