has no "DisplayVersion" in uninstaller reg key
Bug #1488081 reported by
TheBigBear
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenLP |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Because it has no "DisplayVersion" set in the uninstaller registry key, the windows add/remove cannot show a version number and it shows as blank.
This is a issue for any config management software that wants to know what version of this software is installed.
It is also easily fixed by adding the "AppVersion" value to the installer script file.
I will work on a patch and submit a merge request sometime soon. (hopefully still today - after I tested it here first and know that it works)
Related branches
lp:~urs-rau-k/openlp/packaging_add-windows-ver-no
- Stevan Pettit (community): Approve
- Raoul Snyman: Approve
- Tim Bentley: Approve
- TheBigBear (community): Approve
-
Diff: 29 lines (+4/-1)1 file modifiedwindows/OpenLP-2.0.iss.default (+4/-1)
description: | updated |
Changed in openlp: | |
milestone: | none → 2.1.6 |
status: | New → Fix Committed |
Changed in openlp: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
My changes are: OpenLP- 2.0.iss. default' OpenLP- 2.0.iss. default 2014-10-27 00:08:27 +0000 OpenLP- 2.0.iss. default 2015-08-24 17:45:30 +0000
bzr diff -r-2..
=== modified file 'windows/
--- windows/
+++ windows/
@@ -3,6 +3,7 @@
#define AppName "OpenLP" version) s" version) s" openlp. org/" {{AA7699FA- B2D2-43F4- 8A70-D497D03C94 85} {#AppVerName} {cm:NameAndVers ion,{#AppName} ,{#AppVersion} } {#AppVersion} {#AppPublisher} L={#AppURL} {#AppURL} lzma/Max on=true OpenLP. ico sion={# AppVersion} e=WizImageBig. bmp geFile= WizImageSmall. bmp tions=true
#define AppVerName "OpenLP %(display_
+#define AppVersion "%(display_
#define AppPublisher "OpenLP Developers"
#define AppURL "http://
#define AppExeName "OpenLP.exe"
@@ -18,7 +19,8 @@
; (To generate a new GUID, click Tools | Generate GUID inside the IDE.)
AppID=
AppName={#AppName}
-AppVerName=
+AppVerName=
+AppVersion=
AppPublisher=
AppPublisherUR
AppSupportURL=
@@ -32,6 +34,7 @@
Compression=
SolidCompressi
SetupIconFile=
+VersionInfoVer
WizardImageFil
WizardSmallIma
ChangesAssocia