Merge lp:~urs-rau-k/openlp/packaging_add-windows-ver-no into lp:openlp/packaging

[TheBigBear]

This adds the openLP version number into the windows uninstaller registry keys.
Inno setup does all the heavy lifting, all we had to do was tell the inno iss script the openLP version number.

[TheBigBear (urs-rau-k)]

3rd time lucky, I guess. ;-)

[TheBigBear (urs-rau-k)]

ElderP on freenode IRC said, he would build this using this changed inno iss setup file. So testing is underway, or may have already happened. BTW what is ElderP's reviewer name?
Blessings all

[TheBigBear (urs-rau-k)]

OK, ElderP on IRC (Stevan Pettit) left my a msg via iTwinkle that this change worked, and it correctly added the version number into the windows registry.

[TheBigBear (urs-rau-k)]

OK, ElderP on IRC (Stevan Pettit) left my a msg via iTwinkle that this change worked, and it correctly added the version number into the windows registry.
So this can be approved for merging.

review: Approve

[Tim Bentley (trb143)]

Looks OK but would like ElderP to approve as well

review: Approve

[Raoul Snyman (raoul-snyman)]

review: Approve

[Stevan Pettit (elderp-deactivatedaccount)]

Patch worked fine. Current version number was added to the registry.

review: Approve

=== modified file 'windows/OpenLP-2.0.iss.default'
--- windows/OpenLP-2.0.iss.default	2014-10-27 00:08:27 +0000
+++ windows/OpenLP-2.0.iss.default	2015-08-25 09:59:13 +0000
@@ -3,6 +3,7 @@
 
 #define AppName "OpenLP"
 #define AppVerName "OpenLP %(display_version)s"
+#define AppVersion "%(display_version)s"
 #define AppPublisher "OpenLP Developers"
 #define AppURL "http://openlp.org/"
 #define AppExeName "OpenLP.exe"
@@ -18,7 +19,8 @@
 ; (To generate a new GUID, click Tools | Generate GUID inside the IDE.)
 AppID={{AA7699FA-B2D2-43F4-8A70-D497D03C9485}
 AppName={#AppName}
-AppVerName={#AppVerName}
+AppVerName={cm:NameAndVersion,{#AppName},{#AppVersion}}
+AppVersion={#AppVersion}
 AppPublisher={#AppPublisher}
 AppPublisherURL={#AppURL}
 AppSupportURL={#AppURL}
@@ -32,6 +34,7 @@
 Compression=lzma/Max
 SolidCompression=true
 SetupIconFile=OpenLP.ico
+VersionInfoVersion={#AppVersion}
 WizardImageFile=WizImageBig.bmp
 WizardSmallImageFile=WizImageSmall.bmp
 ChangesAssociations=true