gallery-app requests thumbnail for same image multiple times
Bug #1485490 reported by
James Henstridge
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
High
|
Bill Filler | ||
| gallery-app (Ubuntu) |
Fix Released
|
High
|
James Henstridge | ||
| gallery-app (Ubuntu RTM) |
Fix Released
|
Undecided
|
Unassigned | ||
| thumbnailer (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
Bug Description
The gallery appends Date.now() to the end of the image://thumbnailer URI used to load photo thumbnails in order to avoid showing thumbnails for old versions of a file.
Unfortunately this means we never get any hits from the QML image cache, and the image needs to be reloaded more often than needed. Instead it should use a value for the "at" parameter that only changes when the file content changes.
Related branches
lp:~jamesh/gallery-app/thumbnail-mtime
- Arthur Mello (community): Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 176 lines (+30/-39)6 files modifiedrc/qml/AlbumViewer/AlbumInternals/FramePortrait.qml (+2/-18)
rc/qml/Components/MediaGrid.qml (+1/-10)
rc/qml/MediaViewer/MediaViewer.qml (+4/-1)
rc/qml/OrganicView/OrganicMediaList.qml (+1/-10)
src/media/media-source.cpp (+18/-0)
src/media/media-source.h (+4/-0)
| Changed in thumbnailer (Ubuntu): | |
| status: | New → Triaged |
| Changed in thumbnailer (Ubuntu): | |
| assignee: | nobody → James Henstridge (jamesh) |
| Changed in gallery-app (Ubuntu): | |
| assignee: | nobody → James Henstridge (jamesh) |
| Changed in thumbnailer (Ubuntu): | |
| assignee: | James Henstridge (jamesh) → nobody |
| Changed in gallery-app (Ubuntu): | |
| status: | New → In Progress |
| Changed in canonical-devices-system-image: | |
| assignee: | nobody → Bill Filler (bfiller) |
| status: | New → In Progress |
| milestone: | none → ww02-2016 |
| importance: | Undecided → High |
| Changed in gallery-app (Ubuntu): | |
| importance: | Undecided → High |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in gallery-app (Ubuntu): | |
| status: | In Progress → Fix Released |
Revision history for this message
| Timo Jyrinki (timo-jyrinki) wrote | #2 |
| Changed in gallery-app (Ubuntu RTM): | |
| status: | New → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | In Progress → Fix Committed |
| Changed in thumbnailer (Ubuntu): | |
| status: | Triaged → Invalid |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package gallery-app - 0.0.67+
---------------
gallery-app (0.0.67+
[ Arthur Mello ]
* Remove local copy of PhotoEditor and keep using only the Ubuntu
Extras one (LP: #1524973)
* Save imported files from content hub in a specific folder Use
created date to sort videos imported from content hub (LP: #1517655)
[ CI Train Bot ]
* Resync trunk.
[ James Henstridge ]
* Use the file's last modified date for the "at" parameter when
invoking the thumbnailer to avoid needlessly reloading thumbnails.
(LP: #1485490)
-- Bill Filler <email address hidden> Wed, 16 Dec 2015 22:01:50 +0000