Reflect the change for fwts attachment jobs to all test plans

I can't link my git branch here, please find the MR here:
https://code.launchpad.net/~cypressyew/plainbox-provider-canonical-certification/+git/plainbox-provider-canonical-certification/+ref/fix-fwts-hwe-attachment

I think the server provider might be affected as well, which need a fix in both server provider and the checkbox provider, waiting for reply now.

from my comments to Sam via email:
I do see both logs created:
ubuntu@polished-sleep:~/.cache/plainbox/sessions/pbox-_slgkv8k.session$ ll CHECKBOX_DATA/
total 160
drwxrwxr-x 2 ubuntu ubuntu 4096 Aug 24 18:35 ./
drwx------ 4 ubuntu ubuntu 4096 Aug 24 18:36 ../
-rw-r--r-- 1 root root 11900 Aug 24 18:35 fwts_results_hwe.log
-rw-r--r-- 1 root root 142670 Aug 24 18:35 fwts_results.log

for some reason, the changes made are splitting the tests into two logs:
ubuntu@polished-sleep:~/.cache/plainbox/sessions/pbox-_slgkv8k.session$ grep -i "Running tests" CHECKBOX_DATA/fwts_results_hwe.log
Running tests: apicedge.
Running tests: klog.
Running tests: mtrr.
Running tests: oops.
Running tests: uefibootpath.
Running tests: virt.
ubuntu@polished-sleep:~/.cache/plainbox/sessions/pbox-_slgkv8k.session$ grep -i "Running tests" CHECKBOX_DATA/fwts_results.log
Running tests: acpiinfo xenv xsdt wmi wdat waet uefi tpm2 tcpa stao srat spmi
Running tests: acpidump.
Running tests: acpitables.
Running tests: apicinstance.
Running tests: aspm.
Running tests: bios32.
Running tests: dmicheck.
Running tests: ebda.
Running tests: mpcheck.
Running tests: msr.
Running tests: nx.
Running tests: uefirtvariable.
Running tests: version.

OK thanks!
I guess it's related to a request from HWE
they want to split the FWTS test into two parts, those test cases in the _hwe.log will be passed to the HWE team for analysis, other issue will be redirect to PM for ODM / OEM's reference.

So I think the server provider needs a fix as well (log with _hwe won't be uploaded to C3), these are the affected test plans:
server-full-14.04.pxu: miscellanea/fwts_test
server-full-14.04.pxu: miscellanea/fwts_results.log
server-soc-cert.pxu: miscellanea/fwts_test
server-soc-cert.pxu: miscellanea/fwts_results.log

As the current _hwe log attachment job is called "firmware/fwts_desktop_diagnosis_results_hwe.log"
It's not looking for the fwtw_result_hwe.log, so we will need to add an extra attachment job for it.

In the other hand, maybe we can just merge the "firmware/fwts_desktop_diagnosis" and "miscellanea/fwts_test", they're running the same command, just with different log filename:
fwts_test -l $PLAINBOX_SESSION_SHARE/fwts_desktop_diagnosis_results.log
fwts_test -l $PLAINBOX_SESSION_SHARE/fwts_results.log

I'm not sure why we fork a identical one for desktop.

I will revert the bug status for certification provider, as it also contains the server provider.

As the server provider is affected as well, we will need to add one hwe attachment job in checkbox provider for it, as the log filename is different in client provider and server provider.

The branch MR mentioned in comment #6 is:
https://code.launchpad.net/~cypressyew/plainbox-provider-canonical-certification/+git/plainbox-provider-canonical-certification/+merge/269628

Since we have a new flag (--qa and --hwe) in the fwts_test script,
if we just run:
 fwts_test -l $PLAINBOX_SESSION_SHARE/fwts_results.log

It will run all the test cases in both QA and HWE test list:
CERT_TESTS = sorted(QA_TESTS + HWE_TESTS)

And store the log in to the assigned file, which is fwts_results.log in this case.

So in short,
we don't need this fix in the server provider, as we don't separate --hwe and --qatest cases like what we did in the client provider.
I will reject that branch.

And as the fix for master-client in Canonical Certification Provider for PlainBox has been merged (see comment #1), I will mark this as Fix-Committed again, thanks!