Ubuntu
indicator-network package

Access points shouldn't be "connectable" if a hotspot is enabled

Bug #1478160 reported by Tony Espy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
indicator-network (Ubuntu)
Fix Released
Undecided
Unassigned
indicator-network (Ubuntu RTM)
Fix Released
Undecided
Unassigned

Bug Description

While testing the touch hotspot feature ( currently in silo-046 ) on krillin ( stable, #24 ) and arale ( rc-proposed, #58 ), I noticed that it's possible to trigger the phone to connect to an AP while the hotspot is enabled.

Steps to reproduce:

1. Ensure that WiFi isn't connected to an AP
2. Enable hotspot
3. Display the network-menu and select an AP

Expected result:
You shouldn't be able to select any APs when hotspot is active.

Actual result:
The selected AP will trigger a connection attempt ( and succeed if open, or secure and secrets have been saved ).

Note, one other minor nit is that the hotspot is shown in the network-menu's list of APs. If this bug is fixed by not showing any APs in the menu anymore, then this becomes moot.

<https://wiki.ubuntu.com/Networking#hotspot>: "A hotspot requires exclusive use of your Wi-Fi connection. Therefore: ... * Whenever Hotspot is on, wherever Wi-Fi networks are listed, no networks should be shown."

See original description
Tags: hotspot

Related branches

lp:~pete-woods/indicator-network/no-aps-when-hotspot-enabled
PS Jenkins bot (community): Approve (continuous-integration)
Indicator Applet Developers: Pending requested
Diff: 472 lines (+166/-113) (has conflicts)
6 files modified
src/indicator/nmofono/kill-switch.cpp (+49/-27)
src/indicator/nmofono/kill-switch.h (+1/-3)
src/indicator/nmofono/manager-impl.cpp (+71/-70)
src/indicator/nmofono/wifi/wifi-link-impl.cpp (+38/-11)
src/indicator/nmofono/wifi/wifi-link-impl.h (+3/-1)
src/indicator/nmofono/wifi/wifi-link.h (+4/-1)
lp:ubuntu/wily-proposed/indicator-network
Tony Espy (awe)
tags: added: hotspot
Tony Espy (awe)
summary: - Access points shouldn't be "connectable" is hotspot is enababled
+ Access points shouldn't be "connectable" if a hotspot is enababled
summary: - Access points shouldn't be "connectable" if a hotspot is enababled
+ Access points shouldn't be "connectable" if a hotspot is enabled
Tony Espy (awe)
description: updated
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Specification updated. <https://wiki.ubuntu.com/Networking?action=diff&rev2=294&rev1=293>

Changed in indicator-network (Ubuntu):
status: New → Triaged
description: updated
Revision history for this message
Tony Espy (awe) wrote :

See bug #1478009 for more details about hotspot device behavior on krillin and arale.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :
Download full text (8.0 KiB)

This bug was fixed in the package indicator-network 0.5.2+15.04.20150810.1-0ubuntu1 in https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/stable-phone-overlay

---------------

indicator-network (0.5.2+15.04.20150810.1-0ubuntu1) vivid; urgency=medium

  [ Pete Woods ]
  * Add hotspot management.
  * Don't show access points when hotspot is enabled (LP: #1478160)
  * Hold a wakelock when the hotspot is active. (LP: #1458046)
  * Seed the random number generator (LP: #1478157)
  * Simplify wifi/flight toggles

indicator-network (0.5.1+15.10.20150727-0ubuntu2~gcc5.1) wily; urgency=medium

  * No change rebuild using GCC 5.

indicator-network (0.5.1+15.10.20150727-0ubuntu1) wily; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.

  [ Charles Kerr ]
  * drop build-dependency on g++-4.9 Edit (LP: #1452327)

indicator-network (0.5.1+15.10.20150708.1-0ubuntu1) wily; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.

  [ Pete Woods ]
  * Enteprise access points invoke the system settings app with details
    encoded in a URI

indicator-network (0.5.1+15.10.20150618.1-0ubuntu1) wily; urgency=medium

  [ Pete Woods ]
  * Add debugging to figure out what's happening to the SIM unlock on
    Arale (LP: #1465214)

indicator-network (0.5.1+15.10.20150604-0ubuntu1) wily; urgency=medium

  [ Pete Woods ]
  * Remove unity8 dependency to break cycle

indicator-network (0.5.1+15.10.20150519-0ubuntu1) wily; urgency=medium

  [ Antti Kaijanmäki ]
  * Fix .pc file and docs. (LP: #1456307)

indicator-network (0.5.1+15.04.20150513.1-0ubuntu1) vivid; urgency=medium

  [ Pete Woods ]
  * Add flight mode and wifi toggles to connectivity service interface
    removed: tests/integration/CMakeLists.txt
    tests/integration/connectivity-cpp/ tests/integration/connectivity-
    cpp/CMakeLists.txt tests/integration/connectivity-cpp/mocks/
    tests/integration/connectivity-cpp/mocks/urfkill.h
    tests/integration/connectivity-cpp/sig_term_catcher.h
    tests/integration/connectivity-cpp/test_data.h.in
    tests/integration/connectivity-cpp/test_flight_mode.cpp
    tests/integration/connectivity-cpp/test_networking_status.cpp
    tests/integration/connectivity-cpp/test_service.h
    tests/integration/connectivity-cpp/test_wifi_connect.cpp
    tests/integration/connectivity-cpp/test_wifi_link.cpp
    tests/integration/connectivity-cpp/test_wifi_link_dedup.cpp
    tests/integration/connectivity-cpp/test_wifi_link_enable_disable.cpp
    tests/integration/indicator/ tests/unit/indicator/CMakeLists.txt
    tests/unit/indicator/menuitems/CMakeLists.txt tests/unit/menumodel-
    cpp/CMakeLists.txt tests/unit/secret-agent/CMakeLists.txt
    tests/unit/test_variant.h added:
    data/org.freedesktop.DBus.Properties.xml src/connectivity-api/
    src/connectivity-api/CMakeLists.txt src/connectivity-
    api/connectivity-qml/ src/connectivity-api/connectivity-
    qml/CMakeLists.txt src/connectivity-api/connectivity-qt/
    src/connectivity-api/connectivity-qt/CMakeLists.txt
    src/connectivity-api/connectivity-qt/connectivityqt/
    src/connectivity-api/connectivity-qt/connectivityqt/connectivity.cpp
    src/connectivity-api/connectivity-qt/connectivityqt/con...

Read more...

Changed in indicator-network (Ubuntu RTM):
status: New → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package indicator-network - 0.5.2+15.10.20150810.1-0ubuntu1

---------------
indicator-network (0.5.2+15.10.20150810.1-0ubuntu1) wily; urgency=medium

  [ Pete Woods ]
  * Add hotspot management.
  * Don't show access points when hotspot is enabled (LP: #1478160)
  * Hold a wakelock when the hotspot is active. (LP: #1458046)
  * Seed the random number generator (LP: #1478157)
  * Simplify wifi/flight toggles

 -- CI Train Bot <email address hidden> Mon, 10 Aug 2015 16:51:11 +0000

Changed in indicator-network (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.