Ubuntu
signon-ui package

Platform check in request.cpp should check for ubuntu* platform

Bug #1473422 reported by Martin Klapetek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
signon-ui (Ubuntu)
Fix Released
Medium
Alberto Mardegan

Bug Description

In request.cpp around line 318, the code checks "if (QGuiApplication::platformName() != "xcb" || qgetenv("SSOUI_USE_UBUNTU_WEB_VIEW") == QByteArray("1")) {"

however it should either also have "... && != "wayland"" or have "... == "UbuntuTouchPlatformName""

This makes the signon-ui package shipped by ubuntu unusable on non-xcb platforms as it's build with "USE_UBUNTU_WEB_VIEW" and so it will always create "UbuntuBrowserRequest" rather than "BrowserRequest" which is what is wanted.

Related branches

lp:~mardy/signon-ui/lp1473422
David Barth (community): Approve
PS Jenkins bot (community): Needs Fixing (continuous-integration)
Diff: 53 lines (+4/-4)
3 files modified
common-project-config.pri (+0/-1)
src/request.cpp (+2/-2)
src/signon-ui.pro (+2/-1)
Alberto Mardegan (mardy)
Changed in signon-ui (Ubuntu):
importance: Undecided → Medium
assignee: nobody → Alberto Mardegan (mardy)
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package signon-ui - 0.17+15.10.20150810-0ubuntu1

---------------
signon-ui (0.17+15.10.20150810-0ubuntu1) wily; urgency=medium

  [ Alberto Mardegan ]
  * Fix portability to non-X11 platforms (LP: #1473422, #1473423)

 -- CI Train Bot <email address hidden> Mon, 10 Aug 2015 08:37:45 +0000

Changed in signon-ui (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.