[Online Accounts] Same Google account could be added repeatedly from System Settings-->Accounts
Bug #1468599 reported by
Evan Wang
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
High
|
Unassigned | ||
| Ubuntu UX |
Triaged
|
Medium
|
Matthew Paul Thomas | ||
| webapps-sprint |
Fix Released
|
High
|
Alberto Mardegan | ||
| ubuntu-system-settings-online-accounts (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
Bug Description
Krillin wily image #120, channel: ubuntu-
Steps to produce:
1.Open System Settings--> Accounts
2.Tap on Add account--> Google
3.Sign in an existed Google account and confirm
4.Repeat to add the same Google account
Expected results:
Same account should not be added repeatedly
Actual results:
Same account could be added repeatedly
Related branches
lp:~mardy/account-plugins/no-duplicates-1468599
- PS Jenkins bot (community): Approve (continuous-integration)
- Online Accounts: Pending requested
-
Diff: 78 lines (+18/-16)2 files modifiedqml/facebook/Main.qml (+14/-10)
qml/google/Main.qml (+4/-6)
lp:~mardy/ubuntu-system-settings-online-accounts/no-duplicates-1468599
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Online Accounts: Pending requested
-
Diff: 180 lines (+97/-14)4 files modifieddebian/control (+1/-1)
plugins/module/DuplicateAccount.qml (+40/-0)
plugins/module/OAuth.qml (+55/-13)
plugins/module/module.pro (+1/-0)
Revision history for this message
| Evan Wang (wsy324) wrote | #1 |
| affects: | ubuntu-system-settings (Ubuntu) → ubuntu-system-settings-online-accounts (Ubuntu) |
Revision history for this message
| Alberto Mardegan (mardy) wrote | #2 |
| Changed in ubuntu-ux: | |
| assignee: | nobody → Matthew Paul Thomas (mpt) |
| importance: | Undecided → Medium |
| status: | New → Triaged |
| Changed in ubuntu-ux: | |
| assignee: | Matthew Paul Thomas (mpt) → Andreea Pirvu (andreea-pirvu) |
| summary: |
- Same Google account could be added repeatedly from System - Settings-->Accounts + [Online Accounts] Same Google account could be added repeatedly from + System Settings-->Accounts |
Revision history for this message
| Andreea Pirvu (andreea-pirvu) wrote | #3 |
| Changed in ubuntu-ux: | |
| status: | Triaged → Fix Committed |
| Changed in ubuntu-system-settings-online-accounts (Ubuntu): | |
| status: | New → Confirmed |
| importance: | Undecided → High |
| Changed in webapps-sprint: | |
| status: | New → Confirmed |
| importance: | Undecided → High |
| assignee: | nobody → Alberto Mardegan (mardy) |
| milestone: | none → sprint-18 |
Revision history for this message
| Matthew Paul Thomas (mpt) wrote | #4 |
| Changed in ubuntu-ux: | |
| assignee: | Andreea Pirvu (andreea-pirvu) → Matthew Paul Thomas (mpt) |
| status: | Fix Committed → Confirmed |
| Changed in webapps-sprint: | |
| status: | Confirmed → In Progress |
| Changed in ubuntu-system-settings-online-accounts (Ubuntu): | |
| status: | Confirmed → In Progress |
| Changed in webapps-sprint: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-system-settings-online-accounts (Ubuntu): | |
| status: | In Progress → Fix Committed |
| Changed in canonical-devices-system-image: | |
| status: | New → Fix Committed |
| importance: | Undecided → High |
| milestone: | none → ww08-2016 |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #5 |
| Changed in ubuntu-system-settings-online-accounts (Ubuntu): | |
| status: | Fix Committed → Fix Released |
| Changed in webapps-sprint: | |
| status: | Fix Committed → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
| Changed in ubuntu-ux: | |
| status: | Confirmed → Triaged |
To post a comment you must log in.
I confirm that this is the case, however it's not clear to me how this should be fixed.
We can know that a duplicate account has been created only *after* the authentication completes. We probably need to show some error message to the user, and inform them that the same account already exists, and that the current account creation will be discarded.