Ubuntu
livecd-rootfs package

Modify cdimage build process to allow pin priorities for EXTRA_PPAs

Bug #1450257 reported by Adam Conrad
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu CD Images
Fix Released
Undecided
Adam Conrad
live-build (Ubuntu)
Fix Released
Undecided
Adam Conrad
Vivid
Fix Released
Undecided
Adam Conrad
livecd-rootfs (Ubuntu)
Fix Released
Undecided
Adam Conrad
Vivid
Fix Released
Undecided
Adam Conrad

Bug Description

[ SRU Justification ]
For the Phone stable overlay PPA, there's a need to occasionally have a package in the PPA older than those in stable-updates or stable-security. Other consumers of the EXTRA_PPA facility could also make use of this from time to time to pin things above or below defaults, as seems fit.

The method specced out at the core sprint was to extend the extra_ppas syntax from user/ppa to user/ppa:priority, with a lack of ":priority" being treated as the default, both for simplicity and backward compatibility.

[ Test Case ]
Build a livefs with several extra_ppas at different pin levels (and with no pin at all), to make sure they all behave as expected, including forcefully downgrading for pins over 1000. This has already been done here, however it can be done again with the final uploads, when they're in -proposed:

https://launchpad.net/~ubuntu-cdimage/+livefs/ubuntu/vivid/ubuntu-core/+build/25929

[ Regression Potential ]
Very slim, given the above testing. Builds without extra_ppas are entirely unaffected, and testing shows (and will show again, when repeated with the distro uploads) that extra_ppas specced without the :priority suffix are treated the same as they were before.

See original description
Revision history for this message
Adam Conrad (adconrad) wrote :

A simple parsing fix for this was already deployed to ubuntu-cdimage.

Changed in ubuntu-cdimage:
status: New → Fix Released
Adam Conrad (adconrad)
Changed in ubuntu-cdimage:
assignee: nobody → Adam Conrad (adconrad)
Changed in live-build (Ubuntu Vivid):
assignee: nobody → Adam Conrad (adconrad)
Changed in livecd-rootfs (Ubuntu Vivid):
assignee: nobody → Adam Conrad (adconrad)
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Adam, or anyone else affected,

Accepted live-build into vivid-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/live-build/3.0~a57-1ubuntu16.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in live-build (Ubuntu Vivid):
status: New → Fix Committed
tags: added: verification-needed
Changed in livecd-rootfs (Ubuntu Vivid):
status: New → Fix Committed
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Adam, or anyone else affected,

Accepted livecd-rootfs into vivid-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd-rootfs/2.300.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Adam Conrad (adconrad)
description: updated
Revision history for this message
Adam Conrad (adconrad) wrote :

A fresh test was done with extra_ppas set to ["adconrad/ppa:1001", "adconrad/virtual", "ci-train-ppa-service/stable-phone-overlay:750"] using the livecd-rootfs and live-build from vivid-proposed:

https://launchpad.net/~ubuntu-cdimage/+livefs/ubuntu/vivid/ubuntu-core/+build/25930

The build log shows the PPAs being configured, and the 1001 pin on adconrad/ppa forcing a downgrade of glibc. Grabbing the rootfs tarball and examining it locally shows that the sources.list and pin preferences persisted correctly in the final product.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Adam Conrad (adconrad) wrote :

And another round of testing with 2.300.2. This time with three test cases instead of one:

1) No PPAs specified at all:

https://launchpad.net/~ubuntu-cdimage/+livefs/ubuntu/vivid/ubuntu-core/+build/25949

2) Only one old-school PPA, without priority:

https://launchpad.net/~ubuntu-cdimage/+livefs/ubuntu/vivid/ubuntu-core/+build/25950

3) A mess of mixed extra_ppa options, including a violent downgrade pin:

https://launchpad.net/~ubuntu-cdimage/+livefs/ubuntu/vivid/ubuntu-core/+build/25951

All tests passed, and results were as expected.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package live-build - 3.0~a57-1ubuntu16.1

---------------
live-build (3.0~a57-1ubuntu16.1) vivid; urgency=medium

  * Backport changes from trunk to support pin priorities (LP: #1450257):
    - debian/patches/fix-preferences-copying: Fix copying apt preferences.
    - debian/patches/ubuntu-allow-downgrades: Allow base system downgrades.

 -- Adam Conrad <email address hidden> Wed, 29 Apr 2015 14:29:09 -0600

Changed in live-build (Ubuntu Vivid):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for live-build has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package livecd-rootfs - 2.300.2

---------------
livecd-rootfs (2.300.2) vivid; urgency=medium

  * live-build/auto/config: Conditionalize copying extra-ppas.pref.chroot.

livecd-rootfs (2.300.1) vivid; urgency=medium

  * live-build/auto/config: Handle applying priorities to EXTRA_PPAS
    via the extra_ppa="user/ppaname:priority" syntax (LP: #1450257)

 -- Adam Conrad <email address hidden> Thu, 30 Apr 2015 07:54:43 -0600

Changed in livecd-rootfs (Ubuntu Vivid):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.