Print service does not always put a blank line between verses
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenLP |
Fix Released
|
Low
|
Tomas Groth | ||
Bug Description
If specifying verse order with (ex) chorus 1 back-to-back, print service does not put a blank line between the verses.
ex:
---[Chorus:1]---
Worthy is the Lamb that was slain
Worthy is the Lamb that was slain
---[Chorus:1]---
Worthy is the Lamb that was slain
To receive power and riches
And wisdom and strength
Honor and glory and blessing
---[Chorus:1]---
Worthy is the Lamb
Worthy is the Lamb
Worthy is the Lamb that was slain
Worthy is the Lamb
---[Other:1]---
Verse order: C1 O1
=======
Expected print service output:
=======
Worthy is the Lamb that was slain
Worthy is the Lamb that was slain
Worthy is the Lamb that was slain
To receive power and riches
And wisdom and strength
Honor and glory and blessing
Worthy is the Lamb
Worthy is the Lamb
Worthy is the Lamb that was slain
Worthy is the Lamb
=======
Actual print service output:
=======
Worthy is the Lamb that was slain
Worthy is the Lamb that was slain
Worthy is the Lamb that was slain
To receive power and riches
And wisdom and strength
Honor and glory and blessing
Worthy is the Lamb
Worthy is the Lamb
Worthy is the Lamb that was slain
Worthy is the Lamb
Related branches
- Tim Bentley: Approve
- Raoul Snyman: Approve
-
Diff: 290 lines (+76/-27)8 files modifiedopenlp/core/common/uistrings.py (+2/-0)
openlp/core/lib/listwidgetwithdnd.py (+1/-1)
openlp/core/ui/printserviceform.py (+3/-1)
openlp/plugins/bibles/lib/mediaitem.py (+1/-1)
openlp/plugins/bibles/lib/versereferencelist.py (+21/-9)
openlp/plugins/images/lib/mediaitem.py (+2/-0)
openlp/plugins/media/lib/mediaitem.py (+6/-1)
tests/functional/openlp_plugins/images/test_lib.py (+40/-14)
| Ken Roberts (alisonken1) wrote | #1 |
| Changed in openlp: | |
| assignee: | nobody → Tomas Groth (tomasgroth) |
| status: | New → In Progress |
| Changed in openlp: | |
| milestone: | none → 2.1.4 |
| status: | In Progress → Fix Committed |
| Changed in openlp: | |
| status: | Fix Committed → Fix Released |
Another verse order example:
V1 C1 C1 V2 C1 V3 C1 C1
Whenever duplicate labels are defined in verse order, the duplicates are printed without a line break.
Example output:
V1
C1
C1
V2
C1
V3
C1
C1
Expected output:
V1
C1
C1
V2
C1
V3
C1
C1