OpenLP

Traceback when playing media with no players available/enabled

Bug #1422761 reported by Tomas Groth
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenLP
Fix Released
Medium
Tomas Groth
OpenLP 2.1.3

Bug Description

Found in OpenLP 2.1.2 build bzr2497, and reported in the support tracker.

When media is in the mediamanager, but no players is available (webkit isn't available on windows, VLC not installed and phonon not enabled), and media is played, this traceback pops up:

Traceback (most recent call last):
  File "D:\OpenLP_Development\OpenLP_Code\openlp\openlp\core\lib\mediamanageritem.py", line 464, in on_double_clicked
  File "D:\OpenLP_Development\OpenLP_Code\openlp\openlp\core\lib\mediamanageritem.py", line 489, in on_preview_click
  File "D:\OpenLP_Development\OpenLP_Code\openlp\openlp\core\common\openlpmixin.py", line 58, in wrapped
  File "D:\OpenLP_Development\OpenLP_Code\openlp\openlp\core\common\openlpmixin.py", line 54, in wrapped
  File "D:\OpenLP_Development\OpenLP_Code\openlp\openlp\core\ui\slidecontroller.py", line 779, in add_service_item
  File "D:\OpenLP_Development\OpenLP_Code\openlp\openlp\core\ui\slidecontroller.py", line 892, in _process_item
  File "D:\OpenLP_Development\OpenLP_Code\openlp\openlp\core\common\openlpmixin.py", line 58, in wrapped
  File "D:\OpenLP_Development\OpenLP_Code\openlp\openlp\core\common\openlpmixin.py", line 54, in wrapped
  File "D:\OpenLP_Development\OpenLP_Code\openlp\openlp\core\ui\slidecontroller.py", line 1342, in on_media_start
  File "D:\OpenLP_Development\OpenLP_Code\openlp\openlp\core\common\openlpmixin.py", line 58, in wrapped
  File "D:\OpenLP_Development\OpenLP_Code\openlp\openlp\core\common\openlpmixin.py", line 54, in wrapped
  File "D:\OpenLP_Development\OpenLP_Code\openlp\openlp\core\ui\media\mediacontroller.py", line 395, in video
  File "D:\OpenLP_Development\OpenLP_Code\openlp\openlp\core\ui\media\mediacontroller.py", line 523, in _check_file_type
KeyError: ''

Related branches

lp:~tomasgroth/openlp/bugfixes15
Raoul Snyman: Approve
Tim Bentley: Approve
Diff: 76 lines (+30/-3)
3 files modified
openlp/core/ui/media/mediacontroller.py (+3/-0)
openlp/plugins/alerts/lib/alertsmanager.py (+3/-2)
tests/functional/openlp_core_ui_media/test_mediacontroller.py (+24/-1)
lp:openlp
lp:~tomasgroth/openlp/bugfixes18
Raoul Snyman: Approve
Tim Bentley: Approve
Diff: 206 lines (+53/-13)
9 files modified
openlp/core/common/__init__.py (+3/-2)
openlp/core/lib/__init__.py (+1/-1)
openlp/core/ui/maindisplay.py (+2/-2)
openlp/core/ui/media/mediacontroller.py (+2/-0)
openlp/core/ui/thememanager.py (+9/-5)
openlp/plugins/custom/lib/mediaitem.py (+4/-0)
openlp/plugins/songs/lib/openlyricsxml.py (+2/-2)
tests/functional/openlp_core_lib/test_lib.py (+1/-1)
tests/functional/openlp_core_ui/test_thememanager.py (+29/-0)
Tomas Groth (tomasgroth)
Changed in openlp:
assignee: nobody → Tomas Groth (tomasgroth)
status: New → In Progress
Phill (phill-ridout)
Changed in openlp:
importance: Undecided → Medium
Tim Bentley (trb143)
Changed in openlp:
milestone: none → 2.1.3
status: In Progress → Fix Committed
Tim Bentley (trb143)
Changed in openlp:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.