Subnet Network Address is missing asterisk

If you get chance, please confirm the bug as well when you assign it to yourself.

Couldn't repro in master.
Could repro in juno.

I've got it here on current master. Create Subnet -> Network Address field has no asterisk but is a required field.

See attachment, it's my screen, I could see the asterisk.
Could you show your screen?

Here's what I see, on chrome/ubuntu

That is the wrong modal, you are showing the Create Network modal not the Create Subnet modal.

Can confirm for the create 'subnet' modal that the network address has no *

Thanks for the confirmation Sam.

@Wu Wenxiang, please follow the steps to reproduce to see the issue.

Fix proposed to branch: master
Review: https://review.openstack.org/158214

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/158214
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

In Progress is set automatically by Infra. If the Infra bot fails for some reason, please link a patch as well.

Fix proposed to branch: master
Review: https://review.openstack.org/274222

Alexis are you still working on this bug ?

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/274222
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Can I work on this bug.

Fix proposed to branch: master
Review: https://review.openstack.org/369477

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/369477
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Hey Rob,

Cannot reproduce this and I think we should close this since the current version of Horizon would not have this bug.

It does affect current version of horizon.
To reproduce for master:

click admin-> Networks.
Click on any of network name in the table.
Go to subnet tab.
Click create subnet.

This is where the Subnet Network Address is missing asterisk.

I want to work on this bug.

Fix proposed to branch: master
Review: https://review.openstack.org/457194

I have confirmed locally that the commit made in Change-Id 457194 does make the field required.

Also, the validation is present (as desired) for a resolution of this bug.?field.comment=Also, the validation is present (as desired) for a resolution of this bug.?field.comment=Also, the validation is present (as desired) for a resolution of this bug.

Fix proposed to branch: master
Review: https://review.openstack.org/468675

Change abandoned by Andrew Lenards (<email address hidden>) on branch: master
Review: https://review.openstack.org/468675
Reason: Abandoned this as I have achieved what I was hoping for with https://review.openstack.org/457194 now

I believe the patch is a fix, but there are 4 gates failing.

Fix proposed to branch: master
Review: https://review.openstack.org/491609

I am not sure why low-hanging-fruit bug has HIhg priority.... It looks like Low or Medium.

Fix proposed to branch: master
Review: https://review.openstack.org/555096

Reviewed: https://review.openstack.org/555096
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f8196331ea139f52b303eb87d0280152f06d9475
Submitter: Zuul
Branch: master

commit f8196331ea139f52b303eb87d0280152f06d9475
Author: Akihiro Motoki <email address hidden>
Date: Thu Mar 22 08:32:00 2018 +0900

    Add asterisk to conditionally required fields

    https://review.openstack.org/#/c/552247/ introduced a way to
    add asterisk mark to conditionally required fields.

    This commit covers several known forms:
    - Create Network / Create Subnet
    - Create Port
    - Attach Interface to Instance
    - Add Security Group Rule

    Change-Id: I809c23fd64dc2f379c3fdb585741c6b266ec5b1b
    Closes-Bug: #1420370
    Closes-Bug: #1292165
    Closes-Bug: #1755131

Change abandoned by Akihiro Motoki (<email address hidden>) on branch: master
Review: https://review.openstack.org/457194
Reason: abandoned due to inactivity. In addition, this bug has been fixed in a different approach.

Change abandoned by Akihiro Motoki (<email address hidden>) on branch: master
Review: https://review.openstack.org/491609
Reason: This is superseded by https://review.openstack.org/555096

This issue was fixed in the openstack/horizon 14.0.0.0b1 development milestone.