camera-app

camera-app click manifest should include camera-app-autopilot dependency for running tests

Bug #1419022 reported by Richard Huddie
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
Undecided
Unassigned
Canonical System Image ww11-ota
camera-app
Fix Released
High
Florian Boucault
camera-app (Ubuntu)
Fix Released
Undecided
Unassigned
camera-app (Ubuntu RTM)
Fix Released
Undecided
Unassigned

Bug Description

Running the camera-app tests as click package currently fails because not all dependencies get installed:

http://rtm-dashboard.ci.ubuntu.com/smokeng/utopic/touch_stable/krillin/228:20150206:20150129-c75dcfb/296/camera_app/123549/

Here python3-wand and python3-mediainfodll are not installed, so this causes the import failure:

ImportError: Failed to import test module: camera_app.tests.test_capture
Traceback (most recent call last):
  File "/usr/lib/python3.4/unittest/loader.py", line 312, in _find_tests
    module = self._get_module_from_name(name)
  File "/usr/lib/python3.4/unittest/loader.py", line 290, in _get_module_from_name
    __import__(name)
  File "/home/phablet/autopilot/camera_app/tests/test_capture.py", line 13, in <module>
    from wand.image import Image
ImportError: No module named 'wand'

In order to fix this, the camera-app-autopilot dependency should be added to the click manifest according to spec https://people.debian.org/~mpitt/autopkgtest/README.click-tests.html

manifest.json:

    "x-test": {
        "autopilot": {
            "autopilot_module": "@AUTOPILOT_DIR@",
            "depends": ["camera-app-autopilot"]
        }
    }

To run the tests using modified manifest file and a connected device:
adt-run --override-control=./path/to/modified/manifest.json --click=com.ubuntu.camera --- ssh -s adb

Related branches

lp:~fboucault/camera-app/click_autopilot_add_deps
PS Jenkins bot: Needs Fixing (continuous-integration)
Ubuntu Phablet Team: Pending requested
Diff: 14 lines (+4/-1)
1 file modified
manifest.json (+4/-1)
lp:ubuntu/vivid-proposed/camera-app
Florian Boucault (fboucault)
Changed in camera-app:
status: New → Confirmed
importance: Undecided → High
Florian Boucault (fboucault)
Changed in camera-app:
assignee: nobody → Florian Boucault (fboucault)
Florian Boucault (fboucault)
Changed in camera-app:
status: Confirmed → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package camera-app - 3.0.0+15.04.20150212.3-0ubuntu1

---------------
camera-app (3.0.0+15.04.20150212.3-0ubuntu1) vivid; urgency=medium

  [ Bill Filler ]
  * dynamically check for editor (LP: #1368787)
  * update depends on ui-extras new version

  [ Arthur Mello ]
  * Enable viewing full screen picture while in selection mode Remove
    actions from the slide show header if we are in selection mode Make
    it possible to toggle selection when on slide show view Scroll the
    last seem picture from slideshow into view when returning to the
    grid photo roll (LP: #1416043)

  [ Ugo Riboni ]
  * dynamically check for editor (LP: #1368787)

  [ Florian Boucault ]
  * Click packaging: add autopilot tests dependencies. (LP: #1419022)

  [ Ubuntu daily release ]
  * New rebuild forced
 -- Ubuntu daily release <email address hidden> Thu, 12 Feb 2015 19:41:11 +0000

Changed in camera-app (Ubuntu):
status: New → Fix Released
Bill Filler (bfiller)
Changed in canonical-devices-system-image:
milestone: none → ww09-2015
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package camera-app - 3.0.0+15.04.20150218~rtm-0ubuntu1

---------------
camera-app (3.0.0+15.04.20150218~rtm-0ubuntu1) 14.09; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.

  [ Ugo Riboni ]
  * Fix a bug preventing the thumbnails for videos to load correctly
    (LP: #1423177)

camera-app (3.0.0+15.04.20150217-0ubuntu1) vivid; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.

  [ Ugo Riboni ]
  * Fix some failing tests (that were failing for real test bugs, not
    due to infrastructure problems).

camera-app (3.0.0+15.04.20150212.3-0ubuntu1) vivid; urgency=medium

  [ Bill Filler ]
  * dynamically check for editor (LP: #1368787)
  * update depends on ui-extras new version

  [ Arthur Mello ]
  * Enable viewing full screen picture while in selection mode Remove
    actions from the slide show header if we are in selection mode Make
    it possible to toggle selection when on slide show view Scroll the
    last seem picture from slideshow into view when returning to the
    grid photo roll (LP: #1416043)

  [ Ugo Riboni ]
  * dynamically check for editor (LP: #1368787)

  [ Florian Boucault ]
  * Click packaging: add autopilot tests dependencies. (LP: #1419022)

  [ Ubuntu daily release ]
  * New rebuild forced

camera-app (3.0.0+15.04.20150210-0ubuntu1) vivid; urgency=medium

  [ Ubuntu daily release ]
  * New rebuild forced

  [ Florian Boucault ]
  * Swiping quickly through photo roll no longer causes photos to zoom.
    Workaround for QTBUG-39332. (LP: #1400141)

camera-app (3.0.0+15.04.20150204-0ubuntu1) vivid; urgency=medium

  [ CI Train Bot ]
  * Resync trunk

  [ Ugo Riboni ]
  * Add photo editor feature using the component from ubuntu-ui-extras.
    (LP: #1368787)
  * Refresh properly the thumbnails when the picture is changed. Make
    sure after the first change the file is still being watched.

  [ Ubuntu daily release ]
  * New rebuild forced

camera-app (3.0.0+15.04.20150127.1-0ubuntu1) vivid; urgency=low

  [ Ubuntu daily release ]
  * New rebuild forced

  [ Florian Boucault ]
  * Improve thumbnail generation performance: do not retrieve thumbnails
    for the view that is not visible.

  [ Ugo Riboni ]
  * Make hdr and flash options mutually exclusive (LP: #1350958)
  * Size option labels to fit the widest text in the column, so they
    look good in all languages (LP: #1413529)
 -- CI Train Bot <email address hidden> Wed, 18 Feb 2015 14:51:12 +0000

Changed in camera-app (Ubuntu RTM):
status: New → Fix Released
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
milestone: ww09-2015 → ww13-ota
status: New → Fix Released
Florian Boucault (fboucault)
Changed in camera-app:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.