Ubuntu
unity-scope-click package

Can submit reviews for click apps that are not in the store

Bug #1392307 reported by Alejandro J. Cura
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
unity-scope-click (Ubuntu)
Fix Released
High
dobey

Bug Description

Click apps that are not in the store currently show the input fields to submit reviews.

I tried submitting one such review; it did not fail, but I think it got lost because it's never shown back when opening the app preview again.

Related branches

lp:~dobey/unity-scope-click/missing-reviews
Charles Kerr (community): Approve
PS Jenkins bot: Needs Fixing (continuous-integration)
Diff: 66 lines (+14/-14)
2 files modified
libclickscope/click/preview.cpp (+13/-14)
libclickscope/click/preview.h (+1/-0)
Revision history for this message
Evan Wang (wsy324) wrote :

I also met this issue on Arale wily image #30, need to login Ubuntu one account first, then the review contents could be submitted successfully, otherwise, it's failed without any warning.

dobey (dobey)
Changed in unity-scope-click (Ubuntu):
status: Triaged → In Progress
assignee: nobody → Rodney Dawes (dobey)
dobey (dobey)
Changed in unity-scope-click (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-scope-click - 0.1.1+16.04.20160210-0ubuntu1

---------------
unity-scope-click (0.1.1+16.04.20160210-0ubuntu1) xenial; urgency=medium

  * Always convert query to lowercase. Add operator override to read
    call params back out for testing. Refactor tests to be able to test
    that query is lowercase. (LP: #1420528)
  * Disable harness tests during build for now. (LP: #1532358)
  * Refactor showing review widget to only do work if app is installed.
    Add qualifier to only show review widget if app has download_url
    from store. Don't check review.rating again to see if review is
    being submitted or not. (LP: #1392307, #1421710)

 -- Rodney Dawes <email address hidden> Wed, 10 Feb 2016 17:09:17 +0000

Changed in unity-scope-click (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.