pserv crashing while doing TFTP for HWE images

This is with a package built from the very latest trunk as of the date of this bug.

Ah here we go in maas-django.log:

ERROR 2014-10-17 10:46:51,167 twisted Unhandled Error
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 783, in __bootstrap
    self.__bootstrap_inner()
  File "/usr/lib/python2.7/threading.py", line 810, in __bootstrap_inner
    self.run()
  File "/usr/lib/python2.7/threading.py", line 763, in run
    self.__target(*self.__args, **self.__kwargs)
--- <exception caught here> ---
  File "/usr/lib/python2.7/dist-packages/twisted/python/threadpool.py", line 196, in _worker
    result = context.call(ctx, function, *args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/twisted/python/context.py", line 118, in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "/usr/lib/python2.7/dist-packages/twisted/python/context.py", line 81, in callWithContext
    return func(*args,**kw)
  File "/usr/lib/python2.7/dist-packages/provisioningserver/utils/twisted.py", line 143, in wrapper
    return func(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/maasserver/utils/async.py", line 153, in call_within_transaction
    return func(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/maasserver/rpc/nodes.py", line 159, in request_node_info_by_mac_address
    return (node, node.get_boot_purpose())
  File "/usr/lib/python2.7/dist-packages/maasserver/models/node.py", line 1530, in get_boot_purpose
    preseed_type = get_preseed_type_for(self)
  File "/usr/lib/python2.7/dist-packages/maasserver/preseed.py", line 352, in get_preseed_type_for
    purpose = get_available_purpose_for_node(purpose_order, node)
  File "/usr/lib/python2.7/dist-packages/maasserver/preseed.py", line 330, in get_available_purpose_for_node
    "Unable to determine purpose for node: '%s'", node.fqdn)
maasserver.exceptions.PreseedError: (u"Unable to determine purpose for node: '%s'", u'nuc1.maas')

I think this is related to bug 1378527 because it only happens when I use the precise image that was downloaded. That bug says that maas is functional but I don't think it is.

Regardless of the underlying bug, the PreseedError has not been caught before AMP tried to serialise it, so that needs handling correctly too.

Agreed, but AIUI PreseedError would not happen if bug 1378527 where fixed. If that is the case, then this doesn't need to land in 1.7.

I think we need to establish whether bug 1378257 is indeed the cause of this before making that assumption. Blake, can you comment please?

There was some serious issues with the BootImageMapping overriding the correct boot resource for HWE images. I am working on a fix for it at the moment, also looking into fixing an issue with using the correct kernel for HWE xinstall. Lets see if this resolves this issue.

I have a feeling it won't, as it should not affect determining the purpose for a node. But I will let you know once it has landed to give it a test.

Once this is merged into 1.7, give it another try to see if this fixes your issue.

https://code.launchpad.net/~blake-rouse/maas/fix-hwe-images-1.7/+merge/239003

It has been merged into 1.7, please give it a test to see if this issue occurs again.

I have tested deploying precise/generic, precise/hwe-p, precise/hwe-s, trusty/generic and have not had this issue.

Can anyone else check to see if they can reproduce this?

[testing hat] I'll give it a test shortly!
[release manager hat] Can you attach your branch to the bug please!

Confirmed working after I re-imported images (it failed if I didn't re-import).

This bug was filed in upstream MAAS and not in Ubuntu. It was fixed as part of 1.7. This was fixed and verified to be working in all Ubuntu releases. Ubuntu 1.7 is being SRU'd. Marking this as verification-done, as it seems to be blocking SRU.