Ubuntu
xchat package

Please backport xchat 2.8.4-ubuntu4 to feisty

Bug #137712 reported by Peter Meiser
12
Affects Status Importance Assigned to Milestone
Feisty Backports
Fix Released
Wishlist
Unassigned
xchat (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Binary package hint: xchat

Hi,

there's problem with xchat 2.8.4 and its XCHATSHAREDIR variable.

It's defined in configure.in as:
XCHATSHAREDIR=`eval echo ${datadir}`
AC_DEFINE_UNQUOTED(XCHATSHAREDIR, "$XCHATSHAREDIR")

So, the variable is "${prefix}/share" instead of "/usr/share".

When changing it to the following, it works:

XCHATSHAREDIR=`eval echo ${datarootdir}`
AC_DEFINE_UNQUOTED(XCHATSHAREDIR, "$XCHATSHAREDIR")

This variable is used for custom Op and Voice userlist icons and Tree View icons (http://www.xchat.org/faq/#q27) and for the icon shown by the notify balloon.

I'm attaching a patch for it.

Best regards,
Whoopie

Tags: patch

Related branches

lp:ubuntu/karmic/xchat
Revision history for this message
Peter Meiser (meiser79) wrote :
Revision history for this message
Peter Meiser (meiser79) wrote :

The easier solution is to add the datadir variable to the configure command in debian/rules

Revision history for this message
Scott Kitterman (kitterman) wrote :

Please work to get this fixed in Gutsy and then ask for a backport of the new version from Gutsy.

Changed in feisty-backports:
status: New → Invalid
Revision history for this message
Áron Sisak (asisak) wrote : Re: [PATCH] XCHATSHAREDIR variable not correct

xchat (2.8.4-0ubuntu3) gutsy; urgency=low

  * debian/rules:
    - Sets XCHATSHAREDIR correctly (patch by Whoopie) (LP: #137712)

 -- Aron Sisak <email address hidden> Thu, 06 Sep 2007 21:26:47 +0200

Changed in xchat:
status: New → Fix Released
Áron Sisak (asisak)
Changed in feisty-backports:
assignee: nobody → asisak
status: Invalid → In Progress
Changed in xchat:
importance: Undecided → Wishlist
Revision history for this message
Áron Sisak (asisak) wrote :

I tested this change: builds in a feisty pbuilder and runs as well on feisty.

Changed in feisty-backports:
assignee: asisak → nobody
status: In Progress → Confirmed
Revision history for this message
Scott Kitterman (kitterman) wrote : Re: Please backport xchat 2.8.4-ubuntu3 to feisty

Ack from ubuntu-backporters. Thanks for the fix.

Changed in feisty-backports:
importance: Undecided → Wishlist
status: Confirmed → In Progress
Revision history for this message
Alchera (barrysuridge) wrote :

One would expect a new package soon.

I downloaded the source from xchat.org, edited config.in to reflect 'XCHATSHAREDIR' (as above) and I still get "open("${prefix}/share/xchat/balh blah blah".

Revision history for this message
Peter Meiser (meiser79) wrote :

@Alchera: did you run autogen.sh to create a new configure script? Or just use the debian/rules patch.

Revision history for this message
Peter Meiser (meiser79) wrote :

@Áron Sisak: the patch was not applied as it was not added to the 00list file. But why not just changing the debian/rules file. I think, including a patch is not needed, just changing debian/rules.

Changed in xchat:
status: Fix Released → In Progress
Revision history for this message
Alchera (barrysuridge) wrote :

I ran autogen.sh a few minutes ago and nothing different.

config.log shows that '--prefix=/usr' is being used and DATADIR='${prefix}/share'; and as I do not have anything remotely resembling 'debian/rules' ....

Revision history for this message
Alchera (barrysuridge) wrote :

Ok, I seem to have fixed it.

The details are here: http://forum.xchat.org/viewtopic.php?p=14423&highlight=#14423

Revision history for this message
Áron Sisak (asisak) wrote :

xchat (2.8.4-0ubuntu4) gutsy; urgency=low

  * debian/rules:
    - Sets XCHATSHAREDIR correctly _indeed_ (patch by Whoopie) (LP: #137712)

 -- Aron Sisak <email address hidden> Sat, 08 Sep 2007 14:00:11 +0200

Changed in xchat:
status: In Progress → Fix Released
Revision history for this message
Áron Sisak (asisak) wrote :

Tested again: builds in feisty pbuilder and runs on a feisty system.

Revision history for this message
Alchera (barrysuridge) wrote :

Sorry! I misread the post of Thu, 06 Sep 2007 21:26:47 +0200

Revision history for this message
Scott Kitterman (kitterman) wrote :

Ack for 2.8.4-0ubuntu4 - Just to be clear since the bug's gotten a bit confusing.

Revision history for this message
Martin Pitt (pitti) wrote :

 * Trying to backport xchat...
  - <xchat_2.8.4.orig.tar.gz: downloading from librarian>
  - <xchat_2.8.4-0ubuntu4.diff.gz: downloading from librarian>
  - <xchat_2.8.4-0ubuntu4.dsc: downloading from librarian>
I: Extracting xchat_2.8.4-0ubuntu4.dsc ... done.
I: Building backport of xchat-2.8.4 as 2.8.4-0ubuntu4~feisty1 ... done.

Changed in feisty-backports:
status: In Progress → Fix Released
Revision history for this message
Peter Meiser (meiser79) wrote :

In maverick, the issue is back.

The changelog (xchat 2.8.6-6ubuntu1) mentions that this change was reverted to fix a FTBFS. This is not true for 2.8.8 as the package built fine in my PPA.

Please find attached a debdiff for maverick.

Changed in xchat (Ubuntu):
status: Fix Released → Confirmed
Brian Murray (brian-murray)
tags: added: patch
Revision history for this message
Micah Gersten (micahg) wrote :

Please file a new bug for this and reference this bug # if it's related.

Changed in xchat (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.