AbstractScopeBase missing a virtual destructor
Bug #1360266 reported by
Marcus Tomlinson
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| unity-scopes-api (Ubuntu) |
Fix Released
|
Low
|
Marcus Tomlinson | ||
Bug Description
Adding a virtual destructor to AbstractScopeBase causes an ABI break. We should make this fix as soon as we have the capacity to handle that.
Related branches
lp:~marcustomlinson/unity-scopes-api/child_scopes_ordered
- PS Jenkins bot (community): Approve (continuous-integration)
- Michi Henning (community): Approve
-
Diff: 1756 lines (+1184/-27)42 files modifiedCMakeLists.txt (+1/-1)
RELEASE_NOTES.md (+7/-0)
debian/changelog (+9/-0)
debian/libunity-scopes3.symbols (+10/-1)
include/unity/scopes/AbstractScopeBase.h (+9/-0)
include/unity/scopes/ChildScope.h (+50/-0)
include/unity/scopes/Runtime.h (+0/-19)
include/unity/scopes/Scope.h (+16/-0)
include/unity/scopes/ScopeBase.h (+27/-0)
include/unity/scopes/internal/ChildScopesRepository.h (+68/-0)
include/unity/scopes/internal/MWScope.h (+4/-1)
include/unity/scopes/internal/ScopeBaseImpl.h (+11/-0)
include/unity/scopes/internal/ScopeImpl.h (+3/-0)
include/unity/scopes/internal/ScopeObject.h (+3/-0)
include/unity/scopes/internal/ScopeObjectBase.h (+4/-0)
include/unity/scopes/internal/smartscopes/SSScopeObject.h (+3/-0)
include/unity/scopes/internal/zmq_middleware/ScopeI.h (+6/-0)
include/unity/scopes/internal/zmq_middleware/ZmqScope.h (+3/-0)
include/unity/scopes/testing/MockScope.h (+4/-0)
src/scopes/AbstractScopeBase.cpp (+37/-0)
src/scopes/CMakeLists.txt (+1/-0)
src/scopes/Runtime.cpp (+0/-5)
src/scopes/ScopeBase.cpp (+10/-0)
src/scopes/internal/CMakeLists.txt (+1/-0)
src/scopes/internal/ChildScopesRepository.cpp (+243/-0)
src/scopes/internal/RuntimeImpl.cpp (+7/-0)
src/scopes/internal/ScopeBaseImpl.cpp (+50/-0)
src/scopes/internal/ScopeImpl.cpp (+10/-0)
src/scopes/internal/ScopeObject.cpp (+10/-0)
src/scopes/internal/smartscopes/SSScopeObject.cpp (+10/-0)
src/scopes/internal/zmq_middleware/ScopeI.cpp (+49/-0)
src/scopes/internal/zmq_middleware/ZmqScope.cpp (+50/-0)
src/scopes/internal/zmq_middleware/capnproto/Scope.capnp (+21/-0)
test/gtest/scopes/CMakeLists.txt (+1/-0)
test/gtest/scopes/ChildScopes/CMakeLists.txt (+10/-0)
test/gtest/scopes/ChildScopes/ChildScopes_test.cpp (+325/-0)
test/gtest/scopes/ChildScopes/Registry.ini.in (+6/-0)
test/gtest/scopes/ChildScopes/Runtime.ini.in (+6/-0)
test/gtest/scopes/ChildScopes/TestScope.h (+83/-0)
test/gtest/scopes/ChildScopes/Zmq.ini.in (+2/-0)
test/gtest/scopes/internal/RegistryObject/RegistryObject_test.cpp (+4/-0)
test/gtest/scopes/internal/zmq_middleware/ZmqMiddleware/ZmqMiddleware_test.cpp (+10/-0)
| Changed in unity-scopes-api: | |
| assignee: | nobody → Marcus Tomlinson (marcustomlinson) |
| Changed in unity-scopes-api: | |
| importance: | Undecided → Low |
| affects: | unity-scopes-api → unity-scopes-api (Ubuntu) |
| Changed in unity-scopes-api (Ubuntu): | |
| status: | New → In Progress |
| Changed in unity-scopes-api (Ubuntu): | |
| status: | In Progress → New |
| status: | New → Confirmed |
| Changed in unity-scopes-api (Ubuntu): | |
| status: | Confirmed → In Progress |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in unity-scopes-api (Ubuntu): | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
This bug was fixed in the package unity-scopes-api - 0.6.12+
---------------
unity-scopes-api (0.6.12+
[ Marcus Tomlinson ]
* Introduced child_scopes() methods for aggregators to return their
list of child scopes at runtime.
* Added missing virtual destructor to AbstractScopeBase. (LP: #1360266)
* Removed deprecated Runtime:
* Prevent query from looping indefinitely if a query is forwarded
among aggregators and loops back to an earlier aggregator.
[ Ubuntu daily release ]
* debian/
* New rebuild forced
[ Michi Henning ]
* Fixed memory leak in BufferedResultF
warnings for clang build. Minor updates to HACKING.
* Fixed coverage build.
-- Ubuntu daily release <email address hidden> Tue, 27 Jan 2015 09:38:46 +0000