Ubuntu
ubuntu-system-settings package

User shouldn't be prompted for password to switch to swipe if it's not needed

Bug #1350381 reported by Michael Terry
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-system-settings (Ubuntu)
Fix Released
Medium
Michael Terry
ubuntu-system-settings (Ubuntu RTM)
Fix Released
Undecided
Unassigned

Bug Description

Switching to swipe requires authenticating via policykit to ask AccountsService to make the switch for us.

So if we have already switched password types recently, policykit doesn't actually need to have the user authenticate again. Yet we always ask for a password.

Which means that when a user enters a wrong password, we go ahead with the switch anyway. Which is probably misleading. We should just go ahead and do the switch.

We can probably ask policykit directly if we are already authenticated before asking the user.

Related branches

lp:~mterry/ubuntu-system-settings/avoid-agent-race
Ken VanDine: Approve
PS Jenkins bot: Approve (continuous-integration)
Diff: 225 lines (+71/-24)
5 files modified
plugins/security-privacy/LockSecurity.qml (+5/-1)
plugins/security-privacy/helper.cpp (+9/-3)
plugins/security-privacy/polkitlistener.cpp (+3/-1)
plugins/security-privacy/securityprivacy.cpp (+51/-18)
plugins/security-privacy/securityprivacy.h (+3/-1)
lp:ubuntu/utopic-proposed/ubuntu-system-settings
Michael Terry (mterry)
Changed in ubuntu-system-settings (Ubuntu):
assignee: nobody → Michael Terry (mterry)
Pat McGowan (pat-mcgowan)
Changed in ubuntu-system-settings (Ubuntu):
importance: Undecided → Medium
status: New → Confirmed
Michael Terry (mterry)
Changed in ubuntu-system-settings (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-system-settings - 0.3+14.10.20140829.1-0ubuntu1

---------------
ubuntu-system-settings (0.3+14.10.20140829.1-0ubuntu1) utopic; urgency=low

  [ Michael Terry ]
  * When changing to swipe mode, it was possible that our policykit
    agent would not unregister itself, making the next attempt to change
    modes appear to work, but in truth fail. Also, no longer ask for a
    password to switch to swipe mode if policykit has a cached
    authentication for us. (LP: #1350381)

  [ Sebastien Bacher ]
  * [security] tweak some pin locking details to match the design better
 -- Ubuntu daily release <email address hidden> Fri, 29 Aug 2014 05:19:18 +0000

Changed in ubuntu-system-settings (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Selene ToyKeeper (toykeeper) wrote :

I tested the fix for this from silo rtm 003, on top of rtm krillin image 6. It doesn't exactly work as intended... Basically, it now asks the user to enter the passphrase after *every* change, even if the change succeeded and has already taken effect. I can at least hit 'cancel' when switching back to 'swipe', but it shouldn't really be asking at all.

Changed in ubuntu-system-settings (Ubuntu):
status: Fix Released → Confirmed
Michał Sawicz (saviq)
Changed in ubuntu-system-settings (Ubuntu):
status: Confirmed → In Progress
Changed in ubuntu-system-settings (Ubuntu RTM):
status: New → In Progress
Michael Terry (mterry)
Changed in ubuntu-system-settings (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-system-settings - 0.3+14.10.20140904.2~rtm-0ubuntu1

---------------
ubuntu-system-settings (0.3+14.10.20140904.2~rtm-0ubuntu1) 14.09; urgency=low

  [ Ken VanDine ]
  * Tweak the depends for accountsservice-ubuntu-schemas to handle a "~"
    version

  [ CI bot ]
  * Resync trunk
 -- Ubuntu daily release <email address hidden> Thu, 04 Sep 2014 21:04:28 +0000

Changed in ubuntu-system-settings (Ubuntu RTM):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.