Mir

clang emits lots of warnings about lttng headers

Bug #1348472 reported by Daniel van Vugt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Low
Chris Halse Rogers
Mir 0.8.0
mir (Ubuntu)
Fix Released
Low
Unassigned
mir (Ubuntu RTM)
Fix Released
Low
Unassigned

Bug Description

clang emits lots of warnings about lttng headers. We should fix or hide these...

In file included from /home/dan/bzr/mir/warn/src/server/report/lttng/session_mediator_report.cpp:21:
/home/dan/bzr/mir/warn/include/shared/mir/report/lttng/mir_tracepoint.h:36:9: warning:
      Building with clang: Disabling LTTng tracepoints. [-W#pragma-messages]
#pragma message "Building with clang: Disabling LTTng tracepoints."
        ^
In file included from /home/dan/bzr/mir/warn/src/server/report/lttng/session_mediator_report.cpp:25:
/home/dan/bzr/mir/warn/src/server/report/lttng/session_mediator_report_tp.h:42:1: warning:
      unused function
      '__tracepoint_cb_mir_server_session_mediator___session_connect_called'
      [-Wunused-function]
MIR_SESSION_MEDIATOR_EVENT(session_connect_called)
^
/home/dan/bzr/mir/warn/src/server/report/lttng/session_mediator_report_tp.h:40:5: note:
      expanded from macro 'MIR_SESSION_MEDIATOR_EVENT'
    TRACEPOINT_EVENT_INSTANCE(mir_server_session_mediator, application_e...
    ^
/usr/include/lttng/tracepoint.h:512:2: note: expanded from macro
      'TRACEPOINT_EVENT_INSTANCE'
        _DECLARE_TRACEPOINT(provider, name, _TP_PARAMS(args)) \
        ^
/usr/include/lttng/tracepoint.h:158:6: note: expanded from macro
      '_DECLARE_TRACEPOINT'
void __tracepoint_cb_##_provider##___##_name(_TP_ARGS_PROTO(__VA_ARGS__)...
     ^
<scratch space>:166:1: note: expanded from here
__tracepoint_cb_mir_server_session_mediator___session_connect_called
^
In file included from /home/dan/bzr/mir/warn/src/server/report/lttng/session_mediator_report.cpp:25:
/home/dan/bzr/mir/warn/src/server/report/lttng/session_mediator_report_tp.h:43:1: warning:
      unused function
      '__tracepoint_cb_mir_server_session_mediator___session_create_surface_called'
      [-Wunused-function]

Related branches

lp:~raof/mir/remove-old-clang-workaround
PS Jenkins bot (community): Approve (continuous-integration)
Alberto Aguirre (community): Approve
Daniel van Vugt: Approve
Diff: 235 lines (+0/-92)
12 files modified
include.private/common/mir/report/lttng/mir_tracepoint.h (+0/-17)
src/client/lttng/input_receiver_report_tp.h (+0/-14)
src/client/lttng/rpc_report_tp.h (+0/-14)
src/server/report/lttng/compositor_report_tp.h (+0/-2)
src/server/report/lttng/connector_report_tp.h (+0/-2)
src/server/report/lttng/display_report_tp.h (+0/-2)
src/server/report/lttng/input_report_tp.h (+0/-2)
src/server/report/lttng/lttng_utils.h (+0/-11)
src/server/report/lttng/lttng_utils_pop.h (+0/-22)
src/server/report/lttng/message_processor_report_tp.h (+0/-2)
src/server/report/lttng/scene_report_tp.h (+0/-2)
src/server/report/lttng/session_mediator_report_tp.h (+0/-2)
lp:ubuntu/utopic-proposed/mir
Daniel van Vugt (vanvugt)
Changed in mir:
importance: Undecided → Low
status: New → Triaged
Daniel van Vugt (vanvugt)
Changed in mir:
status: Triaged → In Progress
assignee: nobody → Chris Halse Rogers (raof)
milestone: none → 0.8.0
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir/devel at revision None, scheduled for release in mir, milestone Unknown

Changed in mir:
status: In Progress → Fix Committed
Daniel van Vugt (vanvugt)
Changed in mir (Ubuntu):
importance: Undecided → Low
status: New → Triaged
Daniel van Vugt (vanvugt)
Changed in mir:
status: Fix Committed → Fix Released
Daniel van Vugt (vanvugt)
Changed in mir (Ubuntu RTM):
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (5.5 KiB)

This bug was fixed in the package mir - 0.8.0+14.10.20141010-0ubuntu1

---------------
mir (0.8.0+14.10.20141010-0ubuntu1) utopic; urgency=medium

  [ Daniel van Vugt ]
  * New upstream release 0.8.0 (https://launchpad.net/mir/+milestone/0.8.0)
    - Enhancements:
      . Less sensitivity to ABI breaks - many headers unused by external
        projects are now hidden and not installed by -dev packaes. If you
        require any headers that are missing, just ask.
      . Touchspots: --enable-touchspots to servers; visually shows touch
        locations (warning: This affects performance LP: #1373692).
      . Client performance reporting: Any Mir client can now get accurate
        performance information (frame rate, render time, buffer lag etc)
        logged to stdout. Just set env MIR_CLIENT_PERF_REPORT=log
      . Further improved touch responsiveness, with less lag and smoother
        scrolling (so long as you don't enable touchspots).
      . Slightly faster builds using precompiled headers.
      . Turn hardware overlays on by default. When in use, this halves the
        CPU usage of a Mir server. Already enabled in unity-system-compositor.
      . More scripting to detect ABI breaks.
      . Improved src/ tree consistency (renamed "src/shared" to "src/common").
      . Improved fatal signal design: Changed from SIGTERM to SIGHUP delivered
        to clients on unexpected server disconnection.
      . Improved library/package design to allow concurrent installations
        of different Mir versions without conflicts.
      . Fd reception code is now common to client and server.
    - ABI summary: Servers need rebuilding, but clients do not;
      . Mirclient ABI unchanged at 8
      . Mircommon ABI bumped to 2
      . Mirplatform ABI bumped to 3
      . Mirserver ABI bumped to 26
    - API changes between Mir 0.7 and 0.8:
      . Lots of headers removed from the public SDK! We have only hidden
        headers not known to be used by any known projects. Please let us
        know if anything is missing - https://bugs.launchpad.net/mir/+filebug
      . graphics::Platform - interface changed significantly.
      . Lots of server API changes to support touchspots.
      . File descriptors now passed as type Fd instead of int32_t.
    - Bug fixes:
      . [regression] Mir deb packages with versioned names cannot be installed
        simultaneously any more (LP: #1293944)
      . A frozen client can hang the whole server (LP: #1350207)
      . QtMir FTBFS: fatal error: mir/input/input_channel.h: No such file or
        directory (LP: #1365934)
      . [regression] platform-api fails to build against Mir 0.8 (LP: #1368354)
      . Mir FTBFS with gcc 4.9.1-14 (utopic update):
        auto_unblock_thread.h:44:46: error: no matching function for call to
        ‘std::thread::thread(<brace-enclosed initializer list>)’ (LP: #1369389)
      . [regression] Compositing is jerky and stutters during touch events
        (LP: #1372850)
      . unit test fails: AndroidInputReceiverSetup.slow_raw_input_doesnt_cause_
        frameskipping (LP: #1373826)
      . intermittent hang in TestClientInput (LP: #1338612)
      . TestClientInput.scene_obscure_mo...

Read more...

Changed in mir (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (5.4 KiB)

This bug was fixed in the package mir - 0.8.0+14.10.20141005-0ubuntu1

---------------
mir (0.8.0+14.10.20141005-0ubuntu1) 14.09; urgency=medium

  [ Daniel van Vugt ]
  * New upstream release 0.8.0 (https://launchpad.net/mir/+milestone/0.8.0)
    - Enhancements:
      . Less sensitivity to ABI breaks - many headers unused by external
        projects are now hidden and not installed by -dev packaes. If you
        require any headers that are missing, just ask.
      . Touchspots: --enable-touchspots to servers; visually shows touch
        locations (warning: This affects performance LP: #1373692).
      . Client performance reporting: Any Mir client can now get accurate
        performance information (frame rate, render time, buffer lag etc)
        logged to stdout. Just set env MIR_CLIENT_PERF_REPORT=log
      . Further improved touch responsiveness, with less lag and smoother
        scrolling (so long as you don't enable touchspots).
      . Slightly faster builds using precompiled headers.
      . Turn hardware overlays on by default. When in use, this halves the
        CPU usage of a Mir server. Already enabled in unity-system-compositor.
      . More scripting to detect ABI breaks.
      . Improved src/ tree consistency (renamed "src/shared" to "src/common").
      . Improved fatal signal design: Changed from SIGTERM to SIGHUP delivered
        to clients on unexpected server disconnection.
      . Improved library/package design to allow concurrent installations
        of different Mir versions without conflicts.
      . Fd reception code is now common to client and server.
    - ABI summary: Servers need rebuilding, but clients do not;
      . Mirclient ABI unchanged at 8
      . Mircommon ABI bumped to 2
      . Mirplatform ABI bumped to 3
      . Mirserver ABI bumped to 26
    - API changes between Mir 0.7 and 0.8:
      . Lots of headers removed from the public SDK! We have only hidden
        headers not known to be used by any known projects. Please let us
        know if anything is missing - https://bugs.launchpad.net/mir/+filebug
      . graphics::Platform - interface changed significantly.
      . Lots of server API changes to support touchspots.
      . File descriptors now passed as type Fd instead of int32_t.
    - Bug fixes:
      . [regression] Mir deb packages with versioned names cannot be installed
        simultaneously any more (LP: #1293944)
      . A frozen client can hang the whole server (LP: #1350207)
      . QtMir FTBFS: fatal error: mir/input/input_channel.h: No such file or
        directory (LP: #1365934)
      . [regression] platform-api fails to build against Mir 0.8 (LP: #1368354)
      . Mir FTBFS with gcc 4.9.1-14 (utopic update):
        auto_unblock_thread.h:44:46: error: no matching function for call to
        ‘std::thread::thread(<brace-enclosed initializer list>)’ (LP: #1369389)
      . [regression] Compositing is jerky and stutters during touch events
        (LP: #1372850)
      . unit test fails: AndroidInputReceiverSetup.slow_raw_input_doesnt_cause_
        frameskipping (LP: #1373826)
      . intermittent hang in TestClientInput (LP: #1338612)
      . TestClientInput.scene_obscure_mot...

Read more...

Changed in mir (Ubuntu RTM):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.