Ubuntu
pkgbinarymangler package

Must not create translation tarballs for partner component

Bug #133822 reported by Martin Pitt on 2007-08-21

6

Affects		Status	Importance	Assigned to	Milestone
	pkgbinarymangler (Ubuntu)	Fix Released	High	Unassigned
	Dapper	Invalid	Undecided	Unassigned
	Edgy	Fix Released	High	Martin Pitt
	Feisty	Fix Released	High	Martin Pitt
	pkgstriptranslations (Ubuntu)	Invalid	Undecided	Unassigned
	Dapper	Fix Released	High	Martin Pitt
	Edgy	Invalid	Undecided	Unassigned
	Feisty	Invalid	Undecided	Unassigned

Bug Description

Binary package hint: pkgbinarymangler

pkgstriptranslations currently creates translation tarballs for packages in the partner section, too. Uploading those does not work, because the translation tarballs go to the 'main' soyuz archive (raw-translations special handling).

Also it is desirable to not alter maintainer fields for partner packages, so pkgmaintainermangler should be silenced for partner packages, too.

Thus, pkgbinarymangler should be inactive for all packages which go to the partner repo. These packages are guaranteed to specify the 'partner' section in debian/control, like

Section: partner/web

This has recently been fixed in gutsy, but needs to be done for stables as well, since we will soon have partner repos for those, too.

See original description

Tags:

Related branches

lp:ubuntu/edgy-proposed/pkgbinarymangler

lp:ubuntu/feisty-updates/pkgbinarymangler

lp:ubuntu/dapper-proposed/pkgstriptranslations

Revision history for this message

Martin Pitt (pitti) wrote on 2007-08-21:

#1

Gutsy got fixed yesterday:

pkgbinarymangler (43) gutsy; urgency=low
.
* dpkg-deb: Do not do anything for commercial packages.

Changed in pkgbinarymangler:
importance:	Undecided → High
status:	New → Fix Released
assignee:	nobody → pitti
importance:	Undecided → High
assignee:	nobody → pitti
importance:	Undecided → High

Revision history for this message

Martin Pitt (pitti) wrote on 2007-08-21:

#2

debdiff Edit (1.2 KiB, text/plain)

This is the debdiff used for Gutsy. It works for dapper to feisty, too.

It's pretty simple: When debian/control puts a package into Section: commercial/..., it implicitly enables $NO_PKG_MANGLE, which is a proven way to disable any pkgbinarymangler magic.

Revision history for this message

Martin Pitt (pitti) wrote on 2007-08-21:

#3

Reproduction recipe:

* Install pkgbinarymangler
* Set "enable=true" in /etc/pkgbinarymangler/striptranslations.conf
* Build a package with "Section: commercial/web" (or a different section, doesn't matter)
* With current package, you'll get a _translations.tar.gz.
* With updated package you will not get a translation tarball, and a debugging note that binary mangling is disabled.

Martin Pitt (pitti) on 2007-08-21

Changed in pkgbinarymangler:
status:	New → Invalid
Changed in pkgstriptranslations:
status:	New → Invalid
status:	New → Invalid
assignee:	nobody → pitti
importance:	Undecided → High

Revision history for this message

Martin Pitt (pitti) wrote on 2007-08-21:

#4

debdiff for Feisty Edit (1.3 KiB, text/plain)

debdiff for Feisty, for completeness, and because the gutsy debdiff does not apply automatically. This works cleanly for edgy and dapper, too (except for the changelog, of course).

Revision history for this message

Martin Pitt (pitti) wrote on 2007-08-21:

#5

All packages uploaded, but I want to wait for Colin's approval until I actually approve them.

Revision history for this message

Colin Watson (cjwatson) wrote on 2007-08-21:

#6

Accepted into {dapper,edgy,feisty}-proposed.

Changed in pkgbinarymangler:
status:	New → Fix Committed
status:	New → Fix Committed
Changed in pkgstriptranslations:
status:	New → Fix Committed

Martin Pitt (pitti) on 2007-08-21

Changed in pkgstriptranslations:
status:	New → Invalid

Revision history for this message

Martin Pitt (pitti) wrote on 2007-08-21:

#7

pkgbinarymangler (39.1) feisty-proposed; urgency=low

* dpkg-deb: Do not do anything for commercial packages. (LP: #133822)

-- Martin Pitt <email address hidden> Tue, 21 Aug 2007 12:35:31 +0200

Changed in pkgbinarymangler:
status:	Fix Committed → Fix Released

Revision history for this message

Fabio Massimo Di Nitto (fabbione) wrote on 2007-08-22:

#8

This is the error I am getting when testing feisty:

INFO: Disabling pkgbinarymangler for commercial packages
WARNING: not running pkgbinarymangler for this package, as requested
dpkg-deb: building package `realplay' in `../realplay_10.0.9-0feisty1_i386.deb'.
dpkg-genchanges -b
dpkg-genchanges: binary-only upload - not including any source code
dpkg-genchanges: failure: cannot open upload file ../realplay_10.0.9-0feisty1_i386_translations.tar.gz for reading: No such file or directory
fabbione@feisty-commercial:~/realplay-10.0.9$ echo $?
2

Martin Pitt (pitti) on 2007-08-22

Changed in pkgbinarymangler:
status:	Fix Released → Fix Committed

Revision history for this message

Fabio Massimo Di Nitto (fabbione) wrote on 2007-08-22:

#9

nevermind the last comment. it's all good.. in feisty

Revision history for this message

Martin Pitt (pitti) wrote on 2007-08-22:

#10

For the record, above error with realplay comes from the fact that it uses "dh_clean -k" instead of "dh_clean" in debian/rules. That should be fixed, but has nothing to do with this SRU.

Revision history for this message

Fabio Massimo Di Nitto (fabbione) wrote on 2007-08-22:

#11

Edgy is also good...

Fabio

Revision history for this message

Fabio Massimo Di Nitto (fabbione) wrote on 2007-08-22:

#12

dapper is also good..

Fabio

Revision history for this message

Martin Pitt (pitti) wrote on 2007-08-22:

#13

Thanks, Fabio, for the testing. I mark this as verification-done. This can go into -updates on August 28.

Revision history for this message

Colin Watson (cjwatson) wrote on 2007-08-31:

#14

Copied to {dapper,edgy,feisty}-updates.

Changed in pkgstriptranslations:
status:	Fix Committed → Fix Released
Changed in pkgbinarymangler:
status:	Fix Committed → Fix Released
status:	Fix Committed → Fix Released

Revision history for this message

Fabio Massimo Di Nitto (fabbione) wrote on 2007-09-03:

#15

commercial archive has been renamed and this bug needs to be updated.

Changed in pkgbinarymangler:
status:	Fix Released → In Progress
status:	Fix Released → In Progress
Changed in pkgstriptranslations:
status:	Fix Released → In Progress

Revision history for this message

Fabio Massimo Di Nitto (fabbione) wrote on 2007-09-03:

#18

gutsy debdiff Edit (1.3 KiB, text/plain)

Gutsy debdiff.

Revision history for this message

Fabio Massimo Di Nitto (fabbione) wrote on 2007-09-03:

#19

feisty debdiff Edit (1.4 KiB, text/plain)

Changed in pkgbinarymangler:
status:	In Progress → Fix Committed
status:	In Progress → Fix Committed

Revision history for this message

Fabio Massimo Di Nitto (fabbione) wrote on 2007-09-03:

#20

edgy debdiff Edit (1.4 KiB, text/plain)

Changed in pkgstriptranslations:
status:	In Progress → Fix Committed

Revision history for this message

Fabio Massimo Di Nitto (fabbione) wrote on 2007-09-03:

#21

dapper debdiff Edit (1.4 KiB, text/plain)

description:

updated

Revision history for this message

Fabio Massimo Di Nitto (fabbione) wrote on 2007-09-24:

#22

feisty tested again on Martin request and it is working as expected.

Revision history for this message

Fabio Massimo Di Nitto (fabbione) wrote on 2007-09-24:

#23

edgy tested again on Martin request and it is working as expected.

Revision history for this message

Fabio Massimo Di Nitto (fabbione) wrote on 2007-09-24:

#24

dapper tested again on Martin request and it is working as expected.

Revision history for this message

Martin Pitt (pitti) wrote on 2007-09-24:

#25

Accepted into {dapper,edgy,feisty}-updates.

Changed in pkgbinarymangler:
status:	Fix Committed → Fix Released
status:	Fix Committed → Fix Released
Changed in pkgstriptranslations:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Patches

Add patch

Bug attachments

Add attachment

Remote bug watches

Bug watches keep track of this bug in other bug trackers.